From: Brian Norris <briannorris@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Wei-Ning Huang <wnhuang@chromium.org>,
Julius Werner <jwerner@chromium.org>,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v3 0/7] firmware: coreboot: Fix probe and simplify code
Date: Thu, 9 Aug 2018 11:03:18 -0700 [thread overview]
Message-ID: <20180809180316.GD129285@ban.mtv.corp.google.com> (raw)
In-Reply-To: <20180809171722.144325-1-swboyd@chromium.org>
Hi Stepehen,
On Thu, Aug 09, 2018 at 10:17:15AM -0700, Stephen Boyd wrote:
> This series reworks the coreboot firmware driver a bit to fix some bugs
> and then simplify the code by changing the design to get rid of the
> different platform drivers, remap memory with memremap(), and use devm
> to simplify error paths. There's some risk in changing to memremap() but
> I think that should work out alright. It will either return memory
> directly, or fallback to ioremap_cache() as has been done before.
>
> Changes from v2:
> * A bunch more patches
> * Fix iounmap missing on error path
> * Fix bus getting unregistered on driver unbind and never registered
> again
> * Request exclusive access to table region
> * Pull out table signature check to driver probe
>
> Changes from v1:
> * Split out fixlet for DT based driver from platform driver change
>
> Cc: Wei-Ning Huang <wnhuang@chromium.org>
> Cc: Julius Werner <jwerner@chromium.org>
> Cc: Brian Norris <briannorris@chromium.org>
> Cc: Samuel Holland <samuel@sholland.org>
>
> Stephen Boyd (7):
> firmware: coreboot: Let OF core populate platform device
> firmware: coreboot: Unmap ioregion on failure
> firmware: coreboot: Make bus registration symmetric
> firmware: coreboot: Collapse platform drivers into bus core
> firmware: coreboot: Remap RAM with memremap() instead of ioremap()
> firmware: coreboot: Only populate devices in coreboot_table_init()
> firmware: coreboot: Request table region for exclusive access
I gave patches 1 and 2 closer review (and individual replies); the
remaining patches look good to me too, so for the whole series:
Reviewed-by: Brian Norris <briannorris@chromium.org>
> drivers/firmware/google/Kconfig | 26 ++--
> drivers/firmware/google/Makefile | 2 -
> drivers/firmware/google/coreboot_table-acpi.c | 88 ------------
> drivers/firmware/google/coreboot_table-of.c | 82 -----------
> drivers/firmware/google/coreboot_table.c | 135 +++++++++++++-----
> drivers/firmware/google/coreboot_table.h | 6 -
> 6 files changed, 107 insertions(+), 232 deletions(-)
> delete mode 100644 drivers/firmware/google/coreboot_table-acpi.c
> delete mode 100644 drivers/firmware/google/coreboot_table-of.c
>
> --
> Sent by a computer through tubes
>
prev parent reply other threads:[~2018-08-09 18:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 17:17 [PATCH v3 0/7] firmware: coreboot: Fix probe and simplify code Stephen Boyd
2018-08-09 17:17 ` [PATCH v3 1/7] firmware: coreboot: Let OF core populate platform device Stephen Boyd
2018-08-09 17:31 ` Brian Norris
2018-08-09 17:17 ` [PATCH v3 2/7] firmware: coreboot: Unmap ioregion on failure Stephen Boyd
2018-08-09 17:49 ` Brian Norris
2018-08-09 19:40 ` Stephen Boyd
2018-08-09 19:52 ` Brian Norris
2018-08-09 23:25 ` Stephen Boyd
2018-08-09 17:17 ` [PATCH v3 3/7] firmware: coreboot: Make bus registration symmetric Stephen Boyd
2018-08-09 18:10 ` Julius Werner
2018-08-09 23:30 ` Stephen Boyd
2018-08-09 17:17 ` [PATCH v3 4/7] firmware: coreboot: Collapse platform drivers into bus core Stephen Boyd
2018-08-09 17:17 ` [PATCH v3 5/7] firmware: coreboot: Remap RAM with memremap() instead of ioremap() Stephen Boyd
2018-08-09 18:24 ` Julius Werner
2018-08-09 22:07 ` Stephen Boyd
2018-08-09 17:17 ` [PATCH v3 6/7] firmware: coreboot: Only populate devices in coreboot_table_init() Stephen Boyd
2018-08-09 21:02 ` Julius Werner
2018-08-09 23:43 ` Stephen Boyd
2018-08-09 17:17 ` [PATCH v3 7/7] firmware: coreboot: Request table region for exclusive access Stephen Boyd
2018-08-09 21:07 ` Julius Werner
2018-08-09 23:03 ` Stephen Boyd
2018-08-09 23:37 ` Julius Werner
2018-08-09 23:44 ` Julius Werner
2018-08-10 2:54 ` Stephen Boyd
2018-08-10 23:24 ` Stephen Boyd
2018-08-09 18:03 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180809180316.GD129285@ban.mtv.corp.google.com \
--to=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sholland.org \
--cc=swboyd@chromium.org \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).