* [net-next:master 1939/1953] drivers/net/ethernet/qlogic/qede/qede_main.c:539:5: sparse: symbol 'qede_setup_tc' was not declared. Should it be static?
@ 2018-08-10 1:29 kbuild test robot
2018-08-10 1:29 ` [RFC PATCH net-next] qed/qede: qede_setup_tc() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-08-10 1:29 UTC (permalink / raw)
To: Manish Chopra
Cc: kbuild-all, netdev, Ariel Elior, everest-linux-l2, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 36d2f761b5aa688567b6aebdc6d68e73682275d4
commit: 5e7baf0fcb2a3aef7329f3c7543d4695a46bd321 [1939/1953] qed/qede: Multi CoS support.
reproduce:
# apt-get install sparse
git checkout 5e7baf0fcb2a3aef7329f3c7543d4695a46bd321
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/qlogic/qede/qede_main.c:539:5: sparse: symbol 'qede_setup_tc' was not declared. Should it be static?
include/linux/slab.h:631:13: sparse: undefined identifier '__builtin_mul_overflow'
include/linux/slab.h:631:13: sparse: not a function <noident>
drivers/net/ethernet/qlogic/qede/qede_main.c:1175:19: sparse: expression using sizeof(void)
drivers/net/ethernet/qlogic/qede/qede_main.c:1175:19: sparse: expression using sizeof(void)
include/linux/slab.h:631:13: sparse: call with no type!
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH net-next] qed/qede: qede_setup_tc() can be static
2018-08-10 1:29 [net-next:master 1939/1953] drivers/net/ethernet/qlogic/qede/qede_main.c:539:5: sparse: symbol 'qede_setup_tc' was not declared. Should it be static? kbuild test robot
@ 2018-08-10 1:29 ` kbuild test robot
2018-08-10 21:42 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2018-08-10 1:29 UTC (permalink / raw)
To: Manish Chopra
Cc: kbuild-all, netdev, Ariel Elior, everest-linux-l2, linux-kernel
Fixes: 5e7baf0fcb2a ("qed/qede: Multi CoS support.")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
qede_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 4b5d98f..46d0f2e 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -536,7 +536,7 @@ static int qede_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
return 0;
}
-int qede_setup_tc(struct net_device *ndev, u8 num_tc)
+static int qede_setup_tc(struct net_device *ndev, u8 num_tc)
{
struct qede_dev *edev = netdev_priv(ndev);
int cos, count, offset;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH net-next] qed/qede: qede_setup_tc() can be static
2018-08-10 1:29 ` [RFC PATCH net-next] qed/qede: qede_setup_tc() can be static kbuild test robot
@ 2018-08-10 21:42 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-08-10 21:42 UTC (permalink / raw)
To: fengguang.wu
Cc: manish.chopra, kbuild-all, netdev, ariel.elior, everest-linux-l2,
linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 10 Aug 2018 09:29:59 +0800
> Fixes: 5e7baf0fcb2a ("qed/qede: Multi CoS support.")
> Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-10 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 1:29 [net-next:master 1939/1953] drivers/net/ethernet/qlogic/qede/qede_main.c:539:5: sparse: symbol 'qede_setup_tc' was not declared. Should it be static? kbuild test robot
2018-08-10 1:29 ` [RFC PATCH net-next] qed/qede: qede_setup_tc() can be static kbuild test robot
2018-08-10 21:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).