Re: [PATCH] staging: gasket: remove null ptr check before kfree

Re: [PATCH] staging: gasket: remove null ptr check before kfree

[Greg Kroah-Hartman]

On Sun, Aug 12, 2018 at 03:11:22AM +0530, Sumit Kumar wrote:
> Adding a mailing list in cc as per recommendation from greg's patch bot.
> + linux-kernel@vger.kernel.org
> 
> $ scripts/get_maintainer.pl -f
> /tmp/0001-staging-gasket-remove-null-ptr-check-before-kfree.patch
> fatal: /tmp/0001-staging-gasket-remove-null-ptr-check-before-kfree.patch:
> '/tmp/0001-staging-gasket-remove-null-ptr-check-before-kfree.patch' is
> outside repository
> linux-kernel@vger.kernel.org (open list)

Do not use -f to point to a patch.  Try it again and see what happens...

Re: [PATCH] staging: gasket: remove null ptr check before kfree

[Himanshu Jha]

On Sun, Aug 12, 2018 at 12:28:37PM +0530, Sumit Kumar wrote:
> Remove null ptr check before kfree because kfree is null ptr safe.
> Issue found by checkpatch.
> 
> Signed-off-by: Sumit Kumar <sumit686215@example.com>

Hmm. Victim of copy-paste I guess.
No worries. Next time just use:

$  git commit -s

To understand what -s flag does, refer `man git commit`.

> ---

Now, this where you should have put versions just below the '---':

v2:
   - corrected email address.

And yes, the subject should be:

"Subject: [PATCH v2] staging: gasket: remove null ptr check before kfree"

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

Hope that helps!

-- 
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology

[PATCH] staging: gasket: remove null ptr check before kfree

[Sumit Kumar]

Remove null ptr check before kfree because kfree is null ptr safe.
Issue found by checkpatch.

Signed-off-by: Sumit Kumar <sumit686215@gmail.com>
---
 drivers/staging/gasket/gasket_page_table.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index d4c5f8a..bd921dc 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -1328,10 +1328,8 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
 				  num_pages * PAGE_SIZE, mem, handle);
 	}
 
-	if (gasket_dev->page_table[index]->coherent_pages) {
-		kfree(gasket_dev->page_table[index]->coherent_pages);
-		gasket_dev->page_table[index]->coherent_pages = NULL;
-	}
+	kfree(gasket_dev->page_table[index]->coherent_pages);
+	gasket_dev->page_table[index]->coherent_pages = NULL;
 	gasket_dev->page_table[index]->num_coherent_pages = 0;
 	return -ENOMEM;
 }
-- 
2.7.4

[PATCH] staging: gasket: remove null ptr check before kfree

[Sumit Kumar]

Remove null ptr check before kfree because kfree is null ptr safe.
Issue found by checkpatch.

Signed-off-by: Sumit Kumar <sumit686215@example.com>
---
 drivers/staging/gasket/gasket_page_table.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index d4c5f8a..bd921dc 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -1328,10 +1328,8 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
 				  num_pages * PAGE_SIZE, mem, handle);
 	}
 
-	if (gasket_dev->page_table[index]->coherent_pages) {
-		kfree(gasket_dev->page_table[index]->coherent_pages);
-		gasket_dev->page_table[index]->coherent_pages = NULL;
-	}
+	kfree(gasket_dev->page_table[index]->coherent_pages);
+	gasket_dev->page_table[index]->coherent_pages = NULL;
 	gasket_dev->page_table[index]->num_coherent_pages = 0;
 	return -ENOMEM;
 }
-- 
2.7.4

Re: [PATCH] staging: gasket: remove null ptr check before kfree

[Greg Kroah-Hartman]

On Sun, Aug 12, 2018 at 03:17:53AM +0530, Sumit Kumar wrote:
> Remove null ptr check before kfree because kfree is null ptr safe.
> Issue found by checkpatch.
> 
> Signed-off-by: Sumit Kumar <sumit686215@example.com>

Do not use fake email addresses in a signed-off-by line :(

[PATCH] staging: gasket: remove null ptr check before kfree

[Sumit Kumar]

Remove null ptr check before kfree because kfree is null ptr safe.
Issue found by checkpatch.

Signed-off-by: Sumit Kumar <sumit686215@example.com>
---
 drivers/staging/gasket/gasket_page_table.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/gasket/gasket_page_table.c b/drivers/staging/gasket/gasket_page_table.c
index d4c5f8a..bd921dc 100644
--- a/drivers/staging/gasket/gasket_page_table.c
+++ b/drivers/staging/gasket/gasket_page_table.c
@@ -1328,10 +1328,8 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
 				  num_pages * PAGE_SIZE, mem, handle);
 	}
 
-	if (gasket_dev->page_table[index]->coherent_pages) {
-		kfree(gasket_dev->page_table[index]->coherent_pages);
-		gasket_dev->page_table[index]->coherent_pages = NULL;
-	}
+	kfree(gasket_dev->page_table[index]->coherent_pages);
+	gasket_dev->page_table[index]->coherent_pages = NULL;
 	gasket_dev->page_table[index]->num_coherent_pages = 0;
 	return -ENOMEM;
 }
-- 
2.7.4