From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] net: lan743x: fix building without CONFIG_PTP_1588_CLOCK
Date: Mon, 13 Aug 2018 20:44:20 -0700 (PDT) [thread overview]
Message-ID: <20180813.204420.1246202084626536095.davem@davemloft.net> (raw)
In-Reply-To: <20180813211938.2375199-2-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 13 Aug 2018 23:19:22 +0200
> Building without CONFIG_PTP_1588_CLOCK results in multiple failures,
> this was obviously not well tested:
...
> Those #ifdef checks are hard to get right, replace them all with
> IS_ENABLED() checks that leave the same code visible to the compiler
> but let it optimize out the unused bits based on the configuration.
>
> Fixes: 07624df1c9ef ("lan743x: lan743x: Add PTP support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
next prev parent reply other threads:[~2018-08-14 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 21:19 [PATCH 1/2] net: lan743x: select CRC16 Arnd Bergmann
2018-08-13 21:19 ` [PATCH 2/2] net: lan743x: fix building without CONFIG_PTP_1588_CLOCK Arnd Bergmann
2018-08-14 3:44 ` David Miller [this message]
2018-08-14 3:44 ` [PATCH 1/2] net: lan743x: select CRC16 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813.204420.1246202084626536095.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=arnd@arndb.de \
--cc=bryan.whitehead@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).