[PATCH 0/5] Add CDTech 4.3" and 7" to panel-simple

[PATCH 0/5] Add CDTech 4.3" and 7" to panel-simple

[Giulio Benetti]

Add CDTech 4.3" S043WQ26H-CT7 support
Add CDTech 7" S070WV95-CT16 support

Giulio Benetti (5):
  dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited
  drm/panel: add panel CDTech S070WV95-CT16 to panel-simple
  dt-bindings: Add CDTech S070WV95-CT16 panel bindings
  drm/panel: add panel CDTech S043WQ26H-CT7 to panel-simple
  dt-bindings: Add CDTech S043WQ26H-CT7 panel bindings

 .../display/panel/cdtech,s043wq26h-ct7.txt    | 12 ++++
 .../display/panel/cdtech,s070wv95-ct16.txt    | 12 ++++
 .../devicetree/bindings/vendor-prefixes.txt   |  1 +
 drivers/gpu/drm/panel/panel-simple.c          | 55 +++++++++++++++++++
 4 files changed, 80 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt

-- 
2.17.1

[PATCH 1/5] dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited

[Giulio Benetti]

This adds a vendor prefix "cdtech" for CDTech(H.K.) Electronics Limited

Website: www.cdtech-lcd.com

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 760d1c11458c..29894c628e00 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -64,6 +64,7 @@ capella	Capella Microsystems, Inc
 cascoda	Cascoda, Ltd.
 cavium	Cavium, Inc.
 cdns	Cadence Design Systems Inc.
+cdtech	CDTech(H.K.) Electronics Limited
 ceva	Ceva, Inc.
 chipidea	Chipidea, Inc
 chipone		ChipOne
-- 
2.17.1

[PATCH 2/5] drm/panel: add panel CDTech S070WV95-CT16 to panel-simple

[Giulio Benetti]

This patch adds support for CDTech S070WV95-CT16 800x480 7" panel to DRM
simple panel driver.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index cbf1ab404ee7..caa5a01eb8e3 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -787,6 +787,30 @@ static const struct panel_desc boe_nv101wxmn51 = {
 	},
 };
 
+static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
+	.clock = 35000,
+	.hdisplay = 800,
+	.hsync_start = 800 + 40,
+	.hsync_end = 800 + 40 + 40,
+	.htotal = 800 + 40 + 40 + 48,
+	.vdisplay = 480,
+	.vsync_start = 480 + 29,
+	.vsync_end = 480 + 29 + 13,
+	.vtotal = 480 + 29 + 13 + 3,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cdtech_s070wv95_ct16 = {
+	.modes = &cdtech_s070wv95_ct16_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 154,
+		.height = 85,
+	},
+};
+
 static const struct drm_display_mode chunghwa_claa070wp03xg_mode = {
 	.clock = 66770,
 	.hdisplay = 800,
@@ -2115,6 +2139,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "boe,nv101wxmn51",
 		.data = &boe_nv101wxmn51,
+	}, {
+		.compatible = "cdtech,s070wv95-ct16",
+		.data = &cdtech_s070wv95_ct16,
 	}, {
 		.compatible = "chunghwa,claa070wp03xg",
 		.data = &chunghwa_claa070wp03xg,
-- 
2.17.1

[PATCH 3/5] dt-bindings: Add CDTech S070WV95-CT16 panel bindings

[Giulio Benetti]

Add documentation for S070WV95-CT16 panel

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 .../bindings/display/panel/cdtech,s070wv95-ct16.txt  | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt

diff --git a/Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt b/Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt
new file mode 100644
index 000000000000..505615dfa0df
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt
@@ -0,0 +1,12 @@
+CDTech(H.K.) Electronics Limited 7" 800x480 color TFT-LCD panel
+
+Required properties:
+- compatible: should be "cdtech,s070wv95-ct16"
+- power-supply: as specified in the base binding
+
+Optional properties:
+- backlight: as specified in the base binding
+- enable-gpios: as specified in the base binding
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
2.17.1

[PATCH 4/5] drm/panel: add panel CDTech S043WQ26H-CT7 to panel-simple

[Giulio Benetti]

This patch adds support for CDTech S043WQ26H-CT7 480x272 4.3" panel to
DRM simple panel driver.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index caa5a01eb8e3..3a6a66c2307d 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -787,6 +787,31 @@ static const struct panel_desc boe_nv101wxmn51 = {
 	},
 };
 
+static const struct drm_display_mode cdtech_s043wq26h_ct7_mode = {
+	.clock = 9000,
+	.hdisplay = 480,
+	.hsync_start = 480 + 5,
+	.hsync_end = 480 + 5 + 5,
+	.htotal = 480 + 5 + 5 + 40,
+	.vdisplay = 272,
+	.vsync_start = 272 + 8,
+	.vsync_end = 272 + 8 + 8,
+	.vtotal = 272 + 8 + 8 + 8,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc cdtech_s043wq26h_ct7 = {
+	.modes = &cdtech_s043wq26h_ct7_mode,
+	.num_modes = 1,
+	.bpc = 8,
+	.size = {
+		.width = 95,
+		.height = 54,
+	},
+	.bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE,
+};
+
 static const struct drm_display_mode cdtech_s070wv95_ct16_mode = {
 	.clock = 35000,
 	.hdisplay = 800,
@@ -2139,6 +2164,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "boe,nv101wxmn51",
 		.data = &boe_nv101wxmn51,
+	}, {
+		.compatible = "cdtech,s043wq26h-ct7",
+		.data = &cdtech_s043wq26h_ct7,
 	}, {
 		.compatible = "cdtech,s070wv95-ct16",
 		.data = &cdtech_s070wv95_ct16,
-- 
2.17.1

[PATCH 5/5] dt-bindings: Add CDTech S043WQ26H-CT7 panel bindings

[Giulio Benetti]

Add documentation for S043WQ26H-CT7 panel

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 .../bindings/display/panel/cdtech,s043wq26h-ct7.txt  | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt

diff --git a/Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt b/Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt
new file mode 100644
index 000000000000..057f7f3f6dbe
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt
@@ -0,0 +1,12 @@
+CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel
+
+Required properties:
+- compatible: should be "cdtech,s043wq26h-ct7"
+- power-supply: as specified in the base binding
+
+Optional properties:
+- backlight: as specified in the base binding
+- enable-gpios: as specified in the base binding
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
2.17.1

Re: [PATCH 1/5] dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited

[Rob Herring]

On Tue, Jul 31, 2018 at 01:11:13AM +0200, Giulio Benetti wrote:
> This adds a vendor prefix "cdtech" for CDTech(H.K.) Electronics Limited
> 
> Website: www.cdtech-lcd.com
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 3/5] dt-bindings: Add CDTech S070WV95-CT16 panel bindings

[Rob Herring]

On Tue, Jul 31, 2018 at 01:11:15AM +0200, Giulio Benetti wrote:
> Add documentation for S070WV95-CT16 panel
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  .../bindings/display/panel/cdtech,s070wv95-ct16.txt  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 5/5] dt-bindings: Add CDTech S043WQ26H-CT7 panel bindings

[Rob Herring]

On Tue, Jul 31, 2018 at 01:11:17AM +0200, Giulio Benetti wrote:
> Add documentation for S043WQ26H-CT7 panel
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  .../bindings/display/panel/cdtech,s043wq26h-ct7.txt  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 0/5] Add CDTech 4.3" and 7" to panel-simple

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

On Tue, Jul 31, 2018 at 01:11:12AM +0200, Giulio Benetti wrote:
> Add CDTech 4.3" S043WQ26H-CT7 support
> Add CDTech 7" S070WV95-CT16 support
> 
> Giulio Benetti (5):
>   dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited
>   drm/panel: add panel CDTech S070WV95-CT16 to panel-simple
>   dt-bindings: Add CDTech S070WV95-CT16 panel bindings
>   drm/panel: add panel CDTech S043WQ26H-CT7 to panel-simple
>   dt-bindings: Add CDTech S043WQ26H-CT7 panel bindings
> 
>  .../display/panel/cdtech,s043wq26h-ct7.txt    | 12 ++++
>  .../display/panel/cdtech,s070wv95-ct16.txt    | 12 ++++
>  .../devicetree/bindings/vendor-prefixes.txt   |  1 +
>  drivers/gpu/drm/panel/panel-simple.c          | 55 +++++++++++++++++++
>  4 files changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt

All applied, thanks. One small note, though: in the future please send
DT bindings patches before the driver patches. This is important because
checkpatch, which is run as pre-commit script, warns about undocumented
compatible strings if you send driver changes before the bindings.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 0/5] Add CDTech 4.3" and 7" to panel-simple

[Giulio Benetti]

Hello Thierry,

Il 27/09/2018 13:59, Thierry Reding ha scritto:
> On Tue, Jul 31, 2018 at 01:11:12AM +0200, Giulio Benetti wrote:
>> Add CDTech 4.3" S043WQ26H-CT7 support
>> Add CDTech 7" S070WV95-CT16 support
>>
>> Giulio Benetti (5):
>>    dt-bindings: Add vendor prefix for CDTech(H.K.) Electronics Limited
>>    drm/panel: add panel CDTech S070WV95-CT16 to panel-simple
>>    dt-bindings: Add CDTech S070WV95-CT16 panel bindings
>>    drm/panel: add panel CDTech S043WQ26H-CT7 to panel-simple
>>    dt-bindings: Add CDTech S043WQ26H-CT7 panel bindings
>>
>>   .../display/panel/cdtech,s043wq26h-ct7.txt    | 12 ++++
>>   .../display/panel/cdtech,s070wv95-ct16.txt    | 12 ++++
>>   .../devicetree/bindings/vendor-prefixes.txt   |  1 +
>>   drivers/gpu/drm/panel/panel-simple.c          | 55 +++++++++++++++++++
>>   4 files changed, 80 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s043wq26h-ct7.txt
>>   create mode 100644 Documentation/devicetree/bindings/display/panel/cdtech,s070wv95-ct16.txt
> 
> All applied, thanks. One small note, though: in the future please send
> DT bindings patches before the driver patches. This is important because
> checkpatch, which is run as pre-commit script, warns about undocumented
> compatible strings if you send driver changes before the bindings.

Ok, thanks for both applying and pointing me this important detail.

-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642