* [PATCH v2] ASoC: wm9712: fix replace codec to component
@ 2018-08-13 22:35 Marcel Ziswiler
2018-08-14 8:12 ` Charles Keepax
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Marcel Ziswiler @ 2018-08-13 22:35 UTC (permalink / raw)
To: alsa-devel, linux-tegra, Kuninori Morimoto, Mark Brown
Cc: Marcel Ziswiler, Jaroslav Kysela, Fabio Estevam, Robert Jarzmik,
patches, linux-kernel, Takashi Iwai, Liam Girdwood,
Charles Keepax
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
"wm9712-codec" got renamed to "wm9712-component", however, this change
never got propagated down to the actual board/platform drivers. E.g. on
Colibri T20 this lead to the following spew upon boot with sound/touch
being broken:
[ 2.214121] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 2.222137] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 2.344384] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 2.351885] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 2.668339] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 2.675811] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 3.208408] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 3.216312] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 3.235397] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 3.248938] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 14.970443] ALSA device list:
[ 14.996628] No soundcards found.
This commit finally fixes this again.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
Changes in v2:
- Simply rename "wm9712-component" back to "wm9712-codec" as suggested
by Kuninori and Charles.
sound/soc/codecs/wm9712.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
index 953d94d50586..ade34c26ad2f 100644
--- a/sound/soc/codecs/wm9712.c
+++ b/sound/soc/codecs/wm9712.c
@@ -719,7 +719,7 @@ static int wm9712_probe(struct platform_device *pdev)
static struct platform_driver wm9712_component_driver = {
.driver = {
- .name = "wm9712-component",
+ .name = "wm9712-codec",
},
.probe = wm9712_probe,
--
2.14.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ASoC: wm9712: fix replace codec to component
2018-08-13 22:35 [PATCH v2] ASoC: wm9712: fix replace codec to component Marcel Ziswiler
@ 2018-08-14 8:12 ` Charles Keepax
2018-08-14 14:25 ` Applied "ASoC: wm9712: fix replace codec to component" to the asoc tree Mark Brown
2018-08-20 1:16 ` [PATCH v2] ASoC: wm9712: fix replace codec to component Kuninori Morimoto
2 siblings, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2018-08-14 8:12 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: alsa-devel, linux-tegra, Kuninori Morimoto, Mark Brown,
Marcel Ziswiler, Jaroslav Kysela, Fabio Estevam, Robert Jarzmik,
patches, linux-kernel, Takashi Iwai, Liam Girdwood
On Tue, Aug 14, 2018 at 12:35:56AM +0200, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> "wm9712-codec" got renamed to "wm9712-component", however, this change
> never got propagated down to the actual board/platform drivers. E.g. on
> Colibri T20 this lead to the following spew upon boot with sound/touch
> being broken:
>
> [ 2.214121] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 2.222137] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 2.344384] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 2.351885] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 2.668339] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 2.675811] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 3.208408] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 3.216312] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 3.235397] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 3.248938] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 14.970443] ALSA device list:
> [ 14.996628] No soundcards found.
>
> This commit finally fixes this again.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread* Applied "ASoC: wm9712: fix replace codec to component" to the asoc tree
2018-08-13 22:35 [PATCH v2] ASoC: wm9712: fix replace codec to component Marcel Ziswiler
2018-08-14 8:12 ` Charles Keepax
@ 2018-08-14 14:25 ` Mark Brown
2018-08-20 1:16 ` [PATCH v2] ASoC: wm9712: fix replace codec to component Kuninori Morimoto
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2018-08-14 14:25 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: Charles Keepax, Mark Brown, stable, alsa-devel, linux-tegra,
Kuninori Morimoto, Mark Brown, Charles Keepax, Liam Girdwood,
patches, Takashi Iwai, linux-kernel, Fabio Estevam,
Robert Jarzmik, alsa-devel
The patch
ASoC: wm9712: fix replace codec to component
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 5e4cfadaf5b73a0801b2fa7fb007f98400ebfe6e Mon Sep 17 00:00:00 2001
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Date: Tue, 14 Aug 2018 00:35:56 +0200
Subject: [PATCH] ASoC: wm9712: fix replace codec to component
Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
"wm9712-codec" got renamed to "wm9712-component", however, this change
never got propagated down to the actual board/platform drivers. E.g. on
Colibri T20 this lead to the following spew upon boot with sound/touch
being broken:
[ 2.214121] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 2.222137] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 2.344384] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 2.351885] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 2.668339] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 2.675811] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 3.208408] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 3.216312] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 3.235397] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
[ 3.248938] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
...
[ 14.970443] ALSA device list:
[ 14.996628] No soundcards found.
This commit finally fixes this again.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
---
sound/soc/codecs/wm9712.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
index 953d94d50586..ade34c26ad2f 100644
--- a/sound/soc/codecs/wm9712.c
+++ b/sound/soc/codecs/wm9712.c
@@ -719,7 +719,7 @@ static int wm9712_probe(struct platform_device *pdev)
static struct platform_driver wm9712_component_driver = {
.driver = {
- .name = "wm9712-component",
+ .name = "wm9712-codec",
},
.probe = wm9712_probe,
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ASoC: wm9712: fix replace codec to component
2018-08-13 22:35 [PATCH v2] ASoC: wm9712: fix replace codec to component Marcel Ziswiler
2018-08-14 8:12 ` Charles Keepax
2018-08-14 14:25 ` Applied "ASoC: wm9712: fix replace codec to component" to the asoc tree Mark Brown
@ 2018-08-20 1:16 ` Kuninori Morimoto
2 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2018-08-20 1:16 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: alsa-devel, linux-tegra, Mark Brown, Marcel Ziswiler,
Jaroslav Kysela, Fabio Estevam, Robert Jarzmik, patches,
linux-kernel, Takashi Iwai, Liam Girdwood, Charles Keepax
Hi
# I know it is very late response
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> Since commit 143b44845d87 ("ASoC: wm9712: replace codec to component")
> "wm9712-codec" got renamed to "wm9712-component", however, this change
> never got propagated down to the actual board/platform drivers. E.g. on
> Colibri T20 this lead to the following spew upon boot with sound/touch
> being broken:
>
> [ 2.214121] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 2.222137] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 2.344384] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 2.351885] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 2.668339] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 2.675811] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 3.208408] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 3.216312] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 3.235397] tegra-snd-wm9712 sound: ASoC: CODEC DAI wm9712-hifi not registered
> [ 3.248938] tegra-snd-wm9712 sound: snd_soc_register_card failed (-517)
> ...
> [ 14.970443] ALSA device list:
> [ 14.996628] No soundcards found.
>
> This commit finally fixes this again.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-20 1:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-13 22:35 [PATCH v2] ASoC: wm9712: fix replace codec to component Marcel Ziswiler
2018-08-14 8:12 ` Charles Keepax
2018-08-14 14:25 ` Applied "ASoC: wm9712: fix replace codec to component" to the asoc tree Mark Brown
2018-08-20 1:16 ` [PATCH v2] ASoC: wm9712: fix replace codec to component Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).