* [Regression] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
@ 2018-08-10 16:13 Joseph Salisbury
2018-08-14 11:02 ` Daniel Thompson
0 siblings, 1 reply; 2+ messages in thread
From: Joseph Salisbury @ 2018-08-10 16:13 UTC (permalink / raw)
To: daniel.thompson
Cc: ard.biesheuvel, mathias.nyman, gregkh, stable, linux-kernel
Hi Daniel,
A kernel bug report was opened against Ubuntu [0]. It was found the
following patch introduced the regression:
da9970668948 ("usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201")
The bug reporter claims there is a typo in the patch that caused the
regression. I built a test kernel with a change to the suspected typo
and the bug reporter claims it resolved the regression. My test kernel
had the following change:
- pdev->device == 0x0014)
+ pdev->device == 0x0015)
I was hoping to get your feedback, since you are the patch author. Do
you think this is an actual typo, or maybe there really needs to be two
quirks?
Thanks,
Joe
[0] http://pad.lv/1773704
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Regression] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201
2018-08-10 16:13 [Regression] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201 Joseph Salisbury
@ 2018-08-14 11:02 ` Daniel Thompson
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Thompson @ 2018-08-14 11:02 UTC (permalink / raw)
To: Joseph Salisbury
Cc: ard.biesheuvel, mathias.nyman, gregkh, stable, linux-kernel
On Fri, Aug 10, 2018 at 12:13:53PM -0400, Joseph Salisbury wrote:
> Hi Daniel,
>
> A kernel bug report was opened against Ubuntu [0]. It was found the
> following patch introduced the regression:
>
> da9970668948 ("usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201")
I can see nothing in http://pad.lv/1773704 that indicates a regression
in this patch. How could there be? The patch does not not alter the
behaviour of uPD720202 devices (pdev->device == 0x0015).
> The bug reporter claims there is a typo in the patch that caused the
> regression. I built a test kernel with a change to the suspected typo
> and the bug reporter claims it resolved the regression. My test kernel
> had the following change:
>
> - pdev->device == 0x0014)
> + pdev->device == 0x0015)
>
> I was hoping to get your feedback, since you are the patch author. Do
> you think this is an actual typo, or maybe there really needs to be two
> quirks?
No, it is a not a typo (and the change above *does* introduce a regression
;-) ). From this git logs I believe that:
0x0014 -> uPD720201
0x0015 -> uPD720202
Daniel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-14 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 16:13 [Regression] usb: xhci: Add XHCI_TRUST_TX_LENGTH for Renesas uPD720201 Joseph Salisbury
2018-08-14 11:02 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).