From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] Kbuild: refactor fixdep to use getopt()
Date: Wed, 15 Aug 2018 16:27:47 +0200 [thread overview]
Message-ID: <20180815142749.18804-2-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <20180815142749.18804-1-linux@rasmusvillemoes.dk>
As preparation for teaching an old dog a few new tricks.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
scripts/basic/fixdep.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index 850966f3d602..666041841200 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -381,16 +381,23 @@ int main(int argc, char *argv[])
const char *depfile, *target, *cmdline;
int insert_extra_deps = 0;
void *buf;
+ int opt;
- if (argc == 5 && !strcmp(argv[1], "-e")) {
- insert_extra_deps = 1;
- argv++;
- } else if (argc != 4)
+ while ((opt = getopt(argc, argv, "e")) != -1) {
+ switch (opt) {
+ case 'e': insert_extra_deps = 1; break;
+ default: usage();
+ }
+ }
+ argc -= optind;
+ argv += optind;
+
+ if (argc != 3)
usage();
- depfile = argv[1];
- target = argv[2];
- cmdline = argv[3];
+ depfile = argv[0];
+ target = argv[1];
+ cmdline = argv[2];
printf("cmd_%s := %s\n\n", target, cmdline);
--
2.16.4
next prev parent reply other threads:[~2018-08-15 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 14:27 [PATCH 0/3] Kbuild: Some fixdep tweaks Rasmus Villemoes
2018-08-15 14:27 ` Rasmus Villemoes [this message]
2018-08-15 14:27 ` [PATCH 2/3] Kbuild: teach fixdep to optionally remove the depfile Rasmus Villemoes
2018-08-15 14:27 ` [PATCH 3/3] Kbuild: let fixdep do the renaming to .cmd Rasmus Villemoes
2018-09-26 18:58 ` [PATCH 0/3] Kbuild: Some fixdep tweaks Rasmus Villemoes
2018-09-28 2:21 ` Masahiro Yamada
2018-10-01 12:19 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815142749.18804-2-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).