From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Michal Marek <michal.lkml@markovi.net>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] Kbuild: Some fixdep tweaks
Date: Fri, 28 Sep 2018 11:21:41 +0900 [thread overview]
Message-ID: <CAK7LNATmw1Tic2mDybRd-5CbZK_6J1+=3j31q8K9hONVoRHrdA@mail.gmail.com> (raw)
In-Reply-To: <CAKwiHFj5yGtsR+s0Ukjy0Pe1pDpd_euyT0MRZdTt0H3ssXqYXQ@mail.gmail.com>
Hi Rasmus,
2018年9月27日(木) 3:58 Rasmus Villemoes <linux@rasmusvillemoes.dk>:
>
> On 15 August 2018 at 16:27, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> > These patches eliminate two (albeit tiny and shortlived) processes
> > from the cmd_and_fixdep rule, i.e. from every TU being
> > compiled. Whether the diffstat below is worth it I'll leave to Kbuild
> > maintainers to decide.
>
> Ping.
Sorry for delay.
As far as I tested, the performance improvement was not noticeable level.
This patch set actually sits on the fence.
I tend to choose not-apply when I cannot make up my mind.
If you have something more to convince me, please let me know.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2018-09-28 2:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 14:27 [PATCH 0/3] Kbuild: Some fixdep tweaks Rasmus Villemoes
2018-08-15 14:27 ` [PATCH 1/3] Kbuild: refactor fixdep to use getopt() Rasmus Villemoes
2018-08-15 14:27 ` [PATCH 2/3] Kbuild: teach fixdep to optionally remove the depfile Rasmus Villemoes
2018-08-15 14:27 ` [PATCH 3/3] Kbuild: let fixdep do the renaming to .cmd Rasmus Villemoes
2018-09-26 18:58 ` [PATCH 0/3] Kbuild: Some fixdep tweaks Rasmus Villemoes
2018-09-28 2:21 ` Masahiro Yamada [this message]
2018-10-01 12:19 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNATmw1Tic2mDybRd-5CbZK_6J1+=3j31q8K9hONVoRHrdA@mail.gmail.com' \
--to=yamada.masahiro@socionext.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).