From: Oscar Salvador <osalvador@techadventures.net>
To: akpm@linux-foundation.org
Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com,
yasu.isimatu@gmail.com, jonathan.cameron@huawei.com,
david@redhat.com, Pavel.Tatashin@microsoft.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v3 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes
Date: Wed, 15 Aug 2018 16:42:15 +0200 [thread overview]
Message-ID: <20180815144219.6014-1-osalvador@techadventures.net> (raw)
From: Oscar Salvador <osalvador@suse.de>
v2 -> v3:
- NODEMASK_FREE can deal with NULL pointers, so do not
make it conditional (by David).
- Split up node_online's check patch (David's suggestion)
- Added Reviewed-by from Andrew and David
- Fix checkpath.pl warnings
This patchset does some cleanups and refactoring in the memory-hotplug code.
The first and the second patch are pretty straightforward, as they
only remove unused arguments/checks.
The third one refactors unregister_mem_sect_under_nodes.
This is needed to have a proper fallback in case we could not allocate
memory. (details can be seen in patch3).
The fourth patch removes a node_online check.
We are getting the nid from pages that are yet not removed, but a node
can only be offline when its memory/cpu's have been removed.
Therefore, we do not really need to check for the node to be online here.
Since this change has a patch for itself, we could quickly revert it
if we notice that something is wrong with it, or drop it if people
are concerned about it.
Oscar Salvador (4):
mm/memory-hotplug: Drop unused args from remove_memory_section
mm/memory_hotplug: Drop mem_blk check from
unregister_mem_sect_under_nodes
mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes
mm/memory_hotplug: Drop node_online check in
unregister_mem_sect_under_nodes
drivers/base/memory.c | 5 ++---
drivers/base/node.c | 29 +++++++++++++++--------------
include/linux/node.h | 5 ++---
3 files changed, 19 insertions(+), 20 deletions(-)
--
2.13.6
next reply other threads:[~2018-08-15 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 14:42 Oscar Salvador [this message]
2018-08-15 14:42 ` [PATCH v3 1/4] mm/memory-hotplug: Drop unused args from remove_memory_section Oscar Salvador
2018-08-16 17:45 ` Pasha Tatashin
2018-08-15 14:42 ` [PATCH v3 2/4] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes Oscar Salvador
2018-08-16 17:53 ` Pasha Tatashin
2018-08-16 18:43 ` David Hildenbrand
2018-08-15 14:42 ` [PATCH v3 3/4] mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes Oscar Salvador
2018-08-15 22:01 ` Andrew Morton
2018-08-16 7:48 ` Oscar Salvador
2018-08-16 18:22 ` Pasha Tatashin
2018-08-15 14:42 ` [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes Oscar Salvador
2018-08-16 18:43 ` David Hildenbrand
2018-08-16 18:59 ` Pasha Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815144219.6014-1-osalvador@techadventures.net \
--to=osalvador@techadventures.net \
--cc=Pavel.Tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).