From: Pasha Tatashin <Pavel.Tatashin@microsoft.com>
To: Oscar Salvador <osalvador@techadventures.net>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mhocko@suse.com" <mhocko@suse.com>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"yasu.isimatu@gmail.com" <yasu.isimatu@gmail.com>,
"jonathan.cameron@huawei.com" <jonathan.cameron@huawei.com>,
"david@redhat.com" <david@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes
Date: Thu, 16 Aug 2018 18:59:31 +0000 [thread overview]
Message-ID: <20180816185930.tfg2rzjnh34lmuxa@xakep.localdomain> (raw)
In-Reply-To: <20180815144219.6014-5-osalvador@techadventures.net>
On 18-08-15 16:42:19, Oscar Salvador wrote:
> From: Oscar Salvador <osalvador@suse.de>
>
> We are getting the nid from the pages that are not yet removed,
> but a node can only be offline when its memory/cpu's have been removed.
> Therefore, we know that the node is still online.
Reviewed-by: Pavel Tatashin <pavel.tatashin@microsoft.com>
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
> drivers/base/node.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/node.c b/drivers/base/node.c
> index 81b27b5b1f15..b23769e4fcbb 100644
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -465,8 +465,6 @@ void unregister_mem_sect_under_nodes(struct memory_block *mem_blk,
>
> if (nid < 0)
> continue;
> - if (!node_online(nid))
> - continue;
> /*
> * It is possible that NODEMASK_ALLOC fails due to memory
> * pressure.
> --
> 2.13.6
>
prev parent reply other threads:[~2018-08-16 18:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 14:42 [PATCH v3 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes Oscar Salvador
2018-08-15 14:42 ` [PATCH v3 1/4] mm/memory-hotplug: Drop unused args from remove_memory_section Oscar Salvador
2018-08-16 17:45 ` Pasha Tatashin
2018-08-15 14:42 ` [PATCH v3 2/4] mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes Oscar Salvador
2018-08-16 17:53 ` Pasha Tatashin
2018-08-16 18:43 ` David Hildenbrand
2018-08-15 14:42 ` [PATCH v3 3/4] mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes Oscar Salvador
2018-08-15 22:01 ` Andrew Morton
2018-08-16 7:48 ` Oscar Salvador
2018-08-16 18:22 ` Pasha Tatashin
2018-08-15 14:42 ` [PATCH v3 4/4] mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes Oscar Salvador
2018-08-16 18:43 ` David Hildenbrand
2018-08-16 18:59 ` Pasha Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816185930.tfg2rzjnh34lmuxa@xakep.localdomain \
--to=pavel.tatashin@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).