* [PATCH v3 0/3] Cleanup drm_kms_helper_poll_enable/disable() calls
@ 2018-08-15 19:15 Lyude Paul
2018-08-15 19:15 ` [PATCH v3 1/3] drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state() Lyude Paul
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lyude Paul @ 2018-08-15 19:15 UTC (permalink / raw)
To: nouveau; +Cc: David Airlie, linux-kernel, dri-devel, Ben Skeggs
Next version of https://patchwork.freedesktop.org/series/48131/
Only changes are new A-Bs and R-Bs
Lyude Paul (3):
drm/nouveau: Remove useless poll_enable() call in
switcheroo_set_state()
drm/nouveau: Remove useless poll_disable() call in
switcheroo_set_state()
drm/nouveau: Remove useless poll_enable() call in drm_load()
drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +---
drivers/gpu/drm/nouveau/nouveau_vga.c | 2 --
2 files changed, 1 insertion(+), 5 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/3] drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state()
2018-08-15 19:15 [PATCH v3 0/3] Cleanup drm_kms_helper_poll_enable/disable() calls Lyude Paul
@ 2018-08-15 19:15 ` Lyude Paul
2018-08-15 19:15 ` [PATCH v3 2/3] drm/nouveau: Remove useless poll_disable() " Lyude Paul
2018-08-15 19:15 ` [PATCH v3 3/3] drm/nouveau: Remove useless poll_enable() call in drm_load() Lyude Paul
2 siblings, 0 replies; 4+ messages in thread
From: Lyude Paul @ 2018-08-15 19:15 UTC (permalink / raw)
To: nouveau; +Cc: Lukas Wunner, Ben Skeggs, David Airlie, dri-devel, linux-kernel
This doesn't do anything, drm_kms_helper_poll_enable() gets called in
nouveau_pmops_resume()->nouveau_display_resume()->nouveau_display_init()
already.
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
Cc: Lukas Wunner <lukas@wunner.de>
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c
index 3da5a4305aa4..09b1d8151881 100644
--- a/drivers/gpu/drm/nouveau/nouveau_vga.c
+++ b/drivers/gpu/drm/nouveau/nouveau_vga.c
@@ -46,7 +46,6 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev,
pr_err("VGA switcheroo: switched nouveau on\n");
dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
nouveau_pmops_resume(&pdev->dev);
- drm_kms_helper_poll_enable(dev);
dev->switch_power_state = DRM_SWITCH_POWER_ON;
} else {
pr_err("VGA switcheroo: switched nouveau off\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/3] drm/nouveau: Remove useless poll_disable() call in switcheroo_set_state()
2018-08-15 19:15 [PATCH v3 0/3] Cleanup drm_kms_helper_poll_enable/disable() calls Lyude Paul
2018-08-15 19:15 ` [PATCH v3 1/3] drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state() Lyude Paul
@ 2018-08-15 19:15 ` Lyude Paul
2018-08-15 19:15 ` [PATCH v3 3/3] drm/nouveau: Remove useless poll_enable() call in drm_load() Lyude Paul
2 siblings, 0 replies; 4+ messages in thread
From: Lyude Paul @ 2018-08-15 19:15 UTC (permalink / raw)
To: nouveau; +Cc: Lukas Wunner, Ben Skeggs, David Airlie, dri-devel, linux-kernel
This won't do anything but potentially make us miss hotplugs. We already
call drm_kms_helper_poll_disable() in
nouveau_pmops_suspend()->nouveau_display_suspend()->nouveau_display_fini()
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
Cc: Lukas Wunner <lukas@wunner.de>
---
drivers/gpu/drm/nouveau/nouveau_vga.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c
index 09b1d8151881..8f1ce4833230 100644
--- a/drivers/gpu/drm/nouveau/nouveau_vga.c
+++ b/drivers/gpu/drm/nouveau/nouveau_vga.c
@@ -50,7 +50,6 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev,
} else {
pr_err("VGA switcheroo: switched nouveau off\n");
dev->switch_power_state = DRM_SWITCH_POWER_CHANGING;
- drm_kms_helper_poll_disable(dev);
nouveau_switcheroo_optimus_dsm();
nouveau_pmops_suspend(&pdev->dev);
dev->switch_power_state = DRM_SWITCH_POWER_OFF;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 3/3] drm/nouveau: Remove useless poll_enable() call in drm_load()
2018-08-15 19:15 [PATCH v3 0/3] Cleanup drm_kms_helper_poll_enable/disable() calls Lyude Paul
2018-08-15 19:15 ` [PATCH v3 1/3] drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state() Lyude Paul
2018-08-15 19:15 ` [PATCH v3 2/3] drm/nouveau: Remove useless poll_disable() " Lyude Paul
@ 2018-08-15 19:15 ` Lyude Paul
2 siblings, 0 replies; 4+ messages in thread
From: Lyude Paul @ 2018-08-15 19:15 UTC (permalink / raw)
To: nouveau; +Cc: Lukas Wunner, Ben Skeggs, David Airlie, dri-devel, linux-kernel
Again, this doesn't do anything. drm_kms_helper_poll_enable() will have
already been called in nouveau_display_init()
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
Cc: Lukas Wunner <lukas@wunner.de>
---
drivers/gpu/drm/nouveau/nouveau_drm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 5fdc1fbe2ee5..04f704b77a3c 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -592,10 +592,8 @@ nouveau_drm_load(struct drm_device *dev, unsigned long flags)
pm_runtime_allow(dev->dev);
pm_runtime_mark_last_busy(dev->dev);
pm_runtime_put(dev->dev);
- } else {
- /* enable polling for external displays */
- drm_kms_helper_poll_enable(dev);
}
+
return 0;
fail_dispinit:
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-15 19:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-15 19:15 [PATCH v3 0/3] Cleanup drm_kms_helper_poll_enable/disable() calls Lyude Paul
2018-08-15 19:15 ` [PATCH v3 1/3] drm/nouveau: Remove useless poll_enable() call in switcheroo_set_state() Lyude Paul
2018-08-15 19:15 ` [PATCH v3 2/3] drm/nouveau: Remove useless poll_disable() " Lyude Paul
2018-08-15 19:15 ` [PATCH v3 3/3] drm/nouveau: Remove useless poll_enable() call in drm_load() Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).