* [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources
@ 2018-08-17 9:18 Marc Zyngier
2018-08-17 9:30 ` Sudeep Holla
2018-08-17 16:00 ` Lina Iyer
0 siblings, 2 replies; 3+ messages in thread
From: Marc Zyngier @ 2018-08-17 9:18 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Gleixner, Lina Iyer, Sudeep Holla
Although GICv3 doesn't directly offers support for wake-up interrupts
and relies on external HW for this, it shouldn't prevent the driver
for such HW from doing it work.
Let's set the required flags on the irq_chip structures.
Reported-by: Lina Iyer <ilina@codeaurora.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
Lina, please let me know how this goes. If that fixes your issues,
I'll queue it as a fix for the current cycle.
drivers/irqchip/irq-gic-v3.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 76ea56d779a1..2d71c79bc698 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -861,7 +861,9 @@ static struct irq_chip gic_chip = {
.irq_set_affinity = gic_set_affinity,
.irq_get_irqchip_state = gic_irq_get_irqchip_state,
.irq_set_irqchip_state = gic_irq_set_irqchip_state,
- .flags = IRQCHIP_SET_TYPE_MASKED,
+ .flags = IRQCHIP_SET_TYPE_MASKED |
+ IRQCHIP_SKIP_SET_WAKE |
+ IRQCHIP_MASK_ON_SUSPEND,
};
static struct irq_chip gic_eoimode1_chip = {
@@ -874,7 +876,9 @@ static struct irq_chip gic_eoimode1_chip = {
.irq_get_irqchip_state = gic_irq_get_irqchip_state,
.irq_set_irqchip_state = gic_irq_set_irqchip_state,
.irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity,
- .flags = IRQCHIP_SET_TYPE_MASKED,
+ .flags = IRQCHIP_SET_TYPE_MASKED |
+ IRQCHIP_SKIP_SET_WAKE |
+ IRQCHIP_MASK_ON_SUSPEND,
};
#define GIC_ID_NR (1U << gic_data.rdists.id_bits)
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources
2018-08-17 9:18 [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources Marc Zyngier
@ 2018-08-17 9:30 ` Sudeep Holla
2018-08-17 16:00 ` Lina Iyer
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2018-08-17 9:30 UTC (permalink / raw)
To: Marc Zyngier; +Cc: linux-kernel, Thomas Gleixner, Lina Iyer, Sudeep Holla
On Fri, Aug 17, 2018 at 10:18:04AM +0100, Marc Zyngier wrote:
> Although GICv3 doesn't directly offers support for wake-up interrupts
> and relies on external HW for this, it shouldn't prevent the driver
> for such HW from doing it work.
>
> Let's set the required flags on the irq_chip structures.
>
FWIW,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources
2018-08-17 9:18 [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources Marc Zyngier
2018-08-17 9:30 ` Sudeep Holla
@ 2018-08-17 16:00 ` Lina Iyer
1 sibling, 0 replies; 3+ messages in thread
From: Lina Iyer @ 2018-08-17 16:00 UTC (permalink / raw)
To: Marc Zyngier; +Cc: linux-kernel, Thomas Gleixner, Sudeep Holla
On Fri, Aug 17 2018 at 03:18 -0600, Marc Zyngier wrote:
>Although GICv3 doesn't directly offers support for wake-up interrupts
>and relies on external HW for this, it shouldn't prevent the driver
>for such HW from doing it work.
>
>Let's set the required flags on the irq_chip structures.
>
>Reported-by: Lina Iyer <ilina@codeaurora.org>
>Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>---
>Lina, please let me know how this goes. If that fixes your issues,
>I'll queue it as a fix for the current cycle.
>
Thanks for the quick turn around, Marc.
Tested-by: Lina Iyer <ilina@codeaurora.org>
> drivers/irqchip/irq-gic-v3.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
>index 76ea56d779a1..2d71c79bc698 100644
>--- a/drivers/irqchip/irq-gic-v3.c
>+++ b/drivers/irqchip/irq-gic-v3.c
>@@ -861,7 +861,9 @@ static struct irq_chip gic_chip = {
> .irq_set_affinity = gic_set_affinity,
> .irq_get_irqchip_state = gic_irq_get_irqchip_state,
> .irq_set_irqchip_state = gic_irq_set_irqchip_state,
>- .flags = IRQCHIP_SET_TYPE_MASKED,
>+ .flags = IRQCHIP_SET_TYPE_MASKED |
>+ IRQCHIP_SKIP_SET_WAKE |
>+ IRQCHIP_MASK_ON_SUSPEND,
> };
>
> static struct irq_chip gic_eoimode1_chip = {
>@@ -874,7 +876,9 @@ static struct irq_chip gic_eoimode1_chip = {
> .irq_get_irqchip_state = gic_irq_get_irqchip_state,
> .irq_set_irqchip_state = gic_irq_set_irqchip_state,
> .irq_set_vcpu_affinity = gic_irq_set_vcpu_affinity,
>- .flags = IRQCHIP_SET_TYPE_MASKED,
>+ .flags = IRQCHIP_SET_TYPE_MASKED |
>+ IRQCHIP_SKIP_SET_WAKE |
>+ IRQCHIP_MASK_ON_SUSPEND,
> };
>
> #define GIC_ID_NR (1U << gic_data.rdists.id_bits)
>--
>2.18.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-17 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 9:18 [PATCH] irqchip/gic-v3: Allow interrupt to be configured as wake-up sources Marc Zyngier
2018-08-17 9:30 ` Sudeep Holla
2018-08-17 16:00 ` Lina Iyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).