* [PATCH] media: camss: mark PM functions as __maybe_unused
@ 2018-08-17 9:53 Arnd Bergmann
2018-08-17 11:32 ` Todor Tomov
2018-08-23 20:14 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-08-17 9:53 UTC (permalink / raw)
To: Todor Tomov, Mauro Carvalho Chehab
Cc: Arnd Bergmann, Hans Verkuil, linux-media, linux-kernel
The empty suspend/resume functions cause a build warning
when they are unused:
drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]
drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]
Mark them as __maybe_unused so the compiler can silently drop them.
Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/media/platform/qcom/camss/camss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
index dcc0c30ef1b1..9f19d5f5966b 100644
--- a/drivers/media/platform/qcom/camss/camss.c
+++ b/drivers/media/platform/qcom/camss/camss.c
@@ -993,12 +993,12 @@ static const struct of_device_id camss_dt_match[] = {
MODULE_DEVICE_TABLE(of, camss_dt_match);
-static int camss_runtime_suspend(struct device *dev)
+static int __maybe_unused camss_runtime_suspend(struct device *dev)
{
return 0;
}
-static int camss_runtime_resume(struct device *dev)
+static int __maybe_unused camss_runtime_resume(struct device *dev)
{
return 0;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: camss: mark PM functions as __maybe_unused
2018-08-17 9:53 [PATCH] media: camss: mark PM functions as __maybe_unused Arnd Bergmann
@ 2018-08-17 11:32 ` Todor Tomov
2018-08-23 20:14 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Todor Tomov @ 2018-08-17 11:32 UTC (permalink / raw)
To: Arnd Bergmann, Mauro Carvalho Chehab
Cc: Hans Verkuil, linux-media, linux-kernel
Thank you Arnd.
On 17.08.2018 12:53, Arnd Bergmann wrote:
> The empty suspend/resume functions cause a build warning
> when they are unused:
>
> drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]
>
> Mark them as __maybe_unused so the compiler can silently drop them.
>
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Todor Tomov <todor.tomov@linaro.org>
> ---
> drivers/media/platform/qcom/camss/camss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index dcc0c30ef1b1..9f19d5f5966b 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -993,12 +993,12 @@ static const struct of_device_id camss_dt_match[] = {
>
> MODULE_DEVICE_TABLE(of, camss_dt_match);
>
> -static int camss_runtime_suspend(struct device *dev)
> +static int __maybe_unused camss_runtime_suspend(struct device *dev)
> {
> return 0;
> }
>
> -static int camss_runtime_resume(struct device *dev)
> +static int __maybe_unused camss_runtime_resume(struct device *dev)
> {
> return 0;
> }
>
--
Best regards,
Todor Tomov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: camss: mark PM functions as __maybe_unused
2018-08-17 9:53 [PATCH] media: camss: mark PM functions as __maybe_unused Arnd Bergmann
2018-08-17 11:32 ` Todor Tomov
@ 2018-08-23 20:14 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2018-08-23 20:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Todor Tomov, Mauro Carvalho Chehab, hansverk,
Linux Media Mailing List, Linux Kernel Mailing List
On Fri, Aug 17, 2018 at 11:54 AM Arnd Bergmann <arnd@arndb.de> wrote:
> The empty suspend/resume functions cause a build warning
> when they are unused:
>
> drivers/media/platform/qcom/camss/camss.c:1001:12: error: 'camss_runtime_resume' defined but not used [-Werror=unused-function]
> drivers/media/platform/qcom/camss/camss.c:996:12: error: 'camss_runtime_suspend' defined but not used [-Werror=unused-function]
>
> Mark them as __maybe_unused so the compiler can silently drop them.
>
> Fixes: 02afa816dbbf ("media: camss: Add basic runtime PM support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-23 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 9:53 [PATCH] media: camss: mark PM functions as __maybe_unused Arnd Bergmann
2018-08-17 11:32 ` Todor Tomov
2018-08-23 20:14 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).