* [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
@ 2018-08-17 14:38 Fabrizio Castro
2018-08-20 22:32 ` Rob Herring
2018-08-22 10:48 ` Simon Horman
0 siblings, 2 replies; 7+ messages in thread
From: Fabrizio Castro @ 2018-08-17 14:38 UTC (permalink / raw)
To: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, David S. Miller, linux-can, netdev, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc, linux-kernel
Document RZ/G2M (r8a774a1) SoC bindings.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
This patch applies on top of next-20180817
Documentation/devicetree/bindings/net/can/rcar_can.txt | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
index 94a7f33..84afc78 100644
--- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
+++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
@@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings
Required properties:
- compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC.
"renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC.
+ "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC.
"renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC.
"renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC.
"renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC.
@@ -16,7 +17,8 @@ Required properties:
"renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device.
"renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1
compatible device.
- "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device.
+ "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2
+ compatible device.
When compatible with the generic version, nodes must list the
SoC-specific version corresponding to the platform first
followed by the generic version.
@@ -24,7 +26,9 @@ Required properties:
- reg: physical base address and size of the R-Car CAN register map.
- interrupts: interrupt specifier for the sole interrupt.
- clocks: phandles and clock specifiers for 3 CAN clock inputs.
-- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk".
+- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk", and
+ 3 clock input name strings for every other SoC: "clkp1", "clkp2",
+ "can_clk".
- pinctrl-0: pin control group to be used for this controller.
- pinctrl-names: must be "default".
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
2018-08-17 14:38 [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro
@ 2018-08-20 22:32 ` Rob Herring
2018-08-22 10:48 ` Simon Horman
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2018-08-20 22:32 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Wolfgang Grandegger, Marc Kleine-Budde, Mark Rutland,
Fabrizio Castro, David S. Miller, linux-can, netdev, devicetree,
Simon Horman, Geert Uytterhoeven, Chris Paterson, Biju Das,
linux-renesas-soc, linux-kernel
On Fri, 17 Aug 2018 15:38:23 +0100, Fabrizio Castro wrote:
> Document RZ/G2M (r8a774a1) SoC bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
> This patch applies on top of next-20180817
>
> Documentation/devicetree/bindings/net/can/rcar_can.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
2018-08-17 14:38 [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro
2018-08-20 22:32 ` Rob Herring
@ 2018-08-22 10:48 ` Simon Horman
2018-08-22 15:12 ` Chris Paterson
1 sibling, 1 reply; 7+ messages in thread
From: Simon Horman @ 2018-08-22 10:48 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring,
Mark Rutland, David S. Miller, linux-can, netdev, devicetree,
Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc,
linux-kernel
On Fri, Aug 17, 2018 at 03:38:23PM +0100, Fabrizio Castro wrote:
> Document RZ/G2M (r8a774a1) SoC bindings.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> This patch applies on top of next-20180817
>
> Documentation/devicetree/bindings/net/can/rcar_can.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> index 94a7f33..84afc78 100644
> --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings
> Required properties:
> - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743 SoC.
> "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC.
> + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC.
> "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC.
> "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC.
> "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC.
> @@ -16,7 +17,8 @@ Required properties:
> "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device.
> "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1
> compatible device.
> - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device.
> + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2
> + compatible device.
> When compatible with the generic version, nodes must list the
> SoC-specific version corresponding to the platform first
> followed by the generic version.
> @@ -24,7 +26,9 @@ Required properties:
> - reg: physical base address and size of the R-Car CAN register map.
> - interrupts: interrupt specifier for the sole interrupt.
> - clocks: phandles and clock specifiers for 3 CAN clock inputs.
> -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk".
> +- clock-names: 2 clock input name strings for RZ/G2: "clkp1", "can_clk", and
Minor comment: Personally I would start a new sentence at "and".
Question: Is a driver update required so support 2-clock SoCs?
> + 3 clock input name strings for every other SoC: "clkp1", "clkp2",
> + "can_clk".
> - pinctrl-0: pin control group to be used for this controller.
> - pinctrl-names: must be "default".
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
2018-08-22 10:48 ` Simon Horman
@ 2018-08-22 15:12 ` Chris Paterson
2018-08-24 8:26 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Chris Paterson @ 2018-08-22 15:12 UTC (permalink / raw)
To: Simon Horman, Fabrizio Castro
Cc: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring,
Mark Rutland, David S. Miller, linux-can, netdev, devicetree,
Geert Uytterhoeven, Biju Das, linux-renesas-soc, linux-kernel
Hello Simon,
> From: Simon Horman <horms@verge.net.au>
> Sent: 22 August 2018 11:49
>
> On Fri, Aug 17, 2018 at 03:38:23PM +0100, Fabrizio Castro wrote:
> > Document RZ/G2M (r8a774a1) SoC bindings.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thank you.
>
> > ---
> > This patch applies on top of next-20180817
> >
> > Documentation/devicetree/bindings/net/can/rcar_can.txt | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > index 94a7f33..84afc78 100644
> > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings
> > Required properties:
> > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743
> SoC.
> > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC.
> > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC.
> > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC.
> > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC.
> > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC.
> > @@ -16,7 +17,8 @@ Required properties:
> > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device.
> > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1
> > compatible device.
> > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device.
> > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2
> > + compatible device.
> > When compatible with the generic version, nodes must list the
> > SoC-specific version corresponding to the platform first
> > followed by the generic version.
> > @@ -24,7 +26,9 @@ Required properties:
> > - reg: physical base address and size of the R-Car CAN register map.
> > - interrupts: interrupt specifier for the sole interrupt.
> > - clocks: phandles and clock specifiers for 3 CAN clock inputs.
> > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk".
> > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1",
> > +"can_clk", and
>
> Minor comment: Personally I would start a new sentence at "and".
>
> Question: Is a driver update required so support 2-clock SoCs?
The driver will work okay as-is.
In theory CAN could be broken if renesas,can-clock-select is set to 0x1 (clkp2) in the DT, as this value will be written to the CAN Clock Select Register. However if the documentation is followed there will be no problems.
We should probably update the driver to fix this though, which will be a change specific to all RZ/G2 devices, so perhaps we should also be adding a "renesas,rzg-gen2-can" family compatible string as well? (to driver and documentation)
Kind regards, Chris
>
> > + 3 clock input name strings for every other SoC: "clkp1", "clkp2",
> > + "can_clk".
> > - pinctrl-0: pin control group to be used for this controller.
> > - pinctrl-names: must be "default".
> >
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
2018-08-22 15:12 ` Chris Paterson
@ 2018-08-24 8:26 ` Simon Horman
2018-08-24 8:31 ` Fabrizio Castro
0 siblings, 1 reply; 7+ messages in thread
From: Simon Horman @ 2018-08-24 8:26 UTC (permalink / raw)
To: Chris Paterson
Cc: Fabrizio Castro, Wolfgang Grandegger, Marc Kleine-Budde,
Rob Herring, Mark Rutland, David S. Miller, linux-can, netdev,
devicetree, Geert Uytterhoeven, Biju Das, linux-renesas-soc,
linux-kernel
On Wed, Aug 22, 2018 at 03:12:26PM +0000, Chris Paterson wrote:
> Hello Simon,
>
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 22 August 2018 11:49
> >
> > On Fri, Aug 17, 2018 at 03:38:23PM +0100, Fabrizio Castro wrote:
> > > Document RZ/G2M (r8a774a1) SoC bindings.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thank you.
>
> >
> > > ---
> > > This patch applies on top of next-20180817
> > >
> > > Documentation/devicetree/bindings/net/can/rcar_can.txt | 8 ++++++--
> > > 1 file changed, 6 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > > b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > > index 94a7f33..84afc78 100644
> > > --- a/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > > +++ b/Documentation/devicetree/bindings/net/can/rcar_can.txt
> > > @@ -4,6 +4,7 @@ Renesas R-Car CAN controller Device Tree Bindings
> > > Required properties:
> > > - compatible: "renesas,can-r8a7743" if CAN controller is a part of R8A7743
> > SoC.
> > > "renesas,can-r8a7745" if CAN controller is a part of R8A7745 SoC.
> > > + "renesas,can-r8a774a1" if CAN controller is a part of R8A774A1 SoC.
> > > "renesas,can-r8a7778" if CAN controller is a part of R8A7778 SoC.
> > > "renesas,can-r8a7779" if CAN controller is a part of R8A7779 SoC.
> > > "renesas,can-r8a7790" if CAN controller is a part of R8A7790 SoC.
> > > @@ -16,7 +17,8 @@ Required properties:
> > > "renesas,rcar-gen1-can" for a generic R-Car Gen1 compatible device.
> > > "renesas,rcar-gen2-can" for a generic R-Car Gen2 or RZ/G1
> > > compatible device.
> > > - "renesas,rcar-gen3-can" for a generic R-Car Gen3 compatible device.
> > > + "renesas,rcar-gen3-can" for a generic R-Car Gen3 or RZ/G2
> > > + compatible device.
> > > When compatible with the generic version, nodes must list the
> > > SoC-specific version corresponding to the platform first
> > > followed by the generic version.
> > > @@ -24,7 +26,9 @@ Required properties:
> > > - reg: physical base address and size of the R-Car CAN register map.
> > > - interrupts: interrupt specifier for the sole interrupt.
> > > - clocks: phandles and clock specifiers for 3 CAN clock inputs.
> > > -- clock-names: 3 clock input name strings: "clkp1", "clkp2", "can_clk".
> > > +- clock-names: 2 clock input name strings for RZ/G2: "clkp1",
> > > +"can_clk", and
> >
> > Minor comment: Personally I would start a new sentence at "and".
> >
> > Question: Is a driver update required so support 2-clock SoCs?
>
> The driver will work okay as-is.
>
> In theory CAN could be broken if renesas,can-clock-select is set to 0x1
> (clkp2) in the DT, as this value will be written to the CAN Clock Select
> Register. However if the documentation is followed there will be no
> problems.
>
> We should probably update the driver to fix this though, which will be a
> change specific to all RZ/G2 devices, so perhaps we should also be adding
> a "renesas,rzg-gen2-can" family compatible string as well? (to driver and
> documentation)
Yes, I think that sounds reasonable.
But in that case we should pre-emptively not use renesas,rcar-gen3-can for
RZ/G2.
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
2018-08-24 8:26 ` Simon Horman
@ 2018-08-24 8:31 ` Fabrizio Castro
2018-08-27 12:55 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Fabrizio Castro @ 2018-08-24 8:31 UTC (permalink / raw)
To: Simon Horman, Chris Paterson
Cc: Wolfgang Grandegger, Marc Kleine-Budde, Rob Herring,
Mark Rutland, David S. Miller, linux-can, netdev, devicetree,
Geert Uytterhoeven, Biju Das, linux-renesas-soc, linux-kernel
Hello Simon,
Thank you for the feedback!
> >
> > In theory CAN could be broken if renesas,can-clock-select is set to 0x1
> > (clkp2) in the DT, as this value will be written to the CAN Clock Select
> > Register. However if the documentation is followed there will be no
> > problems.
> >
> > We should probably update the driver to fix this though, which will be a
> > change specific to all RZ/G2 devices, so perhaps we should also be adding
> > a "renesas,rzg-gen2-can" family compatible string as well? (to driver and
> > documentation)
>
> Yes, I think that sounds reasonable.
>
> But in that case we should pre-emptively not use renesas,rcar-gen3-can for
> RZ/G2.
What do you think about the following:
https://patchwork.kernel.org/patch/10573795/
https://patchwork.kernel.org/patch/10573791/
https://patchwork.kernel.org/patch/10573805/
Thanks,
Fab
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support
2018-08-24 8:31 ` Fabrizio Castro
@ 2018-08-27 12:55 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2018-08-27 12:55 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Chris Paterson, Wolfgang Grandegger, Marc Kleine-Budde,
Rob Herring, Mark Rutland, David S. Miller, linux-can, netdev,
devicetree, Geert Uytterhoeven, Biju Das, linux-renesas-soc,
linux-kernel
On Fri, Aug 24, 2018 at 08:31:42AM +0000, Fabrizio Castro wrote:
> Hello Simon,
>
> Thank you for the feedback!
>
> > >
> > > In theory CAN could be broken if renesas,can-clock-select is set to 0x1
> > > (clkp2) in the DT, as this value will be written to the CAN Clock Select
> > > Register. However if the documentation is followed there will be no
> > > problems.
> > >
> > > We should probably update the driver to fix this though, which will be a
> > > change specific to all RZ/G2 devices, so perhaps we should also be adding
> > > a "renesas,rzg-gen2-can" family compatible string as well? (to driver and
> > > documentation)
> >
> > Yes, I think that sounds reasonable.
> >
> > But in that case we should pre-emptively not use renesas,rcar-gen3-can for
> > RZ/G2.
>
> What do you think about the following:
> https://patchwork.kernel.org/patch/10573795/
> https://patchwork.kernel.org/patch/10573791/
> https://patchwork.kernel.org/patch/10573805/
I think that is the right approach.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-27 12:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 14:38 [PATCH] dt-bindings: can: rcar_can: Add r8a774a1 support Fabrizio Castro
2018-08-20 22:32 ` Rob Herring
2018-08-22 10:48 ` Simon Horman
2018-08-22 15:12 ` Chris Paterson
2018-08-24 8:26 ` Simon Horman
2018-08-24 8:31 ` Fabrizio Castro
2018-08-27 12:55 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).