* [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue
@ 2018-08-24 23:07 GuyLuz
2018-08-25 7:15 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: GuyLuz @ 2018-08-24 23:07 UTC (permalink / raw)
To: guyluz50; +Cc: guyluz11, linux-kernel, devel
From: Guy Luz <guyluz50@gmail.com>
Fixed a Lines should not end with a '(' issue.
Signed-off-by: Guy Luz <guyluz50@gmail.com>
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 63992c0babf7..a85334f53ff9 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -2173,10 +2173,9 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
* allows
*/
if (cmd->scan_begin_src == TRIG_TIMER) {
- err |= comedi_check_trigger_arg_min(
- &cmd->scan_begin_arg,
- cmd->convert_arg *
- cmd->chanlist_len);
+ err |= comedi_check_trigger_arg_min
+ (&cmd->scan_begin_arg, cmd->convert_arg *
+ cmd->chanlist_len);
}
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue
2018-08-24 23:07 [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue GuyLuz
@ 2018-08-25 7:15 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2018-08-25 7:15 UTC (permalink / raw)
To: GuyLuz; +Cc: devel, guyluz11, linux-kernel
On Sat, Aug 25, 2018 at 02:07:01AM +0300, GuyLuz wrote:
> From: Guy Luz <guyluz50@gmail.com>
>
> Fixed a Lines should not end with a '(' issue.
>
> Signed-off-by: Guy Luz <guyluz50@gmail.com>
> ---
> drivers/staging/comedi/drivers/cb_pcidas64.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
> index 63992c0babf7..a85334f53ff9 100644
> --- a/drivers/staging/comedi/drivers/cb_pcidas64.c
> +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
> @@ -2173,10 +2173,9 @@ static int ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s,
> * allows
> */
> if (cmd->scan_begin_src == TRIG_TIMER) {
> - err |= comedi_check_trigger_arg_min(
> - &cmd->scan_begin_arg,
> - cmd->convert_arg *
> - cmd->chanlist_len);
> + err |= comedi_check_trigger_arg_min
> + (&cmd->scan_begin_arg, cmd->convert_arg *
> + cmd->chanlist_len);
The original is better than the new version. Please leave it as is.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-25 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-24 23:07 [PATCH] staging: comedi: cb_pcidas64 fixed '(' coding style issue GuyLuz
2018-08-25 7:15 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).