[PATCH] objtool: remove workaround for unreachable warnings from old GCC

[PATCH] objtool: remove workaround for unreachable warnings from old GCC

[Masahiro Yamada]

Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.

This effectively reverts commit da541b20021c ("objtool: Skip
unreachable warnings for GCC 4.4 and older"), which was a workaround
for GCC 4.4 or older.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 scripts/Makefile.build | 2 --
 1 file changed, 2 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 1c48572..5a2d1c9 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -246,8 +246,6 @@ objtool_args += --no-fp
 endif
 ifdef CONFIG_GCOV_KERNEL
 objtool_args += --no-unreachable
-else
-objtool_args += $(call cc-ifversion, -lt, 0405, --no-unreachable)
 endif
 ifdef CONFIG_RETPOLINE
 ifneq ($(RETPOLINE_CFLAGS),)
-- 
2.7.4

Re: [PATCH] objtool: remove workaround for unreachable warnings from old GCC

[Josh Poimboeuf]

On Mon, Aug 27, 2018 at 12:39:43PM +0900, Masahiro Yamada wrote:
> Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
> bumped the minimum GCC version to 4.6 for all architectures.
> 
> This effectively reverts commit da541b20021c ("objtool: Skip
> unreachable warnings for GCC 4.4 and older"), which was a workaround
> for GCC 4.4 or older.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

> ---
> 
>  scripts/Makefile.build | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 1c48572..5a2d1c9 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -246,8 +246,6 @@ objtool_args += --no-fp
>  endif
>  ifdef CONFIG_GCOV_KERNEL
>  objtool_args += --no-unreachable
> -else
> -objtool_args += $(call cc-ifversion, -lt, 0405, --no-unreachable)
>  endif
>  ifdef CONFIG_RETPOLINE
>  ifneq ($(RETPOLINE_CFLAGS),)
> -- 
> 2.7.4
> 

-- 
Josh

[tip:core/urgent] objtool: Remove workaround for unreachable warnings from old GCC

[tip-bot for Masahiro Yamada]

Commit-ID:  113fc08357ad4e8b84caa75402430875d9ac4c1a
Gitweb:     https://git.kernel.org/tip/113fc08357ad4e8b84caa75402430875d9ac4c1a
Author:     Masahiro Yamada <yamada.masahiro@socionext.com>
AuthorDate: Mon, 27 Aug 2018 12:39:43 +0900
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 30 Aug 2018 12:56:40 +0200

objtool: Remove workaround for unreachable warnings from old GCC

Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6")
bumped the minimum GCC version to 4.6 for all architectures.

This effectively reverts commit da541b20021c ("objtool: Skip unreachable
warnings for GCC 4.4 and older"), which was a workaround for GCC 4.4 or
older.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org
Link: https://lkml.kernel.org/r/1535341183-19994-1-git-send-email-yamada.masahiro@socionext.com

---
 scripts/Makefile.build | 2 --
 1 file changed, 2 deletions(-)

diff --git a/scripts/Makefile.build b/scripts/Makefile.build
index 1c48572223d1..5a2d1c9578a0 100644
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -246,8 +246,6 @@ objtool_args += --no-fp
 endif
 ifdef CONFIG_GCOV_KERNEL
 objtool_args += --no-unreachable
-else
-objtool_args += $(call cc-ifversion, -lt, 0405, --no-unreachable)
 endif
 ifdef CONFIG_RETPOLINE
 ifneq ($(RETPOLINE_CFLAGS),)