linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/xen: remove redundant variable save_pud
@ 2018-08-28 16:10 Colin King
  2018-08-28 22:27 ` Boris Ostrovsky
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-08-28 16:10 UTC (permalink / raw)
  To: Boris Ostrovsky, Juergen Gross, Thomas Gleixner, Ingo Molnar,
	H . Peter Anvin, x86, xen-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable save_pud is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
variable 'save_pud' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 arch/x86/xen/mmu_pv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c
index 06a814d44b9b..2fe5c9b1816b 100644
--- a/arch/x86/xen/mmu_pv.c
+++ b/arch/x86/xen/mmu_pv.c
@@ -2060,7 +2060,6 @@ void __init xen_relocate_p2m(void)
 	pud_t *pud;
 	pgd_t *pgd;
 	unsigned long *new_p2m;
-	int save_pud;
 
 	size = PAGE_ALIGN(xen_start_info->nr_pages * sizeof(unsigned long));
 	n_pte = roundup(size, PAGE_SIZE) >> PAGE_SHIFT;
@@ -2090,7 +2089,6 @@ void __init xen_relocate_p2m(void)
 
 	pgd = __va(read_cr3_pa());
 	new_p2m = (unsigned long *)(2 * PGDIR_SIZE);
-	save_pud = n_pud;
 	for (idx_pud = 0; idx_pud < n_pud; idx_pud++) {
 		pud = early_memremap(pud_phys, PAGE_SIZE);
 		clear_page(pud);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86/xen: remove redundant variable save_pud
  2018-08-28 16:10 [PATCH] x86/xen: remove redundant variable save_pud Colin King
@ 2018-08-28 22:27 ` Boris Ostrovsky
  0 siblings, 0 replies; 2+ messages in thread
From: Boris Ostrovsky @ 2018-08-28 22:27 UTC (permalink / raw)
  To: Colin King, Juergen Gross, Thomas Gleixner, Ingo Molnar,
	H . Peter Anvin, x86, xen-devel
  Cc: kernel-janitors, linux-kernel

On 08/28/2018 12:10 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable save_pud is being assigned but is never used hence it is
> redundant and can be removed.
>
> Cleans up clang warning:
> variable 'save_pud' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>



Applied to for-linus-19b.

-boris


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-28 22:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 16:10 [PATCH] x86/xen: remove redundant variable save_pud Colin King
2018-08-28 22:27 ` Boris Ostrovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).