* [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions
@ 2018-08-27 16:43 Ivan Mikhaylov
2018-08-30 1:10 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Ivan Mikhaylov @ 2018-08-27 16:43 UTC (permalink / raw)
To: netdev; +Cc: David S . Miller, Christian Lamparter, linux-kernel
Signed-off-by: Ivan Mikhaylov <ivan@de.ibm.com>
---
drivers/net/ethernet/ibm/emac/emac.h | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/ibm/emac/emac.h b/drivers/net/ethernet/ibm/emac/emac.h
index e2f80cc..f541660 100644
--- a/drivers/net/ethernet/ibm/emac/emac.h
+++ b/drivers/net/ethernet/ibm/emac/emac.h
@@ -229,7 +229,6 @@ struct emac_regs {
#define EMAC_STACR_PHYD_SHIFT 16
#define EMAC_STACR_OC 0x00008000
#define EMAC_STACR_PHYE 0x00004000
-#define EMAC_STACR_STAC_MASK 0x00003000
#define EMAC_STACR_STAC_READ 0x00001000
#define EMAC_STACR_STAC_WRITE 0x00000800
#define EMAC_STACR_OPBC_MASK 0x00000C00
@@ -245,14 +244,8 @@ struct emac_regs {
#define EMAC_STACR_PCDA_MASK 0x1f
#define EMAC_STACR_PCDA_SHIFT 5
#define EMAC_STACR_PRA_MASK 0x1f
-#define EMACX_STACR_STAC_MASK 0x00003800
#define EMACX_STACR_STAC_READ 0x00001000
#define EMACX_STACR_STAC_WRITE 0x00000800
-#define EMACX_STACR_STAC_IND_ADDR 0x00002000
-#define EMACX_STACR_STAC_IND_READ 0x00003800
-#define EMACX_STACR_STAC_IND_READINC 0x00003000
-#define EMACX_STACR_STAC_IND_WRITE 0x00002800
-
/* EMACx_TRTR */
#define EMAC_TRTR_SHIFT_EMAC4 24
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions
2018-08-27 16:43 [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions Ivan Mikhaylov
@ 2018-08-30 1:10 ` David Miller
2018-08-31 11:23 ` Ivan Mikhaylov
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2018-08-30 1:10 UTC (permalink / raw)
To: ivan; +Cc: netdev, chunkeey, linux-kernel
From: Ivan Mikhaylov <ivan@de.ibm.com>
Date: Mon, 27 Aug 2018 19:43:36 +0300
> Signed-off-by: Ivan Mikhaylov <ivan@de.ibm.com>
Please do not delete these, they could be useful for other
developers and people reading this driver.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions
2018-08-30 1:10 ` David Miller
@ 2018-08-31 11:23 ` Ivan Mikhaylov
2018-08-31 16:21 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Ivan Mikhaylov @ 2018-08-31 11:23 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel, Christian Lamparter
>Please do not delete these, they could be useful for other
>developers and people reading this driver.
Hmm, that's possible, need I resubmit first patch without this one?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions
2018-08-31 11:23 ` Ivan Mikhaylov
@ 2018-08-31 16:21 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-08-31 16:21 UTC (permalink / raw)
To: ivan; +Cc: netdev, linux-kernel, chunkeey
From: Ivan Mikhaylov <ivan@de.ibm.com>
Date: Fri, 31 Aug 2018 14:23:45 +0300
>>Please do not delete these, they could be useful for other
>>developers and people reading this driver.
> Hmm, that's possible, need I resubmit first patch without this one?
Yes.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-31 16:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-27 16:43 [PATCH 2/2] net/ibm/emac: deletion of unneeded macros definitions Ivan Mikhaylov
2018-08-30 1:10 ` David Miller
2018-08-31 11:23 ` Ivan Mikhaylov
2018-08-31 16:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).