From: Rob Herring <robh@kernel.org>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Zhouyang Jia <jiazhouyang09@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 8/8] dt-binding: mtd: Document gpio-addr-flash
Date: Fri, 31 Aug 2018 08:17:51 -0400 [thread overview]
Message-ID: <20180831121751.GA22256@bogus> (raw)
In-Reply-To: <20180821143152.32293-9-ricardo.ribalda@gmail.com>
On Tue, Aug 21, 2018 at 04:31:52PM +0200, Ricardo Ribalda Delgado wrote:
> Add documentation for gpio-addr-flash. This binding allow creating
> flash devices that are paged using GPIOs.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> .../bindings/mtd/gpio-addr-flash.txt | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt
>
> diff --git a/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt b/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt
> new file mode 100644
> index 000000000000..4279e8cad09b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt
> @@ -0,0 +1,46 @@
> +Memory Mapped flash with some address lines addressed using GPIOs
That's ugly...
> +
> +Handle the case where a flash device is mostly addressed using physical
> +line and supplemented by GPIOs. This way you can hook up say a 8MiB flash
> +to a 2MiB memory range and use the GPIOs to select a particular range.
> +
> + - compatible : "cfi-gpio-addr-flash"
Why a new compatible? Shouldn't just adding some address gpios to an
existing flash device binding be sufficient?
> + - reg : Address range of the mtd chip that is memory mapped, this is,
> + on the previous example 2MiB.
> + - bank-width : Width (in bytes) of the bank. Equal to the
> + device width times the number of interleaved chips.
> + - probe-type : (optional) "cfi_probe", "jedec_probe". How the mtd chip
> + is going to be probed. If omitted, assumed to be equal to "cfi_probe".
> + - #address-cells, #size-cells : Must be present if the device has
> + sub-nodes representing partitions (see below). In this case
> + both #address-cells and #size-cells must be equal to 1.
> +
> +The device tree may optionally contain sub-nodes describing partitions of the
> +address space. See partition.txt for more detail.
> +
> +Example:
> +
> + cfi_flash_0: cfi_flash {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "cfi-gpio-addr-flash";
> + bank-width = <2>;
> + reg = < 0x00300000 0x00200000 >;
> + gpios = <&gpio_0 3 0>, <&gpio_0 4 0>;
> + partition@0 {
> + reg = < 0x0 0x200000 >;
> + label = "Golden Bitstream";
> + };
> + partition@200000 {
> + reg = < 0x200000 0x200000 >;
> + label = "User Bitstream";
> + };
> + partition@400000 {
> + reg = < 0x400000 0x200000 >;
> + label = "V4L Controls";
> + };
> + partition@600000 {
> + reg = < 0x600000 0x200000 >;
> + label = "Production Data";
> + };
> + } ;
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-08-31 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 14:31 [PATCH 0/8] gpio-addr-flash: Support for device-tree and cleanup Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 1/8] mtd: maps: gpio-addr-flash: Replace custom printk Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 2/8] mtd: maps: gpio-addr-flash: Fix ioremapped size Ricardo Ribalda Delgado
2018-08-28 14:26 ` Boris Brezillon
2018-08-28 14:44 ` Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 3/8] mtd: maps: gpio-addr-flash: Use devm_* functions Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 4/8] mtd: maps: gpio-addr-flash: Use order insted of size Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 5/8] mtd: maps: gpio-addr-flash: Replace array with an integer Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 6/8] mtd: maps: gpio-addr-flash: Split allocation in two Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 7/8] mtd: maps: gpio-addr-flash: Add support for device-tree devices Ricardo Ribalda Delgado
2018-08-21 14:31 ` [PATCH 8/8] dt-binding: mtd: Document gpio-addr-flash Ricardo Ribalda Delgado
2018-08-31 12:17 ` Rob Herring [this message]
2018-08-31 12:20 ` Ricardo Ribalda Delgado
2018-09-04 14:04 ` [PATCH 0/8] gpio-addr-flash: Support for device-tree and cleanup Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831121751.GA22256@bogus \
--to=robh@kernel.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=jiazhouyang09@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=ricardo.ribalda@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).