LKML Archive on lore.kernel.org
 help / color / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Dennis Zhou <dennisszhou@gmail.com>
Cc: kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
	Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
	Josef Bacik <josef@toxicpanda.com>,
	kernel-team@fb.com, linux-block@vger.kernel.org,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
Subject: Re: [PATCH 07/15] blkcg: consolidate bio_issue_init and blkg association
Date: Fri, 31 Aug 2018 17:19:32 +0800
Message-ID: <201808311702.YvmB4eH9%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180831015356.69796-8-dennisszhou@gmail.com>


[-- Attachment #1: Type: text/plain, Size: 3945 bytes --]

Hi Dennis,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on block/for-next]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Dennis-Zhou/blkcg-ref-count-refactor-cleanup-blkcg-avg_lat/20180831-161742
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-x017-201834 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from block/bounce.c:13:0:
   include/linux/bio.h:566:17: warning: 'struct blkcg_gq' declared inside parameter list will not be visible outside of this definition or declaration
             struct blkcg_gq *blkg) { return 0; }
                    ^~~~~~~~
   block/bounce.c: In function 'bounce_clone_bio':
>> block/bounce.c:262:23: error: 'struct bio' has no member named 'bi_issue'; did you mean 'bi_disk'?
     bio_issue_init(&bio->bi_issue, bio_sectors(bio));
                          ^~~~~~~~
                          bi_disk

vim +262 block/bounce.c

   197	
   198	static struct bio *bounce_clone_bio(struct bio *bio_src, gfp_t gfp_mask,
   199			struct bio_set *bs)
   200	{
   201		struct bvec_iter iter;
   202		struct bio_vec bv;
   203		struct bio *bio;
   204	
   205		/*
   206		 * Pre immutable biovecs, __bio_clone() used to just do a memcpy from
   207		 * bio_src->bi_io_vec to bio->bi_io_vec.
   208		 *
   209		 * We can't do that anymore, because:
   210		 *
   211		 *  - The point of cloning the biovec is to produce a bio with a biovec
   212		 *    the caller can modify: bi_idx and bi_bvec_done should be 0.
   213		 *
   214		 *  - The original bio could've had more than BIO_MAX_PAGES biovecs; if
   215		 *    we tried to clone the whole thing bio_alloc_bioset() would fail.
   216		 *    But the clone should succeed as long as the number of biovecs we
   217		 *    actually need to allocate is fewer than BIO_MAX_PAGES.
   218		 *
   219		 *  - Lastly, bi_vcnt should not be looked at or relied upon by code
   220		 *    that does not own the bio - reason being drivers don't use it for
   221		 *    iterating over the biovec anymore, so expecting it to be kept up
   222		 *    to date (i.e. for clones that share the parent biovec) is just
   223		 *    asking for trouble and would force extra work on
   224		 *    __bio_clone_fast() anyways.
   225		 */
   226	
   227		bio = bio_alloc_bioset(gfp_mask, bio_segments(bio_src), bs);
   228		if (!bio)
   229			return NULL;
   230		bio->bi_disk		= bio_src->bi_disk;
   231		bio->bi_opf		= bio_src->bi_opf;
   232		bio->bi_write_hint	= bio_src->bi_write_hint;
   233		bio->bi_iter.bi_sector	= bio_src->bi_iter.bi_sector;
   234		bio->bi_iter.bi_size	= bio_src->bi_iter.bi_size;
   235	
   236		switch (bio_op(bio)) {
   237		case REQ_OP_DISCARD:
   238		case REQ_OP_SECURE_ERASE:
   239		case REQ_OP_WRITE_ZEROES:
   240			break;
   241		case REQ_OP_WRITE_SAME:
   242			bio->bi_io_vec[bio->bi_vcnt++] = bio_src->bi_io_vec[0];
   243			break;
   244		default:
   245			bio_for_each_segment(bv, bio_src, iter)
   246				bio->bi_io_vec[bio->bi_vcnt++] = bv;
   247			break;
   248		}
   249	
   250		if (bio_integrity(bio_src)) {
   251			int ret;
   252	
   253			ret = bio_integrity_clone(bio, bio_src, gfp_mask);
   254			if (ret < 0) {
   255				bio_put(bio);
   256				return NULL;
   257			}
   258		}
   259	
   260		bio_clone_blkcg_association(bio, bio_src);
   261	
 > 262		bio_issue_init(&bio->bi_issue, bio_sectors(bio));
   263	
   264		return bio;
   265	}
   266	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 34602 bytes --]

  reply index

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31  1:53 [PATCH 00/15] blkcg ref count refactor/cleanup + blkcg avg_lat Dennis Zhou
2018-08-31  1:53 ` [PATCH 01/15] Revert "blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()" Dennis Zhou
2018-08-31  1:53 ` [PATCH 02/15] blkcg: delay blkg destruction until after writeback has finished Dennis Zhou
2018-08-31 15:27   ` Josef Bacik
2018-08-31 20:19     ` Dennis Zhou
2018-08-31  1:53 ` [PATCH 03/15] blkcg: use tryget logic when associating a blkg with a bio Dennis Zhou
2018-08-31 15:30   ` Josef Bacik
2018-08-31 20:20     ` Dennis Zhou
2018-08-31  1:53 ` [PATCH 04/15] blkcg: fix ref count issue with bio_blkcg using task_css Dennis Zhou
2018-08-31 15:35   ` Josef Bacik
2018-08-31 23:04     ` Tejun Heo
2018-09-06 15:21     ` Dennis Zhou
2018-08-31  1:53 ` [PATCH 05/15] blkcg: update blkg_lookup_create to do locking Dennis Zhou
2018-08-31 15:37   ` Josef Bacik
2018-08-31 23:09   ` Tejun Heo
2018-08-31  1:53 ` [PATCH 06/15] blkcg: always associate a bio with a blkg Dennis Zhou
2018-08-31  9:01   ` kbuild test robot
2018-08-31 10:02   ` kbuild test robot
2018-08-31 23:16   ` Tejun Heo
2018-09-06 20:41     ` Dennis Zhou
2018-09-07  3:03   ` [LKP] [blkcg] c02c58dab2: WARNING:at_block/blk-throttle.c:#blk_throtl_bio kernel test robot
2018-08-31  1:53 ` [PATCH 07/15] blkcg: consolidate bio_issue_init and blkg association Dennis Zhou
2018-08-31  9:19   ` kbuild test robot [this message]
2018-08-31 11:11   ` kbuild test robot
2018-08-31 15:42   ` Josef Bacik
2018-09-06 20:43     ` Dennis Zhou
2018-08-31 23:45   ` Tejun Heo
2018-08-31  1:53 ` [PATCH 08/15] blkcg: associate a blkg for pages being evicted by swap Dennis Zhou
2018-08-31 15:44   ` Josef Bacik
2018-08-31 23:47   ` Tejun Heo
2018-08-31  1:53 ` [PATCH 09/15] blkcg: associate writeback bios with a blkg Dennis Zhou
2018-08-31 15:45   ` Josef Bacik
2018-08-31 23:53   ` Tejun Heo
2018-08-31  1:53 ` [PATCH 10/15] blkcg: remove bio->bi_css and instead use bio->bi_blkg Dennis Zhou
2018-08-31 15:46   ` Josef Bacik
2018-09-01  0:13   ` Tejun Heo
2018-08-31  1:53 ` [PATCH 11/15] blkcg: remove additional reference to the css Dennis Zhou
2018-09-01  0:26   ` Tejun Heo
2018-09-06 20:45     ` Dennis Zhou
2018-08-31  1:53 ` [PATCH 12/15] blkcg: cleanup and make blk_get_rl use blkg_lookup_create Dennis Zhou
2018-09-01  0:29   ` Tejun Heo
2018-09-11  2:37   ` [LKP] [blkcg] 22f657e287: general_protection_fault:#[##] kernel test robot
2018-08-31  1:53 ` [PATCH 13/15] blkcg: change blkg reference counting to use percpu_ref Dennis Zhou
2018-08-31 15:49   ` Josef Bacik
2018-09-01  0:31   ` Tejun Heo
2018-09-06 20:46     ` Dennis Zhou
2018-09-07  3:08   ` [LKP] [blkcg] 6ef69a3a0b: WARNING:suspicious_RCU_usage kernel test robot
2018-08-31  1:53 ` [PATCH 14/15] blkcg: rename blkg_try_get to blkg_tryget Dennis Zhou
2018-08-31 15:50   ` Josef Bacik
2018-09-01  0:32   ` Tejun Heo
2018-08-31  1:53 ` [PATCH 15/15] blkcg: add average latency tracking to blk-cgroup Dennis Zhou
2018-08-31 10:22   ` kbuild test robot
2018-08-31 11:38   ` kbuild test robot
2018-09-01  0:35 ` [PATCH 00/15] blkcg ref count refactor/cleanup + blkcg avg_lat Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201808311702.YvmB4eH9%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=dennisszhou@gmail.com \
    --cc=hannes@cmpxchg.org \
    --cc=josef@toxicpanda.com \
    --cc=kbuild-all@01.org \
    --cc=kernel-team@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git