From: kbuild test robot <lkp@intel.com>
To: Dennis Zhou <dennisszhou@gmail.com>
Cc: kbuild-all@01.org, Jens Axboe <axboe@kernel.dk>,
Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Josef Bacik <josef@toxicpanda.com>,
kernel-team@fb.com, linux-block@vger.kernel.org,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dennis Zhou (Facebook)" <dennisszhou@gmail.com>
Subject: Re: [PATCH 15/15] blkcg: add average latency tracking to blk-cgroup
Date: Fri, 31 Aug 2018 19:38:26 +0800 [thread overview]
Message-ID: <201808311920.BT1iVxJW%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180831015356.69796-16-dennisszhou@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6508 bytes --]
Hi Dennis,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dennis-Zhou/blkcg-ref-count-refactor-cleanup-blkcg-avg_lat/20180831-161742
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-x017-201834 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from block/bio.c:20:0:
include/linux/bio.h:565:17: warning: 'struct blkcg_gq' declared inside parameter list will not be visible outside of this definition or declaration
struct blkcg_gq *blkg) { return 0; }
^~~~~~~~
block/bio.c: In function '__bio_clone_fast':
block/bio.c:614:23: error: 'struct bio' has no member named 'bi_issue'; did you mean 'bi_disk'?
bio_issue_init(&bio->bi_issue, bio_sectors(bio));
^~~~~~~~
bi_disk
In file included from include/asm-generic/bug.h:5:0,
from arch/x86/include/asm/bug.h:83,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from block/bio.c:18:
block/bio.c: In function 'bio_endio':
block/bio.c:1750:11: error: 'struct bio' has no member named 'bi_blkg'; did you mean 'bi_flags'?
if (bio->bi_blkg && bio->bi_blkg->parent)
^
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> block/bio.c:1750:2: note: in expansion of macro 'if'
if (bio->bi_blkg && bio->bi_blkg->parent)
^~
block/bio.c:1750:27: error: 'struct bio' has no member named 'bi_blkg'; did you mean 'bi_flags'?
if (bio->bi_blkg && bio->bi_blkg->parent)
^
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> block/bio.c:1750:2: note: in expansion of macro 'if'
if (bio->bi_blkg && bio->bi_blkg->parent)
^~
block/bio.c:1750:11: error: 'struct bio' has no member named 'bi_blkg'; did you mean 'bi_flags'?
if (bio->bi_blkg && bio->bi_blkg->parent)
^
include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> block/bio.c:1750:2: note: in expansion of macro 'if'
if (bio->bi_blkg && bio->bi_blkg->parent)
^~
block/bio.c:1750:27: error: 'struct bio' has no member named 'bi_blkg'; did you mean 'bi_flags'?
if (bio->bi_blkg && bio->bi_blkg->parent)
^
include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> block/bio.c:1750:2: note: in expansion of macro 'if'
if (bio->bi_blkg && bio->bi_blkg->parent)
^~
block/bio.c:1750:11: error: 'struct bio' has no member named 'bi_blkg'; did you mean 'bi_flags'?
if (bio->bi_blkg && bio->bi_blkg->parent)
^
include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> block/bio.c:1750:2: note: in expansion of macro 'if'
if (bio->bi_blkg && bio->bi_blkg->parent)
^~
block/bio.c:1750:27: error: 'struct bio' has no member named 'bi_blkg'; did you mean 'bi_flags'?
if (bio->bi_blkg && bio->bi_blkg->parent)
^
include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> block/bio.c:1750:2: note: in expansion of macro 'if'
if (bio->bi_blkg && bio->bi_blkg->parent)
^~
vim +/if +1750 block/bio.c
1727
1728 /**
1729 * bio_endio - end I/O on a bio
1730 * @bio: bio
1731 *
1732 * Description:
1733 * bio_endio() will end I/O on the whole bio. bio_endio() is the preferred
1734 * way to end I/O on a bio. No one should call bi_end_io() directly on a
1735 * bio unless they own it and thus know that it has an end_io function.
1736 *
1737 * bio_endio() can be called several times on a bio that has been chained
1738 * using bio_chain(). The ->bi_end_io() function will only be called the
1739 * last time. At this point the BLK_TA_COMPLETE tracing event will be
1740 * generated if BIO_TRACE_COMPLETION is set.
1741 **/
1742 void bio_endio(struct bio *bio)
1743 {
1744 again:
1745 if (!bio_remaining_done(bio))
1746 return;
1747 if (!bio_integrity_endio(bio))
1748 return;
1749
> 1750 if (bio->bi_blkg && bio->bi_blkg->parent)
1751 blkg_record_latency(bio);
1752
1753 if (bio->bi_disk)
1754 rq_qos_done_bio(bio->bi_disk->queue, bio);
1755
1756 /*
1757 * Need to have a real endio function for chained bios, otherwise
1758 * various corner cases will break (like stacking block devices that
1759 * save/restore bi_end_io) - however, we want to avoid unbounded
1760 * recursion and blowing the stack. Tail call optimization would
1761 * handle this, but compiling with frame pointers also disables
1762 * gcc's sibling call optimization.
1763 */
1764 if (bio->bi_end_io == bio_chain_endio) {
1765 bio = __bio_chain_endio(bio);
1766 goto again;
1767 }
1768
1769 if (bio->bi_disk && bio_flagged(bio, BIO_TRACE_COMPLETION)) {
1770 trace_block_bio_complete(bio->bi_disk->queue, bio,
1771 blk_status_to_errno(bio->bi_status));
1772 bio_clear_flag(bio, BIO_TRACE_COMPLETION);
1773 }
1774
1775 blk_throtl_bio_endio(bio);
1776 /* release cgroup info */
1777 bio_uninit(bio);
1778 if (bio->bi_end_io)
1779 bio->bi_end_io(bio);
1780 }
1781 EXPORT_SYMBOL(bio_endio);
1782
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30993 bytes --]
next prev parent reply other threads:[~2018-08-31 11:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 1:53 [PATCH 00/15] blkcg ref count refactor/cleanup + blkcg avg_lat Dennis Zhou
2018-08-31 1:53 ` [PATCH 01/15] Revert "blk-throttle: fix race between blkcg_bio_issue_check() and cgroup_rmdir()" Dennis Zhou
2018-08-31 1:53 ` [PATCH 02/15] blkcg: delay blkg destruction until after writeback has finished Dennis Zhou
2018-08-31 15:27 ` Josef Bacik
2018-08-31 20:19 ` Dennis Zhou
2018-08-31 1:53 ` [PATCH 03/15] blkcg: use tryget logic when associating a blkg with a bio Dennis Zhou
2018-08-31 15:30 ` Josef Bacik
2018-08-31 20:20 ` Dennis Zhou
2018-08-31 1:53 ` [PATCH 04/15] blkcg: fix ref count issue with bio_blkcg using task_css Dennis Zhou
2018-08-31 15:35 ` Josef Bacik
2018-08-31 23:04 ` Tejun Heo
2018-09-06 15:21 ` Dennis Zhou
2018-08-31 1:53 ` [PATCH 05/15] blkcg: update blkg_lookup_create to do locking Dennis Zhou
2018-08-31 15:37 ` Josef Bacik
2018-08-31 23:09 ` Tejun Heo
2018-08-31 1:53 ` [PATCH 06/15] blkcg: always associate a bio with a blkg Dennis Zhou
2018-08-31 9:01 ` kbuild test robot
2018-08-31 10:02 ` kbuild test robot
2018-08-31 23:16 ` Tejun Heo
2018-09-06 20:41 ` Dennis Zhou
2018-09-07 3:03 ` [LKP] [blkcg] c02c58dab2: WARNING:at_block/blk-throttle.c:#blk_throtl_bio kernel test robot
2018-08-31 1:53 ` [PATCH 07/15] blkcg: consolidate bio_issue_init and blkg association Dennis Zhou
2018-08-31 9:19 ` kbuild test robot
2018-08-31 11:11 ` kbuild test robot
2018-08-31 15:42 ` Josef Bacik
2018-09-06 20:43 ` Dennis Zhou
2018-08-31 23:45 ` Tejun Heo
2018-08-31 1:53 ` [PATCH 08/15] blkcg: associate a blkg for pages being evicted by swap Dennis Zhou
2018-08-31 15:44 ` Josef Bacik
2018-08-31 23:47 ` Tejun Heo
2018-08-31 1:53 ` [PATCH 09/15] blkcg: associate writeback bios with a blkg Dennis Zhou
2018-08-31 15:45 ` Josef Bacik
2018-08-31 23:53 ` Tejun Heo
2018-08-31 1:53 ` [PATCH 10/15] blkcg: remove bio->bi_css and instead use bio->bi_blkg Dennis Zhou
2018-08-31 15:46 ` Josef Bacik
2018-09-01 0:13 ` Tejun Heo
2018-08-31 1:53 ` [PATCH 11/15] blkcg: remove additional reference to the css Dennis Zhou
2018-09-01 0:26 ` Tejun Heo
2018-09-06 20:45 ` Dennis Zhou
2018-08-31 1:53 ` [PATCH 12/15] blkcg: cleanup and make blk_get_rl use blkg_lookup_create Dennis Zhou
2018-09-01 0:29 ` Tejun Heo
2018-09-11 2:37 ` [LKP] [blkcg] 22f657e287: general_protection_fault:#[##] kernel test robot
2018-08-31 1:53 ` [PATCH 13/15] blkcg: change blkg reference counting to use percpu_ref Dennis Zhou
2018-08-31 15:49 ` Josef Bacik
2018-09-01 0:31 ` Tejun Heo
2018-09-06 20:46 ` Dennis Zhou
2018-09-07 3:08 ` [LKP] [blkcg] 6ef69a3a0b: WARNING:suspicious_RCU_usage kernel test robot
2018-08-31 1:53 ` [PATCH 14/15] blkcg: rename blkg_try_get to blkg_tryget Dennis Zhou
2018-08-31 15:50 ` Josef Bacik
2018-09-01 0:32 ` Tejun Heo
2018-08-31 1:53 ` [PATCH 15/15] blkcg: add average latency tracking to blk-cgroup Dennis Zhou
2018-08-31 10:22 ` kbuild test robot
2018-08-31 11:38 ` kbuild test robot [this message]
2018-09-01 0:35 ` [PATCH 00/15] blkcg ref count refactor/cleanup + blkcg avg_lat Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201808311920.BT1iVxJW%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=dennisszhou@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=josef@toxicpanda.com \
--cc=kbuild-all@01.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).