* [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check
@ 2018-08-29 20:02 Rob Herring
2018-09-03 2:17 ` Shawn Guo
2018-09-03 4:21 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring @ 2018-08-29 20:02 UTC (permalink / raw)
To: Shawn Guo; +Cc: linux-kernel
Checking the child node names is pointless as the DT node name can
never be NULL, so remove it.
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
drivers/bus/imx-weim.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
index 6a94aa6a22c2..d84996a4528e 100644
--- a/drivers/bus/imx-weim.c
+++ b/drivers/bus/imx-weim.c
@@ -156,9 +156,6 @@ static int __init weim_parse_dt(struct platform_device *pdev,
}
for_each_available_child_of_node(pdev->dev.of_node, child) {
- if (!child->name)
- continue;
-
ret = weim_timing_setup(child, base, devtype);
if (ret)
dev_warn(&pdev->dev, "%pOF set timing failed.\n",
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check
2018-08-29 20:02 [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check Rob Herring
@ 2018-09-03 2:17 ` Shawn Guo
2018-09-03 4:21 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-09-03 2:17 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel
On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote:
> Checking the child node names is pointless as the DT node name can
> never be NULL, so remove it.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check
2018-08-29 20:02 [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check Rob Herring
2018-09-03 2:17 ` Shawn Guo
@ 2018-09-03 4:21 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2018-09-03 4:21 UTC (permalink / raw)
To: Rob Herring; +Cc: linux-kernel
On Wed, Aug 29, 2018 at 03:02:58PM -0500, Rob Herring wrote:
> Checking the child node names is pointless as the DT node name can
> never be NULL, so remove it.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-03 4:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 20:02 [PATCH] bus: imx-weim: drop unnecessary DT node name NULL check Rob Herring
2018-09-03 2:17 ` Shawn Guo
2018-09-03 4:21 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).