From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: kgunda@codeaurora.org
Cc: jingoohan1@gmail.com, lee.jones@linaro.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
daniel.thompson@linaro.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998
Date: Mon, 3 Sep 2018 11:55:10 -0700 [thread overview]
Message-ID: <20180903185510.GB3153@tuxbook-pro> (raw)
In-Reply-To: <897ab82c450bff71658c1fa32e7e6021@codeaurora.org>
On Wed 15 Aug 22:23 PDT 2018, kgunda@codeaurora.org wrote:
> On 2018-08-07 10:53, Bjorn Andersson wrote:
> > On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote:
> > > diff --git
> > > a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > > b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt
> > [..]
> > > - qcom,num-strings
> > > Usage: optional
> > > Value type: <u32>
> > > Definition: #; number of led strings attached;
> > > - value from 1 to 3. default: 2
> > > - This property is supported only for PM8941.
> > > + value: For PM8941 from 1 to 3.
> > > + For PMI8998 from 1 to 4.
> > [..]
> > > +- qcom,enabled-strings
> > > + Usage: optional
> > > + Value tyoe: <u32 array>
> > > + Definition: Array of the WLED strings numbered from 0 to 3. Each
> > > + string of leds are operated individually. Specify the
> > > + list of strings used by the device. Any combination of
> > > + led strings can be used.
> > [..]
> > >
> > > Example:
> > >
> > > @@ -99,4 +146,5 @@ pm8941-wled@d800 {
> > > qcom,switching-freq = <1600>;
> > > qcom,ovp = <29>;
> > > qcom,num-strings = <2>;
> > > + qcom,enabled-strings = <0x00 0x01>;
> >
> > Nit. I would assume that specifying qcom,num-strings = <2> implies that
> > the first 2 strings are used, so one would not also specify
> > qcom,enabled-strings.
> >
> Thanks Bjorn for reviewing the series !
>
> "qcom,enabled-strings" need be specified along with the "qcom,num-strings".
> Because the enabled-strings can be <0, 2> or <0, 3 > also. The driver picks
> the string
> configuration from the enabled-strings array and enable only those
> current-sinks.
>
The original binding described qcom,num-strings to mean "the first N
strings", requiring qcom,enabled-strings now would break backwards
compatibility with this binding.
In the case that qcom,enabled-strings is specified we can easily derive
num-strings from the listed entires. So I would suggest that you look
for enabled-strings and if not found fall back to checking for
num-strings.
Regards,
Bjorn
next prev parent reply other threads:[~2018-09-03 18:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 10:22 [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 2/8] backlight: qcom-wled: restructure the qcom-wled bindings Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998 Kiran Gunda
2018-07-11 15:12 ` Rob Herring
2018-07-20 13:15 ` Daniel Thompson
2018-08-07 5:23 ` Bjorn Andersson
2018-08-16 5:23 ` kgunda
2018-09-03 18:55 ` Bjorn Andersson [this message]
2018-09-26 5:31 ` kgunda
2018-07-09 10:22 ` [PATCH V4 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2018-07-20 13:23 ` Daniel Thompson
2018-07-23 5:55 ` kgunda
2018-08-07 5:41 ` Bjorn Andersson
2018-08-16 5:30 ` kgunda
2018-07-09 10:22 ` [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2018-07-20 13:40 ` Daniel Thompson
2018-08-07 5:37 ` Bjorn Andersson
2018-08-16 5:28 ` kgunda
2018-07-09 10:22 ` [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-07-20 13:47 ` Daniel Thompson
2018-07-20 21:21 ` Pavel Machek
2018-07-23 6:16 ` kgunda
2018-08-07 5:45 ` Bjorn Andersson
2018-07-09 10:22 ` [PATCH V4 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2018-07-20 14:07 ` Daniel Thompson
2018-07-23 6:05 ` kgunda
2018-07-09 10:22 ` [PATCH V4 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-08-07 6:32 ` Bjorn Andersson
2018-08-16 5:33 ` kgunda
2018-08-03 7:19 ` [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver kgunda
2018-08-03 7:45 ` Daniel Thompson
2018-08-06 10:58 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903185510.GB3153@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).