From: kgunda@codeaurora.org
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: jingoohan1@gmail.com, lee.jones@linaro.org,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
daniel.thompson@linaro.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3
Date: Thu, 16 Aug 2018 10:58:51 +0530 [thread overview]
Message-ID: <53030a892f6cd69a8e58188ff1a60f36@codeaurora.org> (raw)
In-Reply-To: <20180807053705.GB23866@tuxbook-pro>
On 2018-08-07 11:07, Bjorn Andersson wrote:
> On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote:
>> diff --git a/drivers/video/backlight/qcom-wled.c
>> b/drivers/video/backlight/qcom-wled.c
> [..]
>> @@ -365,6 +434,15 @@ static int wled_configure(struct wled *wled,
>> struct device *dev)
>>
>> cfg->num_strings = cfg->num_strings + 1;
>>
>> + string_len = of_property_count_elems_of_size(dev->of_node,
>> + "qcom,enabled-strings",
>> + sizeof(u32));
>> + if (string_len > 0)
>> + rc = of_property_read_u32_array(dev->of_node,
>> + "qcom,enabled-strings",
>> + wled->cfg.enabled_strings,
>
> qcom,enabled-strings is listed as optional, but without it we will end
> up with qcom,num-strings zeros in an array. Initialize
> wled->cfg.enabled_strings to 0,1,2,3 and the driver will be backwards
> compatible.
>
Correct. I will initialize the array in the next series.
> I also think that if you do qcom,enabled-strings = <0, 1, 2>; there's
> no
> need to also specify qcom,num-strings = <3>; and we can just use
> string_len for num_strings.
Correct. But I have kept this property to have the backward
compatibility with the
old driver (WLED3).
>
>> + sizeof(u32));
>> +
>> return 0;
>> }
>
> Regards,
> Bjorn
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-08-16 5:28 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 10:22 [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 2/8] backlight: qcom-wled: restructure the qcom-wled bindings Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998 Kiran Gunda
2018-07-11 15:12 ` Rob Herring
2018-07-20 13:15 ` Daniel Thompson
2018-08-07 5:23 ` Bjorn Andersson
2018-08-16 5:23 ` kgunda
2018-09-03 18:55 ` Bjorn Andersson
2018-09-26 5:31 ` kgunda
2018-07-09 10:22 ` [PATCH V4 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2018-07-20 13:23 ` Daniel Thompson
2018-07-23 5:55 ` kgunda
2018-08-07 5:41 ` Bjorn Andersson
2018-08-16 5:30 ` kgunda
2018-07-09 10:22 ` [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2018-07-20 13:40 ` Daniel Thompson
2018-08-07 5:37 ` Bjorn Andersson
2018-08-16 5:28 ` kgunda [this message]
2018-07-09 10:22 ` [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-07-20 13:47 ` Daniel Thompson
2018-07-20 21:21 ` Pavel Machek
2018-07-23 6:16 ` kgunda
2018-08-07 5:45 ` Bjorn Andersson
2018-07-09 10:22 ` [PATCH V4 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2018-07-20 14:07 ` Daniel Thompson
2018-07-23 6:05 ` kgunda
2018-07-09 10:22 ` [PATCH V4 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-08-07 6:32 ` Bjorn Andersson
2018-08-16 5:33 ` kgunda
2018-08-03 7:19 ` [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver kgunda
2018-08-03 7:45 ` Daniel Thompson
2018-08-06 10:58 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53030a892f6cd69a8e58188ff1a60f36@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).