* [PATCH] nds32: linker script: GCOV kernel may refers data in __exit
@ 2018-09-04 7:54 Greentime Hu
2018-09-04 9:21 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Greentime Hu @ 2018-09-04 7:54 UTC (permalink / raw)
To: greentime, linux-kernel, arnd, mhiramat
This patch is used to fix nds32 allmodconfig/allyesconfig build error
because GCOV kernel embeds counters in the kernel for each line
and a part of that embed in __exit text. So we need to keep the
EXIT_TEXT and EXIT_DATA if CONFIG_GCOV_KERNEL=y.
Link: https://lkml.org/lkml/2018/9/1/125
Signed-off-by: Greentime Hu <greentime@andestech.com>
---
arch/nds32/kernel/vmlinux.lds.S | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/nds32/kernel/vmlinux.lds.S b/arch/nds32/kernel/vmlinux.lds.S
index 288313b886ef..9e90f30a181d 100644
--- a/arch/nds32/kernel/vmlinux.lds.S
+++ b/arch/nds32/kernel/vmlinux.lds.S
@@ -13,14 +13,26 @@ OUTPUT_ARCH(nds32)
ENTRY(_stext_lma)
jiffies = jiffies_64;
+#if defined(CONFIG_GCOV_KERNEL)
+#define NDS32_EXIT_KEEP(x) x
+#else
+#define NDS32_EXIT_KEEP(x)
+#endif
+
SECTIONS
{
_stext_lma = TEXTADDR - LOAD_OFFSET;
. = TEXTADDR;
__init_begin = .;
HEAD_TEXT_SECTION
+ .exit.text : {
+ NDS32_EXIT_KEEP(EXIT_TEXT)
+ }
INIT_TEXT_SECTION(PAGE_SIZE)
INIT_DATA_SECTION(16)
+ .exit.data : {
+ NDS32_EXIT_KEEP(EXIT_DATA)
+ }
PERCPU_SECTION(L1_CACHE_BYTES)
__init_end = .;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nds32: linker script: GCOV kernel may refers data in __exit
2018-09-04 7:54 [PATCH] nds32: linker script: GCOV kernel may refers data in __exit Greentime Hu
@ 2018-09-04 9:21 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2018-09-04 9:21 UTC (permalink / raw)
To: Greentime Hu; +Cc: greentime, linux-kernel, arnd
On Tue, 4 Sep 2018 15:54:19 +0800
Greentime Hu <green.hu@gmail.com> wrote:
> This patch is used to fix nds32 allmodconfig/allyesconfig build error
> because GCOV kernel embeds counters in the kernel for each line
> and a part of that embed in __exit text. So we need to keep the
> EXIT_TEXT and EXIT_DATA if CONFIG_GCOV_KERNEL=y.
Yes, that is exactly what I did for arm.
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
>
> Link: https://lkml.org/lkml/2018/9/1/125
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> ---
> arch/nds32/kernel/vmlinux.lds.S | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/nds32/kernel/vmlinux.lds.S b/arch/nds32/kernel/vmlinux.lds.S
> index 288313b886ef..9e90f30a181d 100644
> --- a/arch/nds32/kernel/vmlinux.lds.S
> +++ b/arch/nds32/kernel/vmlinux.lds.S
> @@ -13,14 +13,26 @@ OUTPUT_ARCH(nds32)
> ENTRY(_stext_lma)
> jiffies = jiffies_64;
>
> +#if defined(CONFIG_GCOV_KERNEL)
> +#define NDS32_EXIT_KEEP(x) x
> +#else
> +#define NDS32_EXIT_KEEP(x)
> +#endif
> +
> SECTIONS
> {
> _stext_lma = TEXTADDR - LOAD_OFFSET;
> . = TEXTADDR;
> __init_begin = .;
> HEAD_TEXT_SECTION
> + .exit.text : {
> + NDS32_EXIT_KEEP(EXIT_TEXT)
> + }
> INIT_TEXT_SECTION(PAGE_SIZE)
> INIT_DATA_SECTION(16)
> + .exit.data : {
> + NDS32_EXIT_KEEP(EXIT_DATA)
> + }
> PERCPU_SECTION(L1_CACHE_BYTES)
> __init_end = .;
>
> --
> 2.18.0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-04 9:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-04 7:54 [PATCH] nds32: linker script: GCOV kernel may refers data in __exit Greentime Hu
2018-09-04 9:21 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).