* [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered
@ 2018-09-04 18:35 Colin King
2018-09-05 9:16 ` Charles Keepax
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-09-04 18:35 UTC (permalink / raw)
To: Charles Keepax, Robert Jarzmik, Mark Brown,
Mauro Carvalho Chehab, patches, linux-input
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
In the case where IS_BUILTIN(CONFIG_AC97_BUS)) is not true, the
wm97xx_driver driver is being unregistered even it has not been
previously registered. Fix this by only unregistering it if
IS_BUILTIN(CONFIG_AC97_BUS)) is true. This fixes the warning
message:
[ 834.111248] ------------[ cut here ]------------
[ 834.111248] Unexpected driver unregister!
[ 834.111319] WARNING: CPU: 2 PID: 11749 at drivers/base/driver.c:193 driver_unregister+0x3b/0x40
[ 834.111319] Modules linked in: wm97xx_ts(-) ....
..and a stack trace.
To easily reproduce this, load and unload the module on a system where
the hardware is not supported.
Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/input/touchscreen/wm97xx-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c
index 2566b4d8b342..73856c2a8ac0 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -929,7 +929,8 @@ static int __init wm97xx_init(void)
static void __exit wm97xx_exit(void)
{
- driver_unregister(&wm97xx_driver);
+ if (IS_BUILTIN(CONFIG_AC97_BUS))
+ driver_unregister(&wm97xx_driver);
platform_driver_unregister(&wm97xx_mfd_driver);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered
2018-09-04 18:35 [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered Colin King
@ 2018-09-05 9:16 ` Charles Keepax
2018-09-09 19:08 ` Robert Jarzmik
0 siblings, 1 reply; 3+ messages in thread
From: Charles Keepax @ 2018-09-05 9:16 UTC (permalink / raw)
To: Colin King
Cc: Charles Keepax, Robert Jarzmik, Mark Brown,
Mauro Carvalho Chehab, patches, linux-input, kernel-janitors,
linux-kernel
On Tue, Sep 04, 2018 at 07:35:05PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where IS_BUILTIN(CONFIG_AC97_BUS)) is not true, the
> wm97xx_driver driver is being unregistered even it has not been
> previously registered. Fix this by only unregistering it if
> IS_BUILTIN(CONFIG_AC97_BUS)) is true. This fixes the warning
> message:
>
> [ 834.111248] ------------[ cut here ]------------
> [ 834.111248] Unexpected driver unregister!
> [ 834.111319] WARNING: CPU: 2 PID: 11749 at drivers/base/driver.c:193 driver_unregister+0x3b/0x40
> [ 834.111319] Modules linked in: wm97xx_ts(-) ....
>
> ..and a stack trace.
>
> To easily reproduce this, load and unload the module on a system where
> the hardware is not supported.
>
> Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered
2018-09-05 9:16 ` Charles Keepax
@ 2018-09-09 19:08 ` Robert Jarzmik
0 siblings, 0 replies; 3+ messages in thread
From: Robert Jarzmik @ 2018-09-09 19:08 UTC (permalink / raw)
To: Charles Keepax
Cc: Colin King, Charles Keepax, Mark Brown, Mauro Carvalho Chehab,
patches, linux-input, kernel-janitors, linux-kernel
Charles Keepax <ckeepax@opensource.cirrus.com> writes:
> On Tue, Sep 04, 2018 at 07:35:05PM +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> In the case where IS_BUILTIN(CONFIG_AC97_BUS)) is not true, the
>> wm97xx_driver driver is being unregistered even it has not been
>> previously registered. Fix this by only unregistering it if
>> IS_BUILTIN(CONFIG_AC97_BUS)) is true. This fixes the warning
>> message:
>>
>> [ 834.111248] ------------[ cut here ]------------
>> [ 834.111248] Unexpected driver unregister!
>> [ 834.111319] WARNING: CPU: 2 PID: 11749 at drivers/base/driver.c:193 driver_unregister+0x3b/0x40
>> [ 834.111319] Modules linked in: wm97xx_ts(-) ....
>>
>> ..and a stack trace.
>>
>> To easily reproduce this, load and unload the module on a system where
>> the hardware is not supported.
>>
>> Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-09 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-04 18:35 [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered Colin King
2018-09-05 9:16 ` Charles Keepax
2018-09-09 19:08 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).