* [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328
@ 2018-09-06 16:39 Katsuhiro Suzuki
2018-09-10 13:57 ` Heiko Stuebner
0 siblings, 1 reply; 3+ messages in thread
From: Katsuhiro Suzuki @ 2018-09-06 16:39 UTC (permalink / raw)
To: Heiko Stuebner, linux-rockchip
Cc: linux-arm-kernel, linux-kernel, Katsuhiro Suzuki
This patch adds port and endpoint of i2s and spdif nodes for rk3328.
Because to use modern sound card interface such as audio-graph-card.
Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
index d3ef6566325e..41f0a20b73ed 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
@@ -179,7 +179,13 @@
clock-names = "i2s_clk", "i2s_hclk";
dmas = <&dmac 11>, <&dmac 12>;
dma-names = "tx", "rx";
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ i2s0_p0: port@0 {
+ i2s0_p0_0: endpoint {
+ };
+ };
};
i2s1: i2s@ff010000 {
@@ -190,7 +196,13 @@
clock-names = "i2s_clk", "i2s_hclk";
dmas = <&dmac 14>, <&dmac 15>;
dma-names = "tx", "rx";
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ i2s1_p0: port@0 {
+ i2s1_p0_0: endpoint {
+ };
+ };
};
i2s2: i2s@ff020000 {
@@ -201,7 +213,13 @@
clock-names = "i2s_clk", "i2s_hclk";
dmas = <&dmac 0>, <&dmac 1>;
dma-names = "tx", "rx";
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ i2s2_p0: port@0 {
+ i2s2_p0_0: endpoint {
+ };
+ };
};
spdif: spdif@ff030000 {
@@ -214,7 +232,13 @@
dma-names = "tx";
pinctrl-names = "default";
pinctrl-0 = <&spdifm2_tx>;
+ #sound-dai-cells = <0>;
status = "disabled";
+
+ spdif_p0: port@0 {
+ spdif_p0_0: endpoint {
+ };
+ };
};
pdm: pdm@ff040000 {
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328
2018-09-06 16:39 [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328 Katsuhiro Suzuki
@ 2018-09-10 13:57 ` Heiko Stuebner
2018-09-10 16:07 ` Katsuhiro Suzuki
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2018-09-10 13:57 UTC (permalink / raw)
To: Katsuhiro Suzuki; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel
Hi,
Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki:
> This patch adds port and endpoint of i2s and spdif nodes for rk3328.
> Because to use modern sound card interface such as audio-graph-card.
>
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> ---
> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> index d3ef6566325e..41f0a20b73ed 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
> @@ -179,7 +179,13 @@
> clock-names = "i2s_clk", "i2s_hclk";
> dmas = <&dmac 11>, <&dmac 12>;
> dma-names = "tx", "rx";
> + #sound-dai-cells = <0>;
> status = "disabled";
> +
> + i2s0_p0: port@0 {
there is only one port per device, so this should probably be
i2s0_p0: port {
without the address. Same for all others.
The of-graph framework should work just fine then as well.
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328
2018-09-10 13:57 ` Heiko Stuebner
@ 2018-09-10 16:07 ` Katsuhiro Suzuki
0 siblings, 0 replies; 3+ messages in thread
From: Katsuhiro Suzuki @ 2018-09-10 16:07 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip, linux-arm-kernel, linux-kernel
Hi Heiko,
On 2018年09月10日 22:57, Heiko Stuebner wrote:
> Hi,
>
> Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki:
>> This patch adds port and endpoint of i2s and spdif nodes for rk3328.
>> Because to use modern sound card interface such as audio-graph-card.
>>
>> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> index d3ef6566325e..41f0a20b73ed 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi
>> @@ -179,7 +179,13 @@
>> clock-names = "i2s_clk", "i2s_hclk";
>> dmas = <&dmac 11>, <&dmac 12>;
>> dma-names = "tx", "rx";
>> + #sound-dai-cells = <0>;
>> status = "disabled";
>> +
>> + i2s0_p0: port@0 {
>
> there is only one port per device, so this should probably be
> i2s0_p0: port {
> without the address. Same for all others.
> The of-graph framework should work just fine then as well.
Thanks, indeed. I'll fix and send v2.
>
> Heiko
>
>
>
Regards,
--
Katsuhiro Suzuki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-10 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-06 16:39 [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328 Katsuhiro Suzuki
2018-09-10 13:57 ` Heiko Stuebner
2018-09-10 16:07 ` Katsuhiro Suzuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).