* [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
@ 2018-09-07 0:27 Grant Grundler
2018-09-07 3:15 ` Benson Leung
2018-09-07 12:11 ` Mark Brown
0 siblings, 2 replies; 6+ messages in thread
From: Grant Grundler @ 2018-09-07 0:27 UTC (permalink / raw)
To: Mark Brown, Ryan Lee
Cc: Liam Girdwood, Kuninori Morimoto, alsa-devel, linux-kernel,
Grant Grundler
Commit ca917f9fe1a0fab added use of usleep_range() but not
the corresponding "include <linux/delay.h>". The result is
with Chrome OS won't build because warnings are forced
to be errors:
mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function 'usleep_range' [-Werror,-Wimplicit-function-declaration]
usleep_range(10000, 11000);
^
Including delay.h "fixes" this.
Signed-off-by: Grant Grundler <grundler@chromium.org>
---
sound/soc/codecs/max98373.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/max98373.c b/sound/soc/codecs/max98373.c
index 92b7125ea169..1f97b2f7c851 100644
--- a/sound/soc/codecs/max98373.c
+++ b/sound/soc/codecs/max98373.c
@@ -2,6 +2,7 @@
// Copyright (c) 2017, Maxim Integrated
#include <linux/acpi.h>
+#include <linux/delay.h>
#include <linux/i2c.h>
#include <linux/module.h>
#include <linux/regmap.h>
--
2.19.0.rc2.392.g5ba43deb5a-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
2018-09-07 0:27 [PATCH] ASoC: max98373: usleep_range() needs include/delay.h Grant Grundler
@ 2018-09-07 3:15 ` Benson Leung
2018-09-07 12:11 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Benson Leung @ 2018-09-07 3:15 UTC (permalink / raw)
To: Grant Grundler
Cc: Mark Brown, Ryan Lee, Liam Girdwood, Kuninori Morimoto,
alsa-devel, linux-kernel, bleung
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi Grant,
On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
> Commit ca917f9fe1a0fab added use of usleep_range() but not
> the corresponding "include <linux/delay.h>". The result is
> with Chrome OS won't build because warnings are forced
> to be errors:
> mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function 'usleep_range' [-Werror,-Wimplicit-function-declaration]
> usleep_range(10000, 11000);
> ^
>
> Including delay.h "fixes" this.
>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
2018-09-07 0:27 [PATCH] ASoC: max98373: usleep_range() needs include/delay.h Grant Grundler
2018-09-07 3:15 ` Benson Leung
@ 2018-09-07 12:11 ` Mark Brown
[not found] ` <CANEJEGv0A8LO1znHToYOkddzr_JmHpogvYewVrMpK+ZB6SJX5w@mail.gmail.com>
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2018-09-07 12:11 UTC (permalink / raw)
To: Grant Grundler
Cc: Ryan Lee, Liam Girdwood, Kuninori Morimoto, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
> Commit ca917f9fe1a0fab added use of usleep_range() but not
> the corresponding "include <linux/delay.h>". The result is
> with Chrome OS won't build because warnings are forced
> to be errors:
> mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function 'usleep_range' [-Werror,-Wimplicit-function-declaration]
> usleep_range(10000, 11000);
> ^
Note that this isn't causing a warning upstream, presumably due to an
implicit inclusion that isn't present in the v4.4 kernel that you appear
to be using, or gets missed due to config differences.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
[not found] ` <CANEJEGv0A8LO1znHToYOkddzr_JmHpogvYewVrMpK+ZB6SJX5w@mail.gmail.com>
@ 2018-09-07 17:54 ` Grant Grundler
2018-09-07 17:56 ` Mark Brown
1 sibling, 0 replies; 6+ messages in thread
From: Grant Grundler @ 2018-09-07 17:54 UTC (permalink / raw)
To: Grant Grundler
Cc: broonie, ryans.lee, lgirdwood, kuninori.morimoto.gx, alsa-devel, LKML
[resending as plain/text - sorry]
On Fri, Sep 7, 2018 at 10:52 AM Grant Grundler <grundler@chromium.org> wrote:
>
>
>
> On Fri, Sep 7, 2018 at 5:11 AM Mark Brown <broonie@kernel.org> wrote:
>>
>> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
>> > Commit ca917f9fe1a0fab added use of usleep_range() but not
>> > the corresponding "include <linux/delay.h>". The result is
>> > with Chrome OS won't build because warnings are forced
>> > to be errors:
>> > mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2: error: implicit declaration of function 'usleep_range' [-Werror,-Wimplicit-function-declaration]
>> > usleep_range(10000, 11000);
>> > ^
>>
>> Note that this isn't causing a warning upstream, presumably due to an
>> implicit inclusion that isn't present in the v4.4 kernel that you appear
>> to be using, or gets missed due to config differences.
>
>
> Ok. Is this just an observation or are these reasons to not accept the change?
>
> cheers,
> grant
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
[not found] ` <CANEJEGv0A8LO1znHToYOkddzr_JmHpogvYewVrMpK+ZB6SJX5w@mail.gmail.com>
2018-09-07 17:54 ` Grant Grundler
@ 2018-09-07 17:56 ` Mark Brown
2018-09-07 19:28 ` Grant Grundler
1 sibling, 1 reply; 6+ messages in thread
From: Mark Brown @ 2018-09-07 17:56 UTC (permalink / raw)
To: Grant Grundler
Cc: ryans.lee, lgirdwood, kuninori.morimoto.gx, alsa-devel, LKML
[-- Attachment #1: Type: text/plain, Size: 516 bytes --]
On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote:
> On Fri, Sep 7, 2018 at 5:11 AM Mark Brown <broonie@kernel.org> wrote:
> > Note that this isn't causing a warning upstream, presumably due to an
> > implicit inclusion that isn't present in the v4.4 kernel that you appear
> > to be using, or gets missed due to config differences.
> Ok. Is this just an observation or are these reasons to not accept the
> change?
An observation, you should already have a mail about it being applied.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: max98373: usleep_range() needs include/delay.h
2018-09-07 17:56 ` Mark Brown
@ 2018-09-07 19:28 ` Grant Grundler
0 siblings, 0 replies; 6+ messages in thread
From: Grant Grundler @ 2018-09-07 19:28 UTC (permalink / raw)
To: broonie
Cc: Grant Grundler, ryans.lee, lgirdwood, kuninori.morimoto.gx,
alsa-devel, LKML
On Fri, Sep 7, 2018 at 10:56 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Sep 07, 2018 at 10:52:24AM -0700, Grant Grundler wrote:
> > On Fri, Sep 7, 2018 at 5:11 AM Mark Brown <broonie@kernel.org> wrote:
>
> > > Note that this isn't causing a warning upstream, presumably due to an
> > > implicit inclusion that isn't present in the v4.4 kernel that you appear
> > > to be using, or gets missed due to config differences.
>
> > Ok. Is this just an observation or are these reasons to not accept the
> > change?
>
> An observation, you should already have a mail about it being applied.
Ah ok! Thanks for pointing that out (and for reviewing/accepting the patch).
cheers,
grant
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-07 19:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 0:27 [PATCH] ASoC: max98373: usleep_range() needs include/delay.h Grant Grundler
2018-09-07 3:15 ` Benson Leung
2018-09-07 12:11 ` Mark Brown
[not found] ` <CANEJEGv0A8LO1znHToYOkddzr_JmHpogvYewVrMpK+ZB6SJX5w@mail.gmail.com>
2018-09-07 17:54 ` Grant Grundler
2018-09-07 17:56 ` Mark Brown
2018-09-07 19:28 ` Grant Grundler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).