* [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute
@ 2018-09-10 16:39 Katsuhiro Suzuki
2018-09-11 18:21 ` Applied "ASoC: rockchip: add missing INTERLEAVED PCM attribute" to the asoc tree Mark Brown
2019-04-23 22:26 ` [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Doug Anderson
0 siblings, 2 replies; 6+ messages in thread
From: Katsuhiro Suzuki @ 2018-09-10 16:39 UTC (permalink / raw)
To: Mark Brown, Heiko Stuebner, alsa-devel, linux-rockchip
Cc: linux-arm-kernel, linux-kernel, Katsuhiro Suzuki
This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info.
Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
---
sound/soc/rockchip/rockchip_pcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/rockchip/rockchip_pcm.c b/sound/soc/rockchip/rockchip_pcm.c
index f77538319221..9e7b5fa4cf59 100644
--- a/sound/soc/rockchip/rockchip_pcm.c
+++ b/sound/soc/rockchip/rockchip_pcm.c
@@ -21,7 +21,8 @@ static const struct snd_pcm_hardware snd_rockchip_hardware = {
.info = SNDRV_PCM_INFO_MMAP |
SNDRV_PCM_INFO_MMAP_VALID |
SNDRV_PCM_INFO_PAUSE |
- SNDRV_PCM_INFO_RESUME,
+ SNDRV_PCM_INFO_RESUME |
+ SNDRV_PCM_INFO_INTERLEAVED,
.period_bytes_min = 32,
.period_bytes_max = 8192,
.periods_min = 1,
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Applied "ASoC: rockchip: add missing INTERLEAVED PCM attribute" to the asoc tree
2018-09-10 16:39 [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Katsuhiro Suzuki
@ 2018-09-11 18:21 ` Mark Brown
2019-04-23 22:26 ` [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Doug Anderson
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2018-09-11 18:21 UTC (permalink / raw)
To: Katsuhiro Suzuki
Cc: Mark Brown, Mark Brown, Heiko Stuebner, alsa-devel,
linux-rockchip, linux-kernel, linux-arm-kernel, alsa-devel
The patch
ASoC: rockchip: add missing INTERLEAVED PCM attribute
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 24d6638302b48328a58c13439276d4531af4ca7d Mon Sep 17 00:00:00 2001
From: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Date: Tue, 11 Sep 2018 01:39:32 +0900
Subject: [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute
This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info.
Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/rockchip/rockchip_pcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/rockchip/rockchip_pcm.c b/sound/soc/rockchip/rockchip_pcm.c
index f77538319221..9e7b5fa4cf59 100644
--- a/sound/soc/rockchip/rockchip_pcm.c
+++ b/sound/soc/rockchip/rockchip_pcm.c
@@ -21,7 +21,8 @@ static const struct snd_pcm_hardware snd_rockchip_hardware = {
.info = SNDRV_PCM_INFO_MMAP |
SNDRV_PCM_INFO_MMAP_VALID |
SNDRV_PCM_INFO_PAUSE |
- SNDRV_PCM_INFO_RESUME,
+ SNDRV_PCM_INFO_RESUME |
+ SNDRV_PCM_INFO_INTERLEAVED,
.period_bytes_min = 32,
.period_bytes_max = 8192,
.periods_min = 1,
--
2.19.0.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute
2018-09-10 16:39 [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Katsuhiro Suzuki
2018-09-11 18:21 ` Applied "ASoC: rockchip: add missing INTERLEAVED PCM attribute" to the asoc tree Mark Brown
@ 2019-04-23 22:26 ` Doug Anderson
2019-04-24 13:45 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Doug Anderson @ 2019-04-23 22:26 UTC (permalink / raw)
To: stable
Cc: Katsuhiro Suzuki, LKML, Linux ARM, open list:ARM/Rockchip SoC...,
ALSA Development Mailing List, Heiko Stuebner, Mark Brown,
Urja Rannikko
Hi,
On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote:
>
> This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info.
>
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> ---
> sound/soc/rockchip/rockchip_pcm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
I just tracked down that audio was broken on 4.19 and needs this
change to work. Stable: can you please pick it? Specifically I
believe you'd want to treat it as if it had:
Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip
dmaengine pcm register")
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute
2019-04-23 22:26 ` [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Doug Anderson
@ 2019-04-24 13:45 ` Greg KH
2019-04-24 13:53 ` Heiko Stuebner
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2019-04-24 13:45 UTC (permalink / raw)
To: Doug Anderson
Cc: stable, Katsuhiro Suzuki, LKML, Linux ARM,
open list:ARM/Rockchip SoC...,
ALSA Development Mailing List, Heiko Stuebner, Mark Brown,
Urja Rannikko
On Tue, Apr 23, 2019 at 03:26:42PM -0700, Doug Anderson wrote:
> Hi,
>
> On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote:
> >
> > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info.
> >
> > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> > ---
> > sound/soc/rockchip/rockchip_pcm.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> I just tracked down that audio was broken on 4.19 and needs this
> change to work. Stable: can you please pick it? Specifically I
> believe you'd want to treat it as if it had:
>
> Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip
> dmaengine pcm register")
What is the git commit id of this patch in Linus's tree?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute
2019-04-24 13:45 ` Greg KH
@ 2019-04-24 13:53 ` Heiko Stuebner
2019-04-24 14:07 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2019-04-24 13:53 UTC (permalink / raw)
To: Greg KH
Cc: Doug Anderson, stable, Katsuhiro Suzuki, LKML, Linux ARM,
open list:ARM/Rockchip SoC...,
ALSA Development Mailing List, Mark Brown, Urja Rannikko
Am Mittwoch, 24. April 2019, 15:45:36 CEST schrieb Greg KH:
> On Tue, Apr 23, 2019 at 03:26:42PM -0700, Doug Anderson wrote:
> > Hi,
> >
> > On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote:
> > >
> > > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info.
> > >
> > > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> > > ---
> > > sound/soc/rockchip/rockchip_pcm.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > I just tracked down that audio was broken on 4.19 and needs this
> > change to work. Stable: can you please pick it? Specifically I
> > believe you'd want to treat it as if it had:
> >
> > Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip
> > dmaengine pcm register")
>
> What is the git commit id of this patch in Linus's tree?
Commit id is 24d6638302b48328a58c13439276d4531af4ca7d [0]
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=24d6638302b48328a58c13439276d4531af4ca7d
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute
2019-04-24 13:53 ` Heiko Stuebner
@ 2019-04-24 14:07 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2019-04-24 14:07 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Doug Anderson, stable, Katsuhiro Suzuki, LKML, Linux ARM,
open list:ARM/Rockchip SoC...,
ALSA Development Mailing List, Mark Brown, Urja Rannikko
On Wed, Apr 24, 2019 at 03:53:54PM +0200, Heiko Stuebner wrote:
> Am Mittwoch, 24. April 2019, 15:45:36 CEST schrieb Greg KH:
> > On Tue, Apr 23, 2019 at 03:26:42PM -0700, Doug Anderson wrote:
> > > Hi,
> > >
> > > On Sep 10, 2018 at 4:39 PM Katsuhiro Suzuki <katsuhiro@katsuster.net> wrote:
> > > >
> > > > This patch adds SNDRV_PCM_INFO_INTERLEAVED into PCM hardware info.
> > > >
> > > > Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
> > > > ---
> > > > sound/soc/rockchip/rockchip_pcm.c | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > I just tracked down that audio was broken on 4.19 and needs this
> > > change to work. Stable: can you please pick it? Specifically I
> > > believe you'd want to treat it as if it had:
> > >
> > > Fixes: 75b31192fe6a ("ASoC: rockchip: add config for rockchip
> > > dmaengine pcm register")
> >
> > What is the git commit id of this patch in Linus's tree?
>
> Commit id is 24d6638302b48328a58c13439276d4531af4ca7d [0]
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=24d6638302b48328a58c13439276d4531af4ca7d
Thanks, now queued up.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-24 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 16:39 [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Katsuhiro Suzuki
2018-09-11 18:21 ` Applied "ASoC: rockchip: add missing INTERLEAVED PCM attribute" to the asoc tree Mark Brown
2019-04-23 22:26 ` [alsa-devel] [PATCH] ASoC: rockchip: add missing INTERLEAVED PCM attribute Doug Anderson
2019-04-24 13:45 ` Greg KH
2019-04-24 13:53 ` Heiko Stuebner
2019-04-24 14:07 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).