* [PATCH net-next] net: dsa: b53: Only call b53_port_event() for SGMII ports
@ 2018-09-10 23:47 Florian Fainelli
2018-09-12 7:07 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2018-09-10 23:47 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Andrew Lunn, Vivien Didelot, David S. Miller,
open list
Built-in PHY ports are still being polled, avoid generating spurious
and duplicate events which the PHY library resolves through polling
anyways.
Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/b53/b53_srab.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c
index b0ed81876bae..321052732799 100644
--- a/drivers/net/dsa/b53/b53_srab.c
+++ b/drivers/net/dsa/b53/b53_srab.c
@@ -373,7 +373,8 @@ static irqreturn_t b53_srab_port_thread(int irq, void *dev_id)
struct b53_srab_port_priv *port = dev_id;
struct b53_device *dev = port->dev;
- b53_port_event(dev->ds, port->num);
+ if (port->mode == PHY_INTERFACE_MODE_SGMII)
+ b53_port_event(dev->ds, port->num);
return IRQ_HANDLED;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: dsa: b53: Only call b53_port_event() for SGMII ports
2018-09-10 23:47 [PATCH net-next] net: dsa: b53: Only call b53_port_event() for SGMII ports Florian Fainelli
@ 2018-09-12 7:07 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-12 7:07 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, vivien.didelot, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 10 Sep 2018 16:47:07 -0700
> Built-in PHY ports are still being polled, avoid generating spurious
> and duplicate events which the PHY library resolves through polling
> anyways.
>
> Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks Florian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-12 7:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 23:47 [PATCH net-next] net: dsa: b53: Only call b53_port_event() for SGMII ports Florian Fainelli
2018-09-12 7:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).