From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dou Liyang <douly.fnst@cn.fujitsu.com>,
Pavel Tatashin <pasha.tatashin@microsoft.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Revert "x86/tsc: Consolidate init code"
Date: Tue, 11 Sep 2018 15:16:35 +0300 [thread overview]
Message-ID: <20180911121635.GX5565@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1809101857510.1419@nanos.tec.linutronix.de>
On Mon, Sep 10, 2018 at 07:02:43PM +0200, Thomas Gleixner wrote:
> On Mon, 10 Sep 2018, Ville Syrjälä wrote:
> > On Mon, Sep 10, 2018 at 06:23:49PM +0200, Thomas Gleixner wrote:
> > > 1) My workflow makes things tagged as BUG and REGRESSION urgent
> > > automatically while [PATCH] just is queued to the normal pile of
> > > backlog, i.e. at the end. It just sprang into my eyes by chance, but in
> > > general you might just get the contrary of what you are looking for.
> >
> > Ah. Might be nice to document that somewhere. I might have to type up
> > that git-regression tool for myself, because I'm lazy.
>
> Well, it's probably different between maintainers, but it's common practice
> to have '[REGRESION] sub/sys got fubarred' in the subject.
>
> > > 2) A proper bug report with proper information (it's documented what should
> > > be provided), is way more worth than a patch with a mostly useless
> > > change log, which forces me to ask for the proper information instead of
> > > having it right away.
> >
> > I do agree that not having to ask for more information would be nice,
> > but hard to generalize because every subsystem needs different things.
> >
> > In this case you asked for the dmesg, which isn't even mentioned in
> > Documentation/admin-guide/reporting-bugs.rst as far as I can see.
> > So I'm not quite sure which documentation you're referring to here.
>
> I didn't look, but I expected dmesg to be part of it and a lot of people
> provide it as well as the start point of their bisection. Again, I had to
> do a shot into the dark and ask you whether it's fixed in -rc3. bisect
> start would have told me.
>
> So again. That revert patch habit does not make my life easier at all.
OK. I'll keep that in mind and try to stick REGRESSION format in the
future.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2018-09-11 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 12:19 [PATCH] Revert "x86/tsc: Consolidate init code" Ville Syrjala
2018-09-10 12:48 ` Thomas Gleixner
2018-09-10 13:19 ` Pasha Tatashin
2018-09-10 14:07 ` Ville Syrjälä
2018-09-10 14:47 ` Borislav Petkov
2018-09-10 15:09 ` Ville Syrjälä
2018-09-10 15:25 ` Borislav Petkov
2018-09-10 15:51 ` Ville Syrjälä
2018-09-10 16:06 ` Borislav Petkov
2018-09-10 16:23 ` Thomas Gleixner
2018-09-10 16:46 ` Ville Syrjälä
2018-09-10 17:02 ` Thomas Gleixner
2018-09-11 12:16 ` Ville Syrjälä [this message]
2018-09-10 16:53 ` Thomas Gleixner
2018-09-11 12:15 ` Ville Syrjälä
2018-09-11 20:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911121635.GX5565@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@microsoft.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).