From: Thomas Gleixner <tglx@linutronix.de>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dou Liyang <douly.fnst@cn.fujitsu.com>,
Pavel Tatashin <pasha.tatashin@microsoft.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] Revert "x86/tsc: Consolidate init code"
Date: Mon, 10 Sep 2018 14:48:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1809101443290.1292@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20180910121925.27682-1-ville.syrjala@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1131 bytes --]
Ville,
On Mon, 10 Sep 2018, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 608008a45798fe9e2aee04f99b5270ea57c1376f.
>
> It breaks wifi on my pentium 3 Fujitsu-Siemens Lifebook S6010
> laptop. Scanning for APs doesn't seem to work most of the time,
> and, even when it manages to find some APs it never manages to
> authenticate successfully. dmesg is just littered with:
> "wlan0: send auth to ... (try 1/3)
> wlan0: send auth to ... (try 2/3)
> wlan0: send auth to ... (try 3/3)
> wlan0: authentication with ... timed out"
I asked for that before and I really do not understand why you do not even
make an attempt to report an issue first and allow the developers to work
with you to figure out what exactly is the problem. All you do is to send
an revert patch with a changelog which describes symptoms and probably
breaks more than it cures. Not really helpful, really.
It's surely helpful to know that you bisected it to that commit and
reverting it helps. Can you please provide more detailes information like
dmesg of an good and a bad boot?
Thanks,
tglx
next prev parent reply other threads:[~2018-09-10 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 12:19 [PATCH] Revert "x86/tsc: Consolidate init code" Ville Syrjala
2018-09-10 12:48 ` Thomas Gleixner [this message]
2018-09-10 13:19 ` Pasha Tatashin
2018-09-10 14:07 ` Ville Syrjälä
2018-09-10 14:47 ` Borislav Petkov
2018-09-10 15:09 ` Ville Syrjälä
2018-09-10 15:25 ` Borislav Petkov
2018-09-10 15:51 ` Ville Syrjälä
2018-09-10 16:06 ` Borislav Petkov
2018-09-10 16:23 ` Thomas Gleixner
2018-09-10 16:46 ` Ville Syrjälä
2018-09-10 17:02 ` Thomas Gleixner
2018-09-11 12:16 ` Ville Syrjälä
2018-09-10 16:53 ` Thomas Gleixner
2018-09-11 12:15 ` Ville Syrjälä
2018-09-11 20:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1809101443290.1292@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@microsoft.com \
--cc=peterz@infradead.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).