* [PATCH] infiniband: remove redundant condition check before debugfs_remove
@ 2018-09-08 13:49 zhong jiang
2018-09-11 15:39 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-08 13:49 UTC (permalink / raw)
To: dledford, benve, jgg, linux-rdma, linux-kernel
debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
remove the unnecessary condition.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/infiniband/hw/usnic/usnic_debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/usnic/usnic_debugfs.c b/drivers/infiniband/hw/usnic/usnic_debugfs.c
index 92dc66c..a311570 100644
--- a/drivers/infiniband/hw/usnic/usnic_debugfs.c
+++ b/drivers/infiniband/hw/usnic/usnic_debugfs.c
@@ -165,6 +165,5 @@ void usnic_debugfs_flow_add(struct usnic_ib_qp_grp_flow *qp_flow)
void usnic_debugfs_flow_remove(struct usnic_ib_qp_grp_flow *qp_flow)
{
- if (!IS_ERR_OR_NULL(qp_flow->dbgfs_dentry))
- debugfs_remove(qp_flow->dbgfs_dentry);
+ debugfs_remove(qp_flow->dbgfs_dentry);
}
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] infiniband: remove redundant condition check before debugfs_remove
2018-09-08 13:49 [PATCH] infiniband: remove redundant condition check before debugfs_remove zhong jiang
@ 2018-09-11 15:39 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2018-09-11 15:39 UTC (permalink / raw)
To: zhong jiang; +Cc: dledford, benve, linux-rdma, linux-kernel
On Sat, Sep 08, 2018 at 09:49:31PM +0800, zhong jiang wrote:
> debugfs_remove has taken the IS_ERR_OR_NULL into account. Just
> remove the unnecessary condition.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> drivers/infiniband/hw/usnic/usnic_debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-11 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-08 13:49 [PATCH] infiniband: remove redundant condition check before debugfs_remove zhong jiang
2018-09-11 15:39 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).