linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition"
@ 2018-09-11 16:58 Colin King
  2018-09-12  4:58 ` Guenter Roeck
  0 siblings, 1 reply; 5+ messages in thread
From: Colin King @ 2018-09-11 16:58 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Guenter Roeck; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to spelling mistake in comment

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/firmware/google/vpd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index 1aa67bb5d8c0..c0c0b4e4e281 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -198,7 +198,7 @@ static int vpd_section_init(const char *name, struct vpd_section *sec,
 
 	sec->name = name;
 
-	/* We want to export the raw partion with name ${name}_raw */
+	/* We want to export the raw partition with name ${name}_raw */
 	sec->raw_name = kasprintf(GFP_KERNEL, "%s_raw", name);
 	if (!sec->raw_name) {
 		err = -ENOMEM;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition"
  2018-09-11 16:58 [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition" Colin King
@ 2018-09-12  4:58 ` Guenter Roeck
  2018-09-12  5:24   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2018-09-12  4:58 UTC (permalink / raw)
  To: Colin King, Greg Kroah-Hartman; +Cc: kernel-janitors, linux-kernel

On 09/11/2018 09:58 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake in comment
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Interesting - drivers/firmware/google/ does not have a maintainer.
Greg - is it correct to assume that you are the de-facto maintainer ?

Guenter

> ---
>   drivers/firmware/google/vpd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
> index 1aa67bb5d8c0..c0c0b4e4e281 100644
> --- a/drivers/firmware/google/vpd.c
> +++ b/drivers/firmware/google/vpd.c
> @@ -198,7 +198,7 @@ static int vpd_section_init(const char *name, struct vpd_section *sec,
>   
>   	sec->name = name;
>   
> -	/* We want to export the raw partion with name ${name}_raw */
> +	/* We want to export the raw partition with name ${name}_raw */
>   	sec->raw_name = kasprintf(GFP_KERNEL, "%s_raw", name);
>   	if (!sec->raw_name) {
>   		err = -ENOMEM;
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition"
  2018-09-12  4:58 ` Guenter Roeck
@ 2018-09-12  5:24   ` Greg Kroah-Hartman
  2018-09-12 21:10     ` Guenter Roeck
  0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-12  5:24 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Colin King, kernel-janitors, linux-kernel

On Tue, Sep 11, 2018 at 09:58:48PM -0700, Guenter Roeck wrote:
> On 09/11/2018 09:58 AM, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Trivial fix to spelling mistake in comment
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Interesting - drivers/firmware/google/ does not have a maintainer.
> Greg - is it correct to assume that you are the de-facto maintainer ?

Yeah, I am :(

I'll queue this up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition"
  2018-09-12  5:24   ` Greg Kroah-Hartman
@ 2018-09-12 21:10     ` Guenter Roeck
  2018-09-13 12:55       ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2018-09-12 21:10 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Colin King, kernel-janitors, linux-kernel

On Wed, Sep 12, 2018 at 07:24:48AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Sep 11, 2018 at 09:58:48PM -0700, Guenter Roeck wrote:
> > On 09/11/2018 09:58 AM, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > > 
> > > Trivial fix to spelling mistake in comment
> > > 
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > 
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > Interesting - drivers/firmware/google/ does not have a maintainer.
> > Greg - is it correct to assume that you are the de-facto maintainer ?
> 
> Yeah, I am :(
> 

Hmm .. the :( doesn't sound too happy. Do you think we should have one ?

Guenter

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition"
  2018-09-12 21:10     ` Guenter Roeck
@ 2018-09-13 12:55       ` Greg Kroah-Hartman
  0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-13 12:55 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Colin King, kernel-janitors, linux-kernel

On Wed, Sep 12, 2018 at 02:10:11PM -0700, Guenter Roeck wrote:
> On Wed, Sep 12, 2018 at 07:24:48AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Sep 11, 2018 at 09:58:48PM -0700, Guenter Roeck wrote:
> > > On 09/11/2018 09:58 AM, Colin King wrote:
> > > > From: Colin Ian King <colin.king@canonical.com>
> > > > 
> > > > Trivial fix to spelling mistake in comment
> > > > 
> > > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > 
> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> > > 
> > > Interesting - drivers/firmware/google/ does not have a maintainer.
> > > Greg - is it correct to assume that you are the de-facto maintainer ?
> > 
> > Yeah, I am :(
> > 
> 
> Hmm .. the :( doesn't sound too happy. Do you think we should have one ?

It's no fun when a driver ends up in the tree and no maintainer is
assigned to it, as that means I need to manage it myself.  I've been
doing so since 2011, so it's not exactly a new experience, but as I have
no hardware for this, and honestly don't care at all about these
drivers, it's a very low priority for me to do anything with patches for
these files...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-09-13 12:56 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-11 16:58 [PATCH] firmware: vpd: fix spelling mistake "partion" -> "partition" Colin King
2018-09-12  4:58 ` Guenter Roeck
2018-09-12  5:24   ` Greg Kroah-Hartman
2018-09-12 21:10     ` Guenter Roeck
2018-09-13 12:55       ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).