* [PATCH net-next] net: phy: et011c: Remove incorrect PHY_POLL flags
@ 2018-09-13 18:36 Florian Fainelli
2018-09-13 19:13 ` Andrew Lunn
2018-09-16 22:32 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2018-09-13 18:36 UTC (permalink / raw)
To: netdev; +Cc: Florian Fainelli, Andrew Lunn, David S. Miller, open list
PHY_POLL is defined as -1 which means that we would be setting all flags of the
PHY driver, this is also not a valid flag to tell PHYLIB about, just remove it.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/et1011c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/phy/et1011c.c b/drivers/net/phy/et1011c.c
index ab541c9c56fb..565e49e7f76f 100644
--- a/drivers/net/phy/et1011c.c
+++ b/drivers/net/phy/et1011c.c
@@ -92,7 +92,6 @@ static struct phy_driver et1011c_driver[] = { {
.name = "ET1011C",
.phy_id_mask = 0xfffffff0,
.features = PHY_GBIT_FEATURES,
- .flags = PHY_POLL,
.config_aneg = et1011c_config_aneg,
.read_status = et1011c_read_status,
} };
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: et011c: Remove incorrect PHY_POLL flags
2018-09-13 18:36 [PATCH net-next] net: phy: et011c: Remove incorrect PHY_POLL flags Florian Fainelli
@ 2018-09-13 19:13 ` Andrew Lunn
2018-09-16 22:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-09-13 19:13 UTC (permalink / raw)
To: Florian Fainelli; +Cc: netdev, David S. Miller, open list
On Thu, Sep 13, 2018 at 11:36:30AM -0700, Florian Fainelli wrote:
> PHY_POLL is defined as -1 which means that we would be setting all flags of the
> PHY driver, this is also not a valid flag to tell PHYLIB about, just remove it.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: et011c: Remove incorrect PHY_POLL flags
2018-09-13 18:36 [PATCH net-next] net: phy: et011c: Remove incorrect PHY_POLL flags Florian Fainelli
2018-09-13 19:13 ` Andrew Lunn
@ 2018-09-16 22:32 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-09-16 22:32 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, andrew, linux-kernel
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Thu, 13 Sep 2018 11:36:30 -0700
> PHY_POLL is defined as -1 which means that we would be setting all flags of the
> PHY driver, this is also not a valid flag to tell PHYLIB about, just remove it.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-16 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 18:36 [PATCH net-next] net: phy: et011c: Remove incorrect PHY_POLL flags Florian Fainelli
2018-09-13 19:13 ` Andrew Lunn
2018-09-16 22:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).