From: David Miller <davem@davemloft.net>
To: qing.huang@oracle.com
Cc: leon@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
tariqt@mellanox.com
Subject: Re: [PATCH] net/mlx4_core: print firmware version during driver loading
Date: Fri, 14 Sep 2018 14:09:06 -0700 (PDT) [thread overview]
Message-ID: <20180914.140906.724918309737328254.davem@davemloft.net> (raw)
In-Reply-To: <c580ad9d-b63d-743b-2278-1c4cf3553186@oracle.com>
From: Qing Huang <qing.huang@oracle.com>
Date: Fri, 14 Sep 2018 10:15:48 -0700
> IMHO, this information is very useful and only takes up very little
> log file space. :-)
If it's critical then the log is the wrong place for it as the log
is lossy.
The proper place to obtain this information is via the fw_version
field of the ethtool_drvinfo struct. This can be obtained at any time
and is reliable. And if it isn't reliable or correct, we must fix
that.
prev parent reply other threads:[~2018-09-14 21:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 0:25 [PATCH] net/mlx4_core: print firmware version during driver loading Qing Huang
2018-09-14 4:43 ` Leon Romanovsky
2018-09-14 17:15 ` Qing Huang
2018-09-14 18:17 ` Andrew Lunn
2018-09-14 18:33 ` Qing Huang
2018-09-14 20:13 ` Andrew Lunn
2018-09-14 21:14 ` David Miller
2018-09-14 22:36 ` Qing Huang
2018-09-15 8:50 ` Leon Romanovsky
2018-09-14 21:14 ` David Miller
2018-09-14 21:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914.140906.724918309737328254.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qing.huang@oracle.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).