From: Qing Huang <qing.huang@oracle.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Leon Romanovsky <leon@kernel.org>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, tariqt@mellanox.com,
davem@davemloft.net
Subject: Re: [PATCH] net/mlx4_core: print firmware version during driver loading
Date: Fri, 14 Sep 2018 11:33:40 -0700 [thread overview]
Message-ID: <c332f10a-5ad0-53fd-5111-1964443b3092@oracle.com> (raw)
In-Reply-To: <20180914181718.GD3811@lunn.ch>
On 9/14/2018 11:17 AM, Andrew Lunn wrote:
> On Fri, Sep 14, 2018 at 10:15:48AM -0700, Qing Huang wrote:
>> The FW version is actually a very crucial piece of information and only
>> printed once here
>> when the driver is loaded. People tend to get confused when switching
>> multiple FW files
>> back and forth without running separate utility tools, especially at
>> customer sites.
>> IMHO, this information is very useful and only takes up very little log file
>> space. :-)
> Why not use ethtool -i ?
>
> $ sudo ethtool -i eth0
> driver: r8169
> version: 2.3LK-NAPI
> firmware-version: rtl8168g-2_0.0.1 02/06/13
>
> Andrew
Sure. You can also use ibstat or ibv_devinfo tool if they are installed.
But it's not very
convenient in some cases.
E.g.
A customer upgrades FW on HCAs and encounters issues. During triage,
it's much easier
to study customer uploaded log files when remotely testing different FW
files.
Thanks.
next prev parent reply other threads:[~2018-09-14 18:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 0:25 [PATCH] net/mlx4_core: print firmware version during driver loading Qing Huang
2018-09-14 4:43 ` Leon Romanovsky
2018-09-14 17:15 ` Qing Huang
2018-09-14 18:17 ` Andrew Lunn
2018-09-14 18:33 ` Qing Huang [this message]
2018-09-14 20:13 ` Andrew Lunn
2018-09-14 21:14 ` David Miller
2018-09-14 22:36 ` Qing Huang
2018-09-15 8:50 ` Leon Romanovsky
2018-09-14 21:14 ` David Miller
2018-09-14 21:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c332f10a-5ad0-53fd-5111-1964443b3092@oracle.com \
--to=qing.huang@oracle.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).