From: kbuild test robot <lkp@intel.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: kbuild-all@01.org, x86@kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, "Brijesh Singh" <brijesh.singh@amd.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Borislav Petkov" <bp@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Sean Christopherson" <sean.j.christopherson@intel.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v8 2/2] x86/kvm: use __bss_decrypted attribute in shared variables
Date: Fri, 14 Sep 2018 08:25:10 +0800 [thread overview]
Message-ID: <201809140805.OZWpgTrh%fengguang.wu@intel.com> (raw)
In-Reply-To: <1536875471-17391-3-git-send-email-brijesh.singh@amd.com>
[-- Attachment #1: Type: text/plain, Size: 4269 bytes --]
Hi Brijesh,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Brijesh-Singh/x86-mm-add-bss-decrypted-section-to-hold-shared-variables/20180914-080110
config: x86_64-randconfig-x019-201836 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from arch/x86/include/asm/cpumask.h:5:0,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:21,
from arch/x86/include/asm/cpufeature.h:5,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:38,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:81,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/uapi/linux/timex.h:56,
from include/linux/timex.h:56,
from include/linux/clocksource.h:13,
from arch/x86/kernel/kvmclock.c:19:
arch/x86/kernel/kvmclock.c: In function 'kvmclock_init_mem':
>> include/linux/cpumask.h:109:29: warning: large integer implicitly truncated to unsigned type [-Woverflow]
#define num_possible_cpus() 1U
^
>> arch/x86/kernel/kvmclock.c:243:23: note: in expansion of macro 'num_possible_cpus'
unsigned int ncpus = num_possible_cpus() - HVC_BOOT_ARRAY_SIZE;
^~~~~~~~~~~~~~~~~
--
In file included from arch/x86/include/asm/cpumask.h:5:0,
from arch/x86/include/asm/msr.h:11,
from arch/x86/include/asm/processor.h:21,
from arch/x86/include/asm/cpufeature.h:5,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:38,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:81,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/uapi/linux/timex.h:56,
from include/linux/timex.h:56,
from include/linux/clocksource.h:13,
from arch/x86//kernel/kvmclock.c:19:
arch/x86//kernel/kvmclock.c: In function 'kvmclock_init_mem':
>> include/linux/cpumask.h:109:29: warning: large integer implicitly truncated to unsigned type [-Woverflow]
#define num_possible_cpus() 1U
^
arch/x86//kernel/kvmclock.c:243:23: note: in expansion of macro 'num_possible_cpus'
unsigned int ncpus = num_possible_cpus() - HVC_BOOT_ARRAY_SIZE;
^~~~~~~~~~~~~~~~~
vim +/num_possible_cpus +243 arch/x86/kernel/kvmclock.c
240
241 static void __init kvmclock_init_mem(void)
242 {
> 243 unsigned int ncpus = num_possible_cpus() - HVC_BOOT_ARRAY_SIZE;
244 unsigned int order = get_order(ncpus * sizeof(*hvclock_mem));
245 struct page *p;
246 int r;
247
248 p = alloc_pages(GFP_KERNEL, order);
249 if (p) {
250 hvclock_mem = page_address(p);
251
252 /*
253 * hvclock is shared between the guest and the hypervisor, must
254 * be mapped decrypted.
255 */
256 if (sev_active()) {
257 r = set_memory_decrypted((unsigned long) hvclock_mem,
258 1UL << order);
259 if (r) {
260 __free_pages(p, order);
261 hvclock_mem = NULL;
262 return;
263 }
264 }
265
266 memset(hvclock_mem, 0, PAGE_SIZE << order);
267 }
268 }
269
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30774 bytes --]
prev parent reply other threads:[~2018-09-14 0:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 21:51 [PATCH v8 0/2] x86: Fix SEV guest regression Brijesh Singh
2018-09-13 21:51 ` [PATCH v8 1/2] x86/mm: add .bss..decrypted section to hold shared variables Brijesh Singh
2018-09-13 23:24 ` Thomas Gleixner
2018-09-14 2:14 ` Brijesh Singh
2018-09-14 7:10 ` Borislav Petkov
2018-09-14 11:58 ` Brijesh Singh
2018-09-14 12:17 ` Thomas Gleixner
2018-09-14 14:12 ` Borislav Petkov
2018-09-14 14:27 ` Brijesh Singh
2018-09-14 14:45 ` Borislav Petkov
2018-09-14 14:50 ` Tom Lendacky
2018-09-14 14:55 ` Thomas Gleixner
2018-09-13 21:51 ` [PATCH v8 2/2] x86/kvm: use __bss_decrypted attribute in " Brijesh Singh
2018-09-13 23:31 ` Thomas Gleixner
2018-09-14 0:25 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201809140805.OZWpgTrh%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=kbuild-all@01.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).