Re: [PATCH v8 1/2] x86/mm: add .bss..decrypted section to hold shared variables

From: Thomas Gleixner <tglx@linutronix.de>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, "Tom Lendacky" <thomas.lendacky@amd.com>,
	"Borislav Petkov" <bp@suse.de>, "H. Peter Anvin" <hpa@zytor.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Sean Christopherson" <sean.j.christopherson@intel.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v8 1/2] x86/mm: add .bss..decrypted section to hold shared variables
Date: Fri, 14 Sep 2018 01:24:53 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1809140122590.1473@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1536875471-17391-2-git-send-email-brijesh.singh@amd.com>

On Thu, 13 Sep 2018, Brijesh Singh wrote:
>  
> +void __weak mem_encrypt_free_decrypted_mem(void) { }
> +
>  void __ref free_initmem(void)
>  {
>  	e820__reallocate_tables();
>  
> +	mem_encrypt_free_decrypted_mem();
> +
>  	free_kernel_image_pages(&__init_begin, &__init_end);
>  }
>  
> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
> index b2de398..718acdf 100644
> --- a/arch/x86/mm/mem_encrypt.c
> +++ b/arch/x86/mm/mem_encrypt.c
> @@ -348,6 +348,16 @@ bool sev_active(void)
>  EXPORT_SYMBOL(sev_active);
>  
>  /* Architecture __weak replacement functions */
> +void __init mem_encrypt_free_decrypted_mem(void)
> +{
> +	if (mem_encrypt_active())
> +		return;

Why?

> +
> +	free_init_pages("unused decrypted",
> +			(unsigned long)__start_bss_decrypted_unused,
> +			(unsigned long)__end_bss_decrypted);

Everything _AFTER_ __start_bss_decrypted_unused _IS_ unused and can be
freed. No conditional nothing. It's unused in any case.

Thanks,

	tglx