LKML Archive on lore.kernel.org
 help / Atom feed
* [PATCH] staging: greybus: fix spelling mistake "entires" -> "entries"
@ 2018-09-14 11:24 Colin King
  2018-09-14 11:43 ` [greybus-dev] " Alex Elder
  0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2018-09-14 11:24 UTC (permalink / raw)
  To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, greybus-dev, devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to spelling mistake

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/staging/greybus/tools/README.loopback | 2 +-
 drivers/staging/greybus/tools/loopback_test.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/tools/README.loopback b/drivers/staging/greybus/tools/README.loopback
index 845b08dc4696..070a510cbe7c 100644
--- a/drivers/staging/greybus/tools/README.loopback
+++ b/drivers/staging/greybus/tools/README.loopback
@@ -79,7 +79,7 @@ Here is the summary of the available options:
    -t     must be one of the test names - sink, transfer or ping
    -i     iteration count - the number of iterations to run the test over
  Optional arguments
-   -S     sysfs location - location for greybus 'endo' entires default /sys/bus/greybus/devices/
+   -S     sysfs location - location for greybus 'endo' entries default /sys/bus/greybus/devices/
    -D     debugfs location - location for loopback debugfs entries default /sys/kernel/debug/gb_loopback/
    -s     size of data packet to send during test - defaults to zero
    -m     mask - a bit mask of connections to include example: -m 8 = 4th connection -m 9 = 1st and 4th connection etc
diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
index b82e2befe935..2fa88092514d 100644
--- a/drivers/staging/greybus/tools/loopback_test.c
+++ b/drivers/staging/greybus/tools/loopback_test.c
@@ -192,7 +192,7 @@ void usage(void)
 	"   -t     must be one of the test names - sink, transfer or ping\n"
 	"   -i     iteration count - the number of iterations to run the test over\n"
 	" Optional arguments\n"
-	"   -S     sysfs location - location for greybus 'endo' entires default /sys/bus/greybus/devices/\n"
+	"   -S     sysfs location - location for greybus 'endo' entries default /sys/bus/greybus/devices/\n"
 	"   -D     debugfs location - location for loopback debugfs entries default /sys/kernel/debug/gb_loopback/\n"
 	"   -s     size of data packet to send during test - defaults to zero\n"
 	"   -m     mask - a bit mask of connections to include example: -m 8 = 4th connection -m 9 = 1st and 4th connection etc\n"
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [greybus-dev] [PATCH] staging: greybus: fix spelling mistake "entires" -> "entries"
  2018-09-14 11:24 [PATCH] staging: greybus: fix spelling mistake "entires" -> "entries" Colin King
@ 2018-09-14 11:43 ` " Alex Elder
  2018-09-14 12:07   ` Colin Ian King
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Elder @ 2018-09-14 11:43 UTC (permalink / raw)
  To: Colin King, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
	greybus-dev, devel
  Cc: kernel-janitors, linux-kernel

On 09/14/2018 06:24 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Trivial fix to spelling mistake

I hate to have two-character fixes to documentation like this.  I.e.,
as long as you're touching the README file it might have been nice to
review it and look for other things.  I suspect you found this in the
program output though, and also noticed it in the README file.

So...  Looks good to me.

Reviewed-by: Alex Elder <elder@linaro.org>

> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/staging/greybus/tools/README.loopback | 2 +-
>  drivers/staging/greybus/tools/loopback_test.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/greybus/tools/README.loopback b/drivers/staging/greybus/tools/README.loopback
> index 845b08dc4696..070a510cbe7c 100644
> --- a/drivers/staging/greybus/tools/README.loopback
> +++ b/drivers/staging/greybus/tools/README.loopback
> @@ -79,7 +79,7 @@ Here is the summary of the available options:
>     -t     must be one of the test names - sink, transfer or ping
>     -i     iteration count - the number of iterations to run the test over
>   Optional arguments
> -   -S     sysfs location - location for greybus 'endo' entires default /sys/bus/greybus/devices/
> +   -S     sysfs location - location for greybus 'endo' entries default /sys/bus/greybus/devices/
>     -D     debugfs location - location for loopback debugfs entries default /sys/kernel/debug/gb_loopback/
>     -s     size of data packet to send during test - defaults to zero
>     -m     mask - a bit mask of connections to include example: -m 8 = 4th connection -m 9 = 1st and 4th connection etc
> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
> index b82e2befe935..2fa88092514d 100644
> --- a/drivers/staging/greybus/tools/loopback_test.c
> +++ b/drivers/staging/greybus/tools/loopback_test.c
> @@ -192,7 +192,7 @@ void usage(void)
>  	"   -t     must be one of the test names - sink, transfer or ping\n"
>  	"   -i     iteration count - the number of iterations to run the test over\n"
>  	" Optional arguments\n"
> -	"   -S     sysfs location - location for greybus 'endo' entires default /sys/bus/greybus/devices/\n"
> +	"   -S     sysfs location - location for greybus 'endo' entries default /sys/bus/greybus/devices/\n"
>  	"   -D     debugfs location - location for loopback debugfs entries default /sys/kernel/debug/gb_loopback/\n"
>  	"   -s     size of data packet to send during test - defaults to zero\n"
>  	"   -m     mask - a bit mask of connections to include example: -m 8 = 4th connection -m 9 = 1st and 4th connection etc\n"
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [greybus-dev] [PATCH] staging: greybus: fix spelling mistake "entires" -> "entries"
  2018-09-14 11:43 ` [greybus-dev] " Alex Elder
@ 2018-09-14 12:07   ` Colin Ian King
  0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2018-09-14 12:07 UTC (permalink / raw)
  To: Alex Elder, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
	greybus-dev, devel
  Cc: kernel-janitors, linux-kernel

On 14/09/18 12:43, Alex Elder wrote:
> On 09/14/2018 06:24 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to spelling mistake
> 
> I hate to have two-character fixes to documentation like this.  I.e.,
> as long as you're touching the README file it might have been nice to
> review it and look for other things.  I suspect you found this in the
> program output though, and also noticed it in the README file.

Indeed, it was the program output where the mistake was first spotted.

> 
> So...  Looks good to me.
> 
> Reviewed-by: Alex Elder <elder@linaro.org>
> 
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/staging/greybus/tools/README.loopback | 2 +-
>>  drivers/staging/greybus/tools/loopback_test.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/greybus/tools/README.loopback b/drivers/staging/greybus/tools/README.loopback
>> index 845b08dc4696..070a510cbe7c 100644
>> --- a/drivers/staging/greybus/tools/README.loopback
>> +++ b/drivers/staging/greybus/tools/README.loopback
>> @@ -79,7 +79,7 @@ Here is the summary of the available options:
>>     -t     must be one of the test names - sink, transfer or ping
>>     -i     iteration count - the number of iterations to run the test over
>>   Optional arguments
>> -   -S     sysfs location - location for greybus 'endo' entires default /sys/bus/greybus/devices/
>> +   -S     sysfs location - location for greybus 'endo' entries default /sys/bus/greybus/devices/
>>     -D     debugfs location - location for loopback debugfs entries default /sys/kernel/debug/gb_loopback/
>>     -s     size of data packet to send during test - defaults to zero
>>     -m     mask - a bit mask of connections to include example: -m 8 = 4th connection -m 9 = 1st and 4th connection etc
>> diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c
>> index b82e2befe935..2fa88092514d 100644
>> --- a/drivers/staging/greybus/tools/loopback_test.c
>> +++ b/drivers/staging/greybus/tools/loopback_test.c
>> @@ -192,7 +192,7 @@ void usage(void)
>>  	"   -t     must be one of the test names - sink, transfer or ping\n"
>>  	"   -i     iteration count - the number of iterations to run the test over\n"
>>  	" Optional arguments\n"
>> -	"   -S     sysfs location - location for greybus 'endo' entires default /sys/bus/greybus/devices/\n"
>> +	"   -S     sysfs location - location for greybus 'endo' entries default /sys/bus/greybus/devices/\n"
>>  	"   -D     debugfs location - location for loopback debugfs entries default /sys/kernel/debug/gb_loopback/\n"
>>  	"   -s     size of data packet to send during test - defaults to zero\n"
>>  	"   -m     mask - a bit mask of connections to include example: -m 8 = 4th connection -m 9 = 1st and 4th connection etc\n"
>>
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14 11:24 [PATCH] staging: greybus: fix spelling mistake "entires" -> "entries" Colin King
2018-09-14 11:43 ` [greybus-dev] " Alex Elder
2018-09-14 12:07   ` Colin Ian King

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox