LKML Archive on lore.kernel.org
 help / Atom feed
* [PATCH] drm: rcar-du: Remove packed VYUY support
@ 2018-09-14 13:21 Kieran Bingham
  2018-09-14 13:51 ` Laurent Pinchart
  0 siblings, 1 reply; 4+ messages in thread
From: Kieran Bingham @ 2018-09-14 13:21 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel, Kieran Bingham

The Gen3 VSP used by the DU for display does not support packed the VYUY
pixel format. Gen2 VSP hardware is able to process this format, but it
is not officially supported there either and thus it's output can not be
guaranteed.

Remove the format from the capabilities of the DU driver.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
index 4480243813ec..4576119e7777 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
@@ -126,7 +126,6 @@ static const u32 formats_kms[] = {
 	DRM_FORMAT_ARGB8888,
 	DRM_FORMAT_XRGB8888,
 	DRM_FORMAT_UYVY,
-	DRM_FORMAT_VYUY,
 	DRM_FORMAT_YUYV,
 	DRM_FORMAT_YVYU,
 	DRM_FORMAT_NV12,
@@ -155,7 +154,6 @@ static const u32 formats_v4l2[] = {
 	V4L2_PIX_FMT_ABGR32,
 	V4L2_PIX_FMT_XBGR32,
 	V4L2_PIX_FMT_UYVY,
-	V4L2_PIX_FMT_VYUY,
 	V4L2_PIX_FMT_YUYV,
 	V4L2_PIX_FMT_YVYU,
 	V4L2_PIX_FMT_NV12M,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: rcar-du: Remove packed VYUY support
  2018-09-14 13:21 [PATCH] drm: rcar-du: Remove packed VYUY support Kieran Bingham
@ 2018-09-14 13:51 ` Laurent Pinchart
  2018-09-14 13:55   ` Kieran Bingham
  0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2018-09-14 13:51 UTC (permalink / raw)
  To: Kieran Bingham; +Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel

Hi Kieran,

Thank you for the patch.

On Friday, 14 September 2018 16:21:49 EEST Kieran Bingham wrote:
> The Gen3 VSP used by the DU for display does not support packed the VYUY
> pixel format. Gen2 VSP hardware is able to process this format, but it
> is not officially supported there either and thus it's output can not be
> guaranteed.

I think we could guarantee proper operation on Gen2, but as DU + VSP operation 
isn't enabled in the drivers by default, and as the VYUY format isn't a 
strategic target, I think we can ignore that.

How about updating the commit message as follows ?

"The Gen3 VSP used by the DU for display does not support packed the VYUY 
pixel format. Gen2 VSP hardware is able to process this format, but DU + VSP 
operation isn't enabled on Gen2, and VYUY isn't a strategic format, so it can 
be ignored."

> Remove the format from the capabilities of the DU driver.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4480243813ec..4576119e7777
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> @@ -126,7 +126,6 @@ static const u32 formats_kms[] = {
>  	DRM_FORMAT_ARGB8888,
>  	DRM_FORMAT_XRGB8888,
>  	DRM_FORMAT_UYVY,
> -	DRM_FORMAT_VYUY,
>  	DRM_FORMAT_YUYV,
>  	DRM_FORMAT_YVYU,
>  	DRM_FORMAT_NV12,
> @@ -155,7 +154,6 @@ static const u32 formats_v4l2[] = {
>  	V4L2_PIX_FMT_ABGR32,
>  	V4L2_PIX_FMT_XBGR32,
>  	V4L2_PIX_FMT_UYVY,
> -	V4L2_PIX_FMT_VYUY,
>  	V4L2_PIX_FMT_YUYV,
>  	V4L2_PIX_FMT_YVYU,
>  	V4L2_PIX_FMT_NV12M,

-- 
Regards,

Laurent Pinchart




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: rcar-du: Remove packed VYUY support
  2018-09-14 13:51 ` Laurent Pinchart
@ 2018-09-14 13:55   ` Kieran Bingham
  2018-09-14 14:00     ` Laurent Pinchart
  0 siblings, 1 reply; 4+ messages in thread
From: Kieran Bingham @ 2018-09-14 13:55 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel

Hi Laurent,

On 14/09/18 14:51, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Friday, 14 September 2018 16:21:49 EEST Kieran Bingham wrote:
>> The Gen3 VSP used by the DU for display does not support packed the VYUY
>> pixel format. Gen2 VSP hardware is able to process this format, but it
>> is not officially supported there either and thus it's output can not be
>> guaranteed.
> 
> I think we could guarantee proper operation on Gen2, but as DU + VSP operation 
> isn't enabled in the drivers by default, and as the VYUY format isn't a 
> strategic target, I think we can ignore that.
> 
> How about updating the commit message as follows ?
> 
> "The Gen3 VSP used by the DU for display does not support packed the VYUY 

s/packed the/the packed/

Which was a fault in my original text :)

> pixel format. Gen2 VSP hardware is able to process this format, but DU + VSP 
> operation isn't enabled on Gen2, and VYUY isn't a strategic format, so it can 
> be ignored."

That sounds fine to me, though I don't think we would even need to state
that 'VYUY isn't a strategic format' once it's simply not available on
the only platform that is enabled to use the VSP. But I don't object to
stating it otherwise.

--
Kieran



> 
>> Remove the format from the capabilities of the DU driver.
>>
>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
>> ---
>>  drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
>> b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4480243813ec..4576119e7777
>> 100644
>> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
>> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
>> @@ -126,7 +126,6 @@ static const u32 formats_kms[] = {
>>  	DRM_FORMAT_ARGB8888,
>>  	DRM_FORMAT_XRGB8888,
>>  	DRM_FORMAT_UYVY,
>> -	DRM_FORMAT_VYUY,
>>  	DRM_FORMAT_YUYV,
>>  	DRM_FORMAT_YVYU,
>>  	DRM_FORMAT_NV12,
>> @@ -155,7 +154,6 @@ static const u32 formats_v4l2[] = {
>>  	V4L2_PIX_FMT_ABGR32,
>>  	V4L2_PIX_FMT_XBGR32,
>>  	V4L2_PIX_FMT_UYVY,
>> -	V4L2_PIX_FMT_VYUY,
>>  	V4L2_PIX_FMT_YUYV,
>>  	V4L2_PIX_FMT_YVYU,
>>  	V4L2_PIX_FMT_NV12M,
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: rcar-du: Remove packed VYUY support
  2018-09-14 13:55   ` Kieran Bingham
@ 2018-09-14 14:00     ` Laurent Pinchart
  0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2018-09-14 14:00 UTC (permalink / raw)
  To: kieran.bingham+renesas
  Cc: David Airlie, dri-devel, linux-renesas-soc, linux-kernel

Hi Kieran,

On Friday, 14 September 2018 16:55:38 EEST Kieran Bingham wrote:
> On 14/09/18 14:51, Laurent Pinchart wrote:
> > On Friday, 14 September 2018 16:21:49 EEST Kieran Bingham wrote:
> >> The Gen3 VSP used by the DU for display does not support packed the VYUY
> >> pixel format. Gen2 VSP hardware is able to process this format, but it
> >> is not officially supported there either and thus it's output can not be
> >> guaranteed.
> > 
> > I think we could guarantee proper operation on Gen2, but as DU + VSP
> > operation isn't enabled in the drivers by default, and as the VYUY format
> > isn't a strategic target, I think we can ignore that.
> > 
> > How about updating the commit message as follows ?
> > 
> > "The Gen3 VSP used by the DU for display does not support packed the VYUY
> 
> s/packed the/the packed/
> 
> Which was a fault in my original text :)
> 
> > pixel format. Gen2 VSP hardware is able to process this format, but DU +
> > VSP operation isn't enabled on Gen2, and VYUY isn't a strategic format,
> > so it can be ignored."
> 
> That sounds fine to me, though I don't think we would even need to state
> that 'VYUY isn't a strategic format' once it's simply not available on
> the only platform that is enabled to use the VSP. But I don't object to
> stating it otherwise.

It could be enabled in the drivers (I have out-of-tree patches for testing 
purpose), so the fact that we don't need the format is still important I 
think.

> >> Remove the format from the capabilities of the DU driver.
> >> 
> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> >> ---
> >> 
> >>  drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 2 --
> >>  1 file changed, 2 deletions(-)
> >> 
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 4480243813ec..4576119e7777
> >> 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c
> >> @@ -126,7 +126,6 @@ static const u32 formats_kms[] = {
> >>  	DRM_FORMAT_ARGB8888,
> >>  	DRM_FORMAT_XRGB8888,
> >>  	DRM_FORMAT_UYVY,
> >> -	DRM_FORMAT_VYUY,
> >>  	DRM_FORMAT_YUYV,
> >>  	DRM_FORMAT_YVYU,
> >>  	DRM_FORMAT_NV12,
> >> @@ -155,7 +154,6 @@ static const u32 formats_v4l2[] = {
> >>  	V4L2_PIX_FMT_ABGR32,
> >>  	V4L2_PIX_FMT_XBGR32,
> >>  	V4L2_PIX_FMT_UYVY,
> >> -	V4L2_PIX_FMT_VYUY,
> >>  	V4L2_PIX_FMT_YUYV,
> >>  	V4L2_PIX_FMT_YVYU,
> >>  	V4L2_PIX_FMT_NV12M,

-- 
Regards,

Laurent Pinchart




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14 13:21 [PATCH] drm: rcar-du: Remove packed VYUY support Kieran Bingham
2018-09-14 13:51 ` Laurent Pinchart
2018-09-14 13:55   ` Kieran Bingham
2018-09-14 14:00     ` Laurent Pinchart

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox