From: Oleg Nesterov <oleg@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [PATCH] kernel/hung_task.c: disable on suspend
Date: Fri, 14 Sep 2018 18:21:03 +0200 [thread overview]
Message-ID: <20180914162103.GA11171@redhat.com> (raw)
In-Reply-To: <87d0tg88l3.fsf@vitty.brq.redhat.com>
On 09/14, Vitaly Kuznetsov wrote:
>
> "Rafael J. Wysocki" <rjw@rjwysocki.net> writes:
>
> > On Thursday, September 13, 2018 6:08:51 PM CEST Vitaly Kuznetsov wrote:
> ...
>
> >> +static int hungtask_pm_notify(struct notifier_block *self,
> >> + unsigned long action, void *hcpu)
> >> +{
> >> + switch (action) {
> >> + case PM_SUSPEND_PREPARE:
> >> + case PM_HIBERNATION_PREPARE:
> >> + hung_detector_suspended = true;
> >> + break;
> >> + case PM_POST_SUSPEND:
> >> + case PM_POST_HIBERNATION:
> >> + hung_detector_suspended = false;
> >> + break;
> >> + default:
> >> + break;
> >> + }
> >> + return NOTIFY_OK;
> >> +}
> >> +
> >> /*
> >> * kthread which checks for tasks stuck in D state
> >> */
> >> @@ -261,7 +282,8 @@ static int watchdog(void *dummy)
> >> interval = min_t(unsigned long, interval, timeout);
> >> t = hung_timeout_jiffies(hung_last_checked, interval);
> >
> > Since you are adding the notifier anyway, what about designing it to make
> > the thread wait on _PREPARE until the notifier kicks it again on exit
> > fron suspend/hibernation?
Well. I agree that freezable kthreads are not nice, but it seems you are
going to add another questionable interface ;)
Vitaly, could you please update the changelog to explain in details whats
going on?
Where does the caller of pm_suspend() sleep in D state? Why it sleeps more
than 120 seconds?
And. given that it takes system_transition_mutex anyway, can't it use
lock_system_sleep() which marks the caller as PF_FREEZER_SKIP (checked
in check_hung_task()) ?
I have to admit I got lost...
> We can either park the kthread (kthread_park/unpark)
No, no, please don't. Nobody outside of smpboot.c should use this (and
this interface should be reworked). Yes, there are already abused, but
please don't add new users.
Oleg.
next prev parent reply other threads:[~2018-09-14 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 16:08 [PATCH] kernel/hung_task.c: disable on suspend Vitaly Kuznetsov
2018-09-14 11:26 ` Rafael J. Wysocki
2018-09-14 14:19 ` Vitaly Kuznetsov
2018-09-14 16:21 ` Oleg Nesterov [this message]
2018-09-17 8:25 ` Rafael J. Wysocki
2018-09-17 16:55 ` Oleg Nesterov
2018-09-17 21:09 ` Rafael J. Wysocki
2018-09-21 13:11 ` Vitaly Kuznetsov
2018-09-21 13:15 ` Rafael J. Wysocki
2018-09-21 15:18 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914162103.GA11171@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rjw@rjwysocki.net \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).