* [PATCH] misc: echo: Remove unnecessary parentheses and simplify check for zero
@ 2018-09-15 6:43 Nathan Chancellor
2018-09-17 17:27 ` Nick Desaulniers
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2018-09-15 6:43 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-kernel, Nick Desaulniers, Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single
conditional statement.
drivers/misc/echo/echo.c:384:27: warning: equality comparison with
extraneous parentheses [-Wparentheses-equality]
if ((ec->nonupdate_dwell == 0)) {
~~~~~~~~~~~~~~~~~~~~^~~~
drivers/misc/echo/echo.c:384:27: note: remove extraneous parentheses
around the comparison to silence this warning
if ((ec->nonupdate_dwell == 0)) {
~ ^ ~
drivers/misc/echo/echo.c:384:27: note: use '=' to turn this equality
comparison into an assignment
if ((ec->nonupdate_dwell == 0)) {
^~
=
1 warning generated.
Remove them and while we're at it, simplify the zero check as '!var' is
used more than 'var == 0'.
Reported-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/misc/echo/echo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/echo/echo.c b/drivers/misc/echo/echo.c
index 8a5adc0d2e88..3ebe5d75ad6a 100644
--- a/drivers/misc/echo/echo.c
+++ b/drivers/misc/echo/echo.c
@@ -381,7 +381,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
*/
ec->factor = 0;
ec->shift = 0;
- if ((ec->nonupdate_dwell == 0)) {
+ if (!ec->nonupdate_dwell) {
int p, logp, shift;
/* Determine:
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] misc: echo: Remove unnecessary parentheses and simplify check for zero
2018-09-15 6:43 [PATCH] misc: echo: Remove unnecessary parentheses and simplify check for zero Nathan Chancellor
@ 2018-09-17 17:27 ` Nick Desaulniers
0 siblings, 0 replies; 2+ messages in thread
From: Nick Desaulniers @ 2018-09-17 17:27 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: Arnd Bergmann, Greg KH, LKML
On Fri, Sep 14, 2018 at 11:43 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
>
> drivers/misc/echo/echo.c:384:27: warning: equality comparison with
> extraneous parentheses [-Wparentheses-equality]
> if ((ec->nonupdate_dwell == 0)) {
> ~~~~~~~~~~~~~~~~~~~~^~~~
> drivers/misc/echo/echo.c:384:27: note: remove extraneous parentheses
> around the comparison to silence this warning
> if ((ec->nonupdate_dwell == 0)) {
> ~ ^ ~
> drivers/misc/echo/echo.c:384:27: note: use '=' to turn this equality
> comparison into an assignment
> if ((ec->nonupdate_dwell == 0)) {
> ^~
> =
> 1 warning generated.
>
> Remove them and while we're at it, simplify the zero check as '!var' is
> used more than 'var == 0'.
>
> Reported-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Nathan,
Thanks for this patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> drivers/misc/echo/echo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/echo/echo.c b/drivers/misc/echo/echo.c
> index 8a5adc0d2e88..3ebe5d75ad6a 100644
> --- a/drivers/misc/echo/echo.c
> +++ b/drivers/misc/echo/echo.c
> @@ -381,7 +381,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
> */
> ec->factor = 0;
> ec->shift = 0;
> - if ((ec->nonupdate_dwell == 0)) {
> + if (!ec->nonupdate_dwell) {
> int p, logp, shift;
>
> /* Determine:
> --
> 2.18.0
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-15 6:43 [PATCH] misc: echo: Remove unnecessary parentheses and simplify check for zero Nathan Chancellor
2018-09-17 17:27 ` Nick Desaulniers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).