* [PATCH] net: usb: remove redundant null pointer check before of_node_put
@ 2018-09-16 13:20 zhong jiang
2018-09-17 15:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-16 13:20 UTC (permalink / raw)
To: davem; +Cc: woojung.huh, UNGLinuxDriver, netdev, linux-usb, linux-kernel
of_node_put has taken the null pointer check into account. So it is
safe to remove the duplicated check before of_node_put.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/usb/lan78xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 3ce3c66..34ca0ee 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1835,8 +1835,7 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev)
node = of_get_child_by_name(dev->udev->dev.of_node, "mdio");
ret = of_mdiobus_register(dev->mdiobus, node);
- if (node)
- of_node_put(node);
+ of_node_put(node);
if (ret) {
netdev_err(dev->net, "can't register MDIO bus\n");
goto exit1;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: usb: remove redundant null pointer check before of_node_put
2018-09-16 13:20 [PATCH] net: usb: remove redundant null pointer check before of_node_put zhong jiang
@ 2018-09-17 15:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-17 15:20 UTC (permalink / raw)
To: zhongjiang; +Cc: woojung.huh, UNGLinuxDriver, netdev, linux-usb, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
Date: Sun, 16 Sep 2018 21:20:17 +0800
> of_node_put has taken the null pointer check into account. So it is
> safe to remove the duplicated check before of_node_put.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-16 13:20 [PATCH] net: usb: remove redundant null pointer check before of_node_put zhong jiang
2018-09-17 15:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).