* [PATCH] dm raid: Remove bogus const from decipher_sync_action() return type
@ 2018-09-17 8:02 Geert Uytterhoeven
2018-09-17 11:58 ` [dm-devel] " Heinz Mauelshagen
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-09-17 8:02 UTC (permalink / raw)
To: Heinz Mauelshagen, Mike Snitzer, Alasdair Kergon
Cc: Arnd Bergmann, dm-devel, linux-kernel, Geert Uytterhoeven
With gcc-4.1.2:
drivers/md/dm-raid.c:3357: warning: type qualifiers ignored on function return type
Remove the "const" keyword to fix this.
Fixes: 36a240a706d43383 ("dm raid: fix RAID leg rebuild errors")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/md/dm-raid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 5ba067fa0c729bc8..c44925e4e4813d24 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -3353,7 +3353,7 @@ static const char *sync_str(enum sync_state state)
};
/* Return enum sync_state for @mddev derived from @recovery flags */
-static const enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
+static enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
{
if (test_bit(MD_RECOVERY_FROZEN, &recovery))
return st_frozen;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [dm-devel] [PATCH] dm raid: Remove bogus const from decipher_sync_action() return type
2018-09-17 8:02 [PATCH] dm raid: Remove bogus const from decipher_sync_action() return type Geert Uytterhoeven
@ 2018-09-17 11:58 ` Heinz Mauelshagen
0 siblings, 0 replies; 2+ messages in thread
From: Heinz Mauelshagen @ 2018-09-17 11:58 UTC (permalink / raw)
To: Geert Uytterhoeven, Mike Snitzer, Alasdair Kergon
Cc: dm-devel, linux-kernel, Arnd Bergmann
Yes, the compiler is right to warn about a meaningless 'const' return by
value.
Acked-by: Heinz Mauelshagen <heinzm@redhat.com>
On 09/17/2018 10:02 AM, Geert Uytterhoeven wrote:
> With gcc-4.1.2:
>
> drivers/md/dm-raid.c:3357: warning: type qualifiers ignored on function return type
>
> Remove the "const" keyword to fix this.
>
> Fixes: 36a240a706d43383 ("dm raid: fix RAID leg rebuild errors")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/md/dm-raid.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 5ba067fa0c729bc8..c44925e4e4813d24 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -3353,7 +3353,7 @@ static const char *sync_str(enum sync_state state)
> };
>
> /* Return enum sync_state for @mddev derived from @recovery flags */
> -static const enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
> +static enum sync_state decipher_sync_action(struct mddev *mddev, unsigned long recovery)
> {
> if (test_bit(MD_RECOVERY_FROZEN, &recovery))
> return st_frozen;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 11:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 8:02 [PATCH] dm raid: Remove bogus const from decipher_sync_action() return type Geert Uytterhoeven
2018-09-17 11:58 ` [dm-devel] " Heinz Mauelshagen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).