* [PATCH] mfd: arizona: Correct link for sound binding document
@ 2018-09-17 15:33 Charles Keepax
2018-09-26 22:39 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Charles Keepax @ 2018-09-17 15:33 UTC (permalink / raw)
To: lee.jones, robh+dt, mark.rutland; +Cc: devicetree, linux-kernel, patches
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index 9b62831fdf3e..148ef621a5e5 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -76,7 +76,7 @@ Deprecated properties:
Also see child specific device properties:
Regulator - ../regulator/arizona-regulator.txt
Extcon - ../extcon/extcon-arizona.txt
- Sound - ../sound/arizona.txt
+ Sound - ../sound/wlf,arizona.txt
Example:
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: arizona: Correct link for sound binding document
2018-09-17 15:33 [PATCH] mfd: arizona: Correct link for sound binding document Charles Keepax
@ 2018-09-26 22:39 ` Rob Herring
2018-09-28 5:46 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-09-26 22:39 UTC (permalink / raw)
To: Charles Keepax; +Cc: lee.jones, mark.rutland, devicetree, linux-kernel, patches
On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: arizona: Correct link for sound binding document
2018-09-26 22:39 ` Rob Herring
@ 2018-09-28 5:46 ` Lee Jones
2018-09-28 16:00 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2018-09-28 5:46 UTC (permalink / raw)
To: Rob Herring
Cc: Charles Keepax, mark.rutland, devicetree, linux-kernel, patches
On Wed, 26 Sep 2018, Rob Herring wrote:
> On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > ---
> > Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied.
Probably won't do any harm in this instance, but it's usually better
for MFD binding changes to go through the MFD tree to avoid
merge-conflicts.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: arizona: Correct link for sound binding document
2018-09-28 5:46 ` Lee Jones
@ 2018-09-28 16:00 ` Rob Herring
2018-10-09 6:55 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2018-09-28 16:00 UTC (permalink / raw)
To: Lee Jones; +Cc: Charles Keepax, Mark Rutland, devicetree, linux-kernel, patches
On Fri, Sep 28, 2018 at 12:46 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 26 Sep 2018, Rob Herring wrote:
>
> > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > ---
> > > Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Applied.
>
> Probably won't do any harm in this instance, but it's usually better
> for MFD binding changes to go through the MFD tree to avoid
> merge-conflicts.
It had been sitting there for a while, so I picked it up. Plus if we
have conflicts within a binding (other than tree wide clean ups I do),
that's not a good sign that the binding is changing.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: arizona: Correct link for sound binding document
2018-09-28 16:00 ` Rob Herring
@ 2018-10-09 6:55 ` Lee Jones
2018-10-31 15:38 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2018-10-09 6:55 UTC (permalink / raw)
To: Rob Herring
Cc: Charles Keepax, Mark Rutland, devicetree, linux-kernel, patches
On Fri, 28 Sep 2018, Rob Herring wrote:
> On Fri, Sep 28, 2018 at 12:46 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Wed, 26 Sep 2018, Rob Herring wrote:
> >
> > > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > > ---
> > > > Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Applied.
> >
> > Probably won't do any harm in this instance, but it's usually better
> > for MFD binding changes to go through the MFD tree to avoid
> > merge-conflicts.
>
> It had been sitting there for a while, so I picked it up. Plus if we
A little over a week is not 'a while'. :)
> have conflicts within a binding (other than tree wide clean ups I do),
> that's not a good sign that the binding is changing.
Not sure I understand this.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: arizona: Correct link for sound binding document
2018-10-09 6:55 ` Lee Jones
@ 2018-10-31 15:38 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2018-10-31 15:38 UTC (permalink / raw)
To: Lee Jones; +Cc: Charles Keepax, Mark Rutland, devicetree, linux-kernel, patches
On Tue, Oct 9, 2018 at 1:55 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 28 Sep 2018, Rob Herring wrote:
>
> > On Fri, Sep 28, 2018 at 12:46 AM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Wed, 26 Sep 2018, Rob Herring wrote:
> > >
> > > > On Mon, Sep 17, 2018 at 04:33:22PM +0100, Charles Keepax wrote:
> > > > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/mfd/arizona.txt | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Applied.
> > >
> > > Probably won't do any harm in this instance, but it's usually better
> > > for MFD binding changes to go through the MFD tree to avoid
> > > merge-conflicts.
> >
> > It had been sitting there for a while, so I picked it up. Plus if we
>
> A little over a week is not 'a while'. :)
You're right. Probably should have waited 2 weeks. Developers
shouldn't have to wait longer than that for a response (according to
the chief penguin).
> > have conflicts within a binding (other than tree wide clean ups I do),
> > that's not a good sign that the binding is changing.
>
> Not sure I understand this.
If there are multiple sets of changes to a single binding within 1
release cycle (more than 1 really IMO), then that is a problem in and
of itself. We may want drivers enhanced feature by feature, but I
don't want bindings to. Bindings shouldn't be evolving. Maybe
sometimes different people add different things, but then they need to
work out the dependencies and conflicts, not you or me.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-31 15:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 15:33 [PATCH] mfd: arizona: Correct link for sound binding document Charles Keepax
2018-09-26 22:39 ` Rob Herring
2018-09-28 5:46 ` Lee Jones
2018-09-28 16:00 ` Rob Herring
2018-10-09 6:55 ` Lee Jones
2018-10-31 15:38 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).