* libbpf build broken on musl libc (Alpine Linux) @ 2018-09-10 17:29 Arnaldo Carvalho de Melo 2018-09-11 10:22 ` Jakub Kicinski 0 siblings, 1 reply; 13+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-09-10 17:29 UTC (permalink / raw) To: Daniel Borkmann, Thomas Richter Cc: Jakub Kicinski, Hendrik Brueckner, Linux Kernel Mailing List, Linux Networking Development Mailing List Hi guys, Ingo updated tip/perf/core and this made me notice that perf is not building on systems using !glibc, like Alpine Linux, that uses musl libc. This ends up as: # dm 1 alpine:3.4 : FAIL gcc (Alpine 5.3.0) 5.3.0 2 alpine:3.5 : FAIL gcc (Alpine 6.2.1) 6.2.1 20160822 3 alpine:3.6 : FAIL gcc (Alpine 6.3.0) 6.3.0 4 alpine:3.7 : FAIL gcc (Alpine 6.4.0) 6.4.0 5 alpine:3.8 : FAIL gcc (Alpine 6.4.0) 6.4.0 6 alpine:edge : FAIL gcc (Alpine 6.4.0) 6.4.0 7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) 9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) 12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) 13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 14 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2 15 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2 17 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 18 debian:experimental : Ok gcc (Debian 8.2.0-4) 8.2.0 <still building on the other containers, 65 in total> CC /tmp/build/perf/libbpf.o CC /tmp/build/perf/event-plugin.o CC /tmp/build/perf/parse-options.o libbpf.c: In function 'bpf_object__elf_init': libbpf.c:472:15: error: initialization makes pointer from integer without a cast [-Werror=int-conversion] char *cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ libbpf.c: In function 'bpf_object__elf_collect': libbpf.c:813:16: error: initialization makes pointer from integer without a cast [-Werror=int-conversion] char *cp = strerror_r(-err, errmsg, ^ libbpf.c: In function 'bpf_object__create_maps': libbpf.c:1143:7: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ libbpf.c:1158:7: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ libbpf.c: In function 'load_program': libbpf.c:1342:5: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ libbpf.c: In function 'check_path': libbpf.c:1657:6: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ libbpf.c: In function 'bpf_program__pin_instance': libbpf.c:1693:6: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ libbpf.c: In function 'make_dir': libbpf.c:1711:6: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(-err, errmsg, sizeof(errmsg)); ^ libbpf.c: In function 'bpf_map__pin': libbpf.c:1773:6: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] cp = strerror_r(errno, errmsg, sizeof(errmsg)); ^ CC /tmp/build/perf/trace-seq.o CC /tmp/build/perf/parse-filter.o CC /tmp/build/perf/parse-utils.o cc1: all warnings being treated as errors mv: can't rename '/tmp/build/perf/.libbpf.o.tmp': No such file or directory This is handled in tools/perf/ by using tools/lib/str_error_r.c, that was introduced with the cset at the end of this message. After lunch I'll work on a patch to fix this, Thanks, - Arnaldo commit c8b5f2c96d1bf6cefcbe12f67dce0b892fe20512 Author: Arnaldo Carvalho de Melo <acme@redhat.com> Date: Wed Jul 6 11:56:20 2016 -0300 tools: Introduce str_error_r() The tools so far have been using the strerror_r() GNU variant, that returns a string, be it the buffer passed or something else. But that, besides being tricky in cases where we expect that the function using strerror_r() returns the error formatted in a provided buffer (we have to check if it returned something else and copy that instead), breaks the build on systems not using glibc, like Alpine Linux, where musl libc is used. So, introduce yet another wrapper, str_error_r(), that has the GNU interface, but uses the portable XSI variant of strerror_r(), so that users rest asured that the provided buffer is used and it is what is returned. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: http://lkml.kernel.org/n/tip-d4t42fnf48ytlk8rjxs822tf@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> diff --git a/tools/include/linux/string.h b/tools/include/linux/string.h index e26223f1f287..b466d0228b57 100644 --- a/tools/include/linux/string.h +++ b/tools/include/linux/string.h @@ -12,4 +12,6 @@ int strtobool(const char *s, bool *res); extern size_t strlcpy(char *dest, const char *src, size_t size); #endif +char *str_error_r(int errnum, char *buf, size_t buflen); <SNIP> ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-10 17:29 libbpf build broken on musl libc (Alpine Linux) Arnaldo Carvalho de Melo @ 2018-09-11 10:22 ` Jakub Kicinski 2018-09-11 12:15 ` Arnaldo Carvalho de Melo 0 siblings, 1 reply; 13+ messages in thread From: Jakub Kicinski @ 2018-09-11 10:22 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Linux Kernel Mailing List, Linux Networking Development Mailing List On Mon, 10 Sep 2018 14:29:03 -0300, Arnaldo Carvalho de Melo wrote: > After lunch I'll work on a patch to fix this, Hi Arnaldo! Any luck? ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-11 10:22 ` Jakub Kicinski @ 2018-09-11 12:15 ` Arnaldo Carvalho de Melo 2018-09-11 21:24 ` Alexei Starovoitov 0 siblings, 1 reply; 13+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-09-11 12:15 UTC (permalink / raw) To: Jakub Kicinski Cc: Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Linux Kernel Mailing List, Linux Networking Development Mailing List Em Tue, Sep 11, 2018 at 12:22:18PM +0200, Jakub Kicinski escreveu: > On Mon, 10 Sep 2018 14:29:03 -0300, Arnaldo Carvalho de Melo wrote: > > After lunch I'll work on a patch to fix this, > Hi Arnaldo! > Any luck? Well, we need to apply the patch below and make tools/lib/str_error_r.c live in a library that libbpf and perf is linked to. We have tools/lib/api/ that I think we should make libbpf link against it, so perf would as well, and even when perf is not linked with libbpf, those symbols would be available. The patch below, as-is, is enough for tools/perf/, as it already statically links with libapi, but we need to do it properly as a library as stated above. I'm a bit busy right now, so may take me a bit more time, help in having libapi used by libbpf would be welcome. While looking at this I noticed that we should get tools/perf/check_headers.sh and move it outside perf so that libbpf can use that mechanism instead of the old ad-hoc series of diffs in its Makefile, that Jiri forgot to convert to check_headers. For reference, this is how it looks like now, the builds that take more time (second column, in seconds, i5 + NVMe) is because it builds with both gcc and clang, with and without libelf. ClearLinux is failing for an unrelated problem, its a recent container, also the ubuntu:18.04-x-i686 cross build is another unrelated problem, something related to atomics. Only the alpine (musl libc) are regressions due to the strerror_r oddity. - Arnaldo # dm 1 5.15 alpine:3.4 : FAIL gcc (Alpine 5.3.0) 5.3.0 2 5.08 alpine:3.5 : FAIL gcc (Alpine 6.2.1) 6.2.1 20160822 3 6.40 alpine:3.6 : FAIL gcc (Alpine 6.3.0) 6.3.0 4 5.38 alpine:3.7 : FAIL gcc (Alpine 6.4.0) 6.4.0 5 5.44 alpine:3.8 : FAIL gcc (Alpine 6.4.0) 6.4.0 6 5.69 alpine:edge : FAIL gcc (Alpine 6.4.0) 6.4.0 7 37.14 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 8 43.81 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) 9 28.93 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 10 29.89 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 11 22.19 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) 12 35.31 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) 13 40.22 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 14 23.39 clearlinux:latest : FAIL gcc (Clear Linux OS for Intel Architecture) 8.2.0 15 36.10 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2 16 41.81 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2 17 97.56 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 18 108.83 debian:experimental : Ok gcc (Debian 8.2.0-4) 8.2.0 19 40.88 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0 20 41.05 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0 21 36.59 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0 22 41.20 debian:experimental-x-mipsel : Ok mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0 23 39.76 fedora:20 : Ok gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7) 24 41.85 fedora:21 : Ok gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6) 25 42.56 fedora:22 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6) 26 41.62 fedora:23 : Ok gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6) 27 43.09 fedora:24 : Ok gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1) 28 36.13 fedora:24-x-ARC-uClibc : Ok arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710 29 119.56 fedora:25 : Ok gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1) 30 136.89 fedora:26 : Ok gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2) 31 136.21 fedora:27 : Ok gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6) 32 155.74 fedora:28 : Ok gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5) 33 163.56 fedora:rawhide : Ok gcc (GCC) 8.2.1 20180801 (Red Hat 8.2.1-2) 34 40.91 gentoo-stage3-amd64:latest : Ok gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0 35 43.49 mageia:5 : Ok gcc (GCC) 4.9.2 36 43.53 mageia:6 : Ok gcc (Mageia 5.5.0-1.mga6) 5.5.0 37 41.78 opensuse:13.2 : Ok gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064] 38 40.90 opensuse:42.1 : Ok gcc (SUSE Linux) 4.8.5 39 41.82 opensuse:42.2 : Ok gcc (SUSE Linux) 4.8.5 40 42.54 opensuse:42.3 : Ok gcc (SUSE Linux) 4.8.5 41 137.82 opensuse:tumbleweed : Ok gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812] 42 33.51 oraclelinux:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1) 43 39.50 oraclelinux:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1) 44 32.46 ubuntu:12.04.5 : Ok gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3 45 37.82 ubuntu:14.04.4 : Ok gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 46 34.76 ubuntu:14.04.4-x-linaro-arm64 : Ok aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0 47 93.53 ubuntu:16.04 : Ok gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609 48 34.76 ubuntu:16.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 49 33.89 ubuntu:16.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 50 34.44 ubuntu:16.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 51 33.90 ubuntu:16.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 52 34.16 ubuntu:16.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 53 32.89 ubuntu:16.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 54 100.14 ubuntu:16.10 : Ok gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005 55 107.62 ubuntu:17.10 : Ok gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0 56 111.93 ubuntu:18.04 : Ok gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 57 36.09 ubuntu:18.04-x-arm : Ok arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0 58 36.57 ubuntu:18.04-x-arm64 : Ok aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0 59 4.90 ubuntu:18.04-x-i686 : FAIL i686-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 60 27.67 ubuntu:18.04-x-m68k : Ok m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 61 36.20 ubuntu:18.04-x-powerpc : Ok powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 62 39.75 ubuntu:18.04-x-powerpc64 : Ok powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 63 40.01 ubuntu:18.04-x-powerpc64el : Ok powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 64 68.19 ubuntu:18.04-x-riscv64 : Ok riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 65 34.25 ubuntu:18.04-x-s390 : Ok s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 66 36.44 ubuntu:18.04-x-sh4 : Ok sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 67 31.68 ubuntu:18.04-x-sparc64 : Ok sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 68 104.31 ubuntu:18.10 : Ok gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0 # ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-11 12:15 ` Arnaldo Carvalho de Melo @ 2018-09-11 21:24 ` Alexei Starovoitov 2018-09-13 18:32 ` [RFC/fix] " Arnaldo Carvalho de Melo 0 siblings, 1 reply; 13+ messages in thread From: Alexei Starovoitov @ 2018-09-11 21:24 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Linux Kernel Mailing List, Linux Networking Development Mailing List On Tue, Sep 11, 2018 at 09:15:43AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 11, 2018 at 12:22:18PM +0200, Jakub Kicinski escreveu: > > On Mon, 10 Sep 2018 14:29:03 -0300, Arnaldo Carvalho de Melo wrote: > > > After lunch I'll work on a patch to fix this, > > > Hi Arnaldo! > > > Any luck? > > Well, we need to apply the patch below and make tools/lib/str_error_r.c > live in a library that libbpf and perf is linked to. do you want us to take the patch or you're applying it yourself? ^ permalink raw reply [flat|nested] 13+ messages in thread
* [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-11 21:24 ` Alexei Starovoitov @ 2018-09-13 18:32 ` Arnaldo Carvalho de Melo 2018-09-13 18:56 ` Alexei Starovoitov 0 siblings, 1 reply; 13+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-09-13 18:32 UTC (permalink / raw) To: Alexei Starovoitov Cc: Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, Linux Kernel Mailing List, Linux Networking Development Mailing List Em Tue, Sep 11, 2018 at 02:24:53PM -0700, Alexei Starovoitov escreveu: > On Tue, Sep 11, 2018 at 09:15:43AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Sep 11, 2018 at 12:22:18PM +0200, Jakub Kicinski escreveu: > > > On Mon, 10 Sep 2018 14:29:03 -0300, Arnaldo Carvalho de Melo wrote: > > > > After lunch I'll work on a patch to fix this, > > > Any luck? > > Well, we need to apply the patch below and make tools/lib/str_error_r.c > > live in a library that libbpf and perf is linked to. > do you want us to take the patch or you're applying it yourself? Please do some testing with my perf/libbpf+str_error_r branch, it has two patches to get this fixed, the one I sent and a prep one making libbpf link against libapi. [acme@jouet perf]$ git log --oneline -2 a7ab924b7fec (HEAD -> perf/urgent, acme.korg/perf/libbpf+str_error_r) tools lib bpf: Use str_error_r() to fix the build in Alpine Linux fb4a79e04c2b tools lib bpf: Build and link to tools/lib/api/ [acme@jouet perf]$ I did a lot of tests to make sure tools/perf, tools/lib/bpf, tools/bpf/bpftools and the bpf selftests all build as expected, with OUTPUT= and in place. The csets have further comments about tricky aspects of this. - Arnaldo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-13 18:32 ` [RFC/fix] " Arnaldo Carvalho de Melo @ 2018-09-13 18:56 ` Alexei Starovoitov 2018-09-13 19:44 ` Arnaldo Carvalho de Melo 2018-09-17 15:16 ` Arnaldo Carvalho de Melo 0 siblings, 2 replies; 13+ messages in thread From: Alexei Starovoitov @ 2018-09-13 18:56 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, Linux Kernel Mailing List, Linux Networking Development Mailing List On Thu, Sep 13, 2018 at 03:32:40PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 11, 2018 at 02:24:53PM -0700, Alexei Starovoitov escreveu: > > On Tue, Sep 11, 2018 at 09:15:43AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Tue, Sep 11, 2018 at 12:22:18PM +0200, Jakub Kicinski escreveu: > > > > On Mon, 10 Sep 2018 14:29:03 -0300, Arnaldo Carvalho de Melo wrote: > > > > > After lunch I'll work on a patch to fix this, > > > > Any luck? > > > > Well, we need to apply the patch below and make tools/lib/str_error_r.c > > > live in a library that libbpf and perf is linked to. > > > do you want us to take the patch or you're applying it yourself? > > Please do some testing with my perf/libbpf+str_error_r branch, it has > two patches to get this fixed, the one I sent and a prep one making > libbpf link against libapi. > > [acme@jouet perf]$ git log --oneline -2 > a7ab924b7fec (HEAD -> perf/urgent, acme.korg/perf/libbpf+str_error_r) tools lib bpf: Use str_error_r() to fix the build in Alpine Linux > fb4a79e04c2b tools lib bpf: Build and link to tools/lib/api/ https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/libbpf%2bstr_error_r&id=fb4a79e04c2b37ee873a3b31a3250925cf466fff we cannot do this. lib/api is GPL we cannot use it in LGPL library. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-13 18:56 ` Alexei Starovoitov @ 2018-09-13 19:44 ` Arnaldo Carvalho de Melo 2018-09-17 15:16 ` Arnaldo Carvalho de Melo 1 sibling, 0 replies; 13+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-09-13 19:44 UTC (permalink / raw) To: Alexei Starovoitov Cc: Josh Poimboeuf, Arnaldo Carvalho de Melo, Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, Linux Kernel Mailing List, Linux Networking Development Mailing List Em Thu, Sep 13, 2018 at 11:56:31AM -0700, Alexei Starovoitov escreveu: > On Thu, Sep 13, 2018 at 03:32:40PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Sep 11, 2018 at 02:24:53PM -0700, Alexei Starovoitov escreveu: > > > On Tue, Sep 11, 2018 at 09:15:43AM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Tue, Sep 11, 2018 at 12:22:18PM +0200, Jakub Kicinski escreveu: > > > > > On Mon, 10 Sep 2018 14:29:03 -0300, Arnaldo Carvalho de Melo wrote: > > > > > > After lunch I'll work on a patch to fix this, > > > > > Any luck? > > > > > > Well, we need to apply the patch below and make tools/lib/str_error_r.c > > > > live in a library that libbpf and perf is linked to. > > > > > do you want us to take the patch or you're applying it yourself? > > > > Please do some testing with my perf/libbpf+str_error_r branch, it has > > two patches to get this fixed, the one I sent and a prep one making > > libbpf link against libapi. > > > > [acme@jouet perf]$ git log --oneline -2 > > a7ab924b7fec (HEAD -> perf/urgent, acme.korg/perf/libbpf+str_error_r) tools lib bpf: Use str_error_r() to fix the build in Alpine Linux > > fb4a79e04c2b tools lib bpf: Build and link to tools/lib/api/ > > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/libbpf%2bstr_error_r&id=fb4a79e04c2b37ee873a3b31a3250925cf466fff > we cannot do this. > lib/api is GPL we cannot use it in LGPL library. Humm, I wrote tools/lib/str_error_r.c, so I can possibly relicense it as LGPL and then link just that one, as I did in one of my local patches. The only line that is not from me in tha file is from Josh Poinboeuf, which I CCed here. - Arnaldo ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-13 18:56 ` Alexei Starovoitov 2018-09-13 19:44 ` Arnaldo Carvalho de Melo @ 2018-09-17 15:16 ` Arnaldo Carvalho de Melo 2018-09-18 0:52 ` Alexei Starovoitov 2018-09-19 11:36 ` [tip:perf/urgent] tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems tip-bot for Arnaldo Carvalho de Melo 1 sibling, 2 replies; 13+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-09-17 15:16 UTC (permalink / raw) To: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo, Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, Linux Kernel Mailing List, Linux Networking Development Mailing List Em Thu, Sep 13, 2018 at 11:56:31AM -0700, Alexei Starovoitov escreveu: > On Thu, Sep 13, 2018 at 03:32:40PM -0300, Arnaldo Carvalho de Melo wrote: > > Please do some testing with my perf/libbpf+str_error_r branch, it has > > two patches to get this fixed, the one I sent and a prep one making > > libbpf link against libapi. > > [acme@jouet perf]$ git log --oneline -2 > > a7ab924b7fec (HEAD -> perf/urgent, acme.korg/perf/libbpf+str_error_r) tools lib bpf: Use str_error_r() to fix the build in Alpine Linux > > fb4a79e04c2b tools lib bpf: Build and link to tools/lib/api/ > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/libbpf%2bstr_error_r&id=fb4a79e04c2b37ee873a3b31a3250925cf466fff > we cannot do this. > lib/api is GPL we cannot use it in LGPL library. So, look at this second attempt, are you ok with it? Builds with all the Alpine Linux test build containers and some more, still building with all the others: 1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0 2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822 3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0 4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0 5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0 6 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0 7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) 9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) 11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) 12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) 13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) 14 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2 15 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2 16 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 17 debian:experimental : Ok gcc (Debian 8.2.0-4) 8.2.0 18 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0 19 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0 commit 1ca0d8249e5bd335b1c33a33569e4ed94025128e Author: Arnaldo Carvalho de Melo <acme@redhat.com> Date: Fri Sep 14 16:47:14 2018 -0300 tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems Same problem that got fixed in a similar fashion in tools/perf/ in c8b5f2c96d1b ("tools: Introduce str_error_r()"), fix it in the same way, licensing needs to be sorted out to libbpf to use libapi, so, for this simple case, just get the same wrapper in tools/lib/bpf. This makes libbpf and its users (bpftool, selftests, perf) to build again in Alpine Linux 3.[45678] and edge. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: David Ahern <dsahern@gmail.com> Cc: Hendrik Brueckner <brueckner@linux.ibm.com> Cc: Jakub Kicinski <jakub.kicinski@netronome.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Martin KaFai Lau <kafai@fb.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Quentin Monnet <quentin.monnet@netronome.com> Cc: Thomas Richter <tmricht@linux.ibm.com> Cc: Wang Nan <wangnan0@huawei.com> Cc: Yonghong Song <yhs@fb.com> Fixes: 1ce6a9fc1549 ("bpf: fix build error in libbpf with EXTRA_CFLAGS="-Wp, -D_FORTIFY_SOURCE=2 -O2"") Link: https://lkml.kernel.org/n/tip-i8ckf6s06e7tayw7xxhhhkux@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> diff --git a/tools/lib/bpf/Build b/tools/lib/bpf/Build index 13a861135127..6eb9bacd1948 100644 --- a/tools/lib/bpf/Build +++ b/tools/lib/bpf/Build @@ -1 +1 @@ -libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o +libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o str_error.o diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 2abd0f112627..bdb94939fd60 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -50,6 +50,7 @@ #include "libbpf.h" #include "bpf.h" #include "btf.h" +#include "str_error.h" #ifndef EM_BPF #define EM_BPF 247 @@ -469,7 +470,7 @@ static int bpf_object__elf_init(struct bpf_object *obj) obj->efile.fd = open(obj->path, O_RDONLY); if (obj->efile.fd < 0) { char errmsg[STRERR_BUFSIZE]; - char *cp = strerror_r(errno, errmsg, sizeof(errmsg)); + char *cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to open %s: %s\n", obj->path, cp); return -errno; @@ -810,8 +811,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj) data->d_size, name, idx); if (err) { char errmsg[STRERR_BUFSIZE]; - char *cp = strerror_r(-err, errmsg, - sizeof(errmsg)); + char *cp = str_error(-err, errmsg, sizeof(errmsg)); pr_warning("failed to alloc program %s (%s): %s", name, obj->path, cp); @@ -1140,7 +1140,7 @@ bpf_object__create_maps(struct bpf_object *obj) *pfd = bpf_create_map_xattr(&create_attr); if (*pfd < 0 && create_attr.btf_key_type_id) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("Error in bpf_create_map_xattr(%s):%s(%d). Retrying without BTF.\n", map->name, cp, errno); create_attr.btf_fd = 0; @@ -1155,7 +1155,7 @@ bpf_object__create_maps(struct bpf_object *obj) size_t j; err = *pfd; - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to create map (name: '%s'): %s\n", map->name, cp); for (j = 0; j < i; j++) @@ -1339,7 +1339,7 @@ load_program(enum bpf_prog_type type, enum bpf_attach_type expected_attach_type, } ret = -LIBBPF_ERRNO__LOAD; - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("load bpf program failed: %s\n", cp); if (log_buf && log_buf[0] != '\0') { @@ -1654,7 +1654,7 @@ static int check_path(const char *path) dir = dirname(dname); if (statfs(dir, &st_fs)) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to statfs %s: %s\n", dir, cp); err = -errno; } @@ -1690,7 +1690,7 @@ int bpf_program__pin_instance(struct bpf_program *prog, const char *path, } if (bpf_obj_pin(prog->instances.fds[instance], path)) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to pin program: %s\n", cp); return -errno; } @@ -1708,7 +1708,7 @@ static int make_dir(const char *path) err = -errno; if (err) { - cp = strerror_r(-err, errmsg, sizeof(errmsg)); + cp = str_error(-err, errmsg, sizeof(errmsg)); pr_warning("failed to mkdir %s: %s\n", path, cp); } return err; @@ -1770,7 +1770,7 @@ int bpf_map__pin(struct bpf_map *map, const char *path) } if (bpf_obj_pin(map->fd, path)) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to pin map: %s\n", cp); return -errno; } diff --git a/tools/lib/bpf/str_error.c b/tools/lib/bpf/str_error.c new file mode 100644 index 000000000000..b8798114a357 --- /dev/null +++ b/tools/lib/bpf/str_error.c @@ -0,0 +1,18 @@ +// SPDX-License-Identifier: LGPL-2.1 +#undef _GNU_SOURCE +#include <string.h> +#include <stdio.h> +#include "str_error.h" + +/* + * Wrapper to allow for building in non-GNU systems such as Alpine Linux's musl + * libc, while checking strerror_r() return to avoid having to check this in + * all places calling it. + */ +char *str_error(int err, char *dst, int len) +{ + int ret = strerror_r(err, dst, len); + if (ret) + snprintf(dst, len, "ERROR: strerror_r(%d)=%d", err, ret); + return dst; +} diff --git a/tools/lib/bpf/str_error.h b/tools/lib/bpf/str_error.h new file mode 100644 index 000000000000..b9a22564ddc6 --- /dev/null +++ b/tools/lib/bpf/str_error.h @@ -0,0 +1,6 @@ +// SPDX-License-Identifier: GPL-2.1 +#ifndef BPF_STR_ERROR +#define BPF_STR_ERROR + +char *str_error(int err, char *dst, int len); +#endif // BPF_STR_ERROR ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-17 15:16 ` Arnaldo Carvalho de Melo @ 2018-09-18 0:52 ` Alexei Starovoitov 2018-09-18 2:39 ` Jakub Kicinski 2018-09-18 13:15 ` Arnaldo Carvalho de Melo 2018-09-19 11:36 ` [tip:perf/urgent] tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems tip-bot for Arnaldo Carvalho de Melo 1 sibling, 2 replies; 13+ messages in thread From: Alexei Starovoitov @ 2018-09-18 0:52 UTC (permalink / raw) To: Arnaldo Carvalho de Melo Cc: Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, linux-kernel, netdev On Mon, Sep 17, 2018 at 12:16:36PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Sep 13, 2018 at 11:56:31AM -0700, Alexei Starovoitov escreveu: > > On Thu, Sep 13, 2018 at 03:32:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > Please do some testing with my perf/libbpf+str_error_r branch, it has > > > two patches to get this fixed, the one I sent and a prep one making > > > libbpf link against libapi. > > > > [acme@jouet perf]$ git log --oneline -2 > > > a7ab924b7fec (HEAD -> perf/urgent, acme.korg/perf/libbpf+str_error_r) tools lib bpf: Use str_error_r() to fix the build in Alpine Linux > > > fb4a79e04c2b tools lib bpf: Build and link to tools/lib/api/ > > > https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/libbpf%2bstr_error_r&id=fb4a79e04c2b37ee873a3b31a3250925cf466fff > > we cannot do this. > > lib/api is GPL we cannot use it in LGPL library. > > So, look at this second attempt, are you ok with it? > > Builds with all the Alpine Linux test build containers and some more, > still building with all the others: > > 1 alpine:3.4 : Ok gcc (Alpine 5.3.0) 5.3.0 > 2 alpine:3.5 : Ok gcc (Alpine 6.2.1) 6.2.1 20160822 > 3 alpine:3.6 : Ok gcc (Alpine 6.3.0) 6.3.0 > 4 alpine:3.7 : Ok gcc (Alpine 6.4.0) 6.4.0 > 5 alpine:3.8 : Ok gcc (Alpine 6.4.0) 6.4.0 > 6 alpine:edge : Ok gcc (Alpine 6.4.0) 6.4.0 > 7 amazonlinux:1 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > 8 amazonlinux:2 : Ok gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) > 9 android-ndk:r12b-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) > 10 android-ndk:r15c-arm : Ok arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease) > 11 centos:5 : Ok gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55) > 12 centos:6 : Ok gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23) > 13 centos:7 : Ok gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > 14 debian:7 : Ok gcc (Debian 4.7.2-5) 4.7.2 > 15 debian:8 : Ok gcc (Debian 4.9.2-10+deb8u1) 4.9.2 > 16 debian:9 : Ok gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516 > 17 debian:experimental : Ok gcc (Debian 8.2.0-4) 8.2.0 > 18 debian:experimental-x-arm64 : Ok aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0 > 19 debian:experimental-x-mips : Ok mips-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0 > > commit 1ca0d8249e5bd335b1c33a33569e4ed94025128e > Author: Arnaldo Carvalho de Melo <acme@redhat.com> > Date: Fri Sep 14 16:47:14 2018 -0300 > > tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems > > Same problem that got fixed in a similar fashion in tools/perf/ in > c8b5f2c96d1b ("tools: Introduce str_error_r()"), fix it in the same > way, licensing needs to be sorted out to libbpf to use libapi, so, > for this simple case, just get the same wrapper in tools/lib/bpf. > > This makes libbpf and its users (bpftool, selftests, perf) to build > again in Alpine Linux 3.[45678] and edge. > > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: David Ahern <dsahern@gmail.com> > Cc: Hendrik Brueckner <brueckner@linux.ibm.com> > Cc: Jakub Kicinski <jakub.kicinski@netronome.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Martin KaFai Lau <kafai@fb.com> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Quentin Monnet <quentin.monnet@netronome.com> > Cc: Thomas Richter <tmricht@linux.ibm.com> > Cc: Wang Nan <wangnan0@huawei.com> > Cc: Yonghong Song <yhs@fb.com> > Fixes: 1ce6a9fc1549 ("bpf: fix build error in libbpf with EXTRA_CFLAGS="-Wp, -D_FORTIFY_SOURCE=2 -O2"") > Link: https://lkml.kernel.org/n/tip-i8ckf6s06e7tayw7xxhhhkux@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > diff --git a/tools/lib/bpf/Build b/tools/lib/bpf/Build > index 13a861135127..6eb9bacd1948 100644 > --- a/tools/lib/bpf/Build > +++ b/tools/lib/bpf/Build > @@ -1 +1 @@ > -libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o > +libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o str_error.o > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 2abd0f112627..bdb94939fd60 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -50,6 +50,7 @@ > #include "libbpf.h" > #include "bpf.h" > #include "btf.h" > +#include "str_error.h" > > #ifndef EM_BPF > #define EM_BPF 247 > @@ -469,7 +470,7 @@ static int bpf_object__elf_init(struct bpf_object *obj) > obj->efile.fd = open(obj->path, O_RDONLY); > if (obj->efile.fd < 0) { > char errmsg[STRERR_BUFSIZE]; > - char *cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + char *cp = str_error(errno, errmsg, sizeof(errmsg)); > > pr_warning("failed to open %s: %s\n", obj->path, cp); > return -errno; > @@ -810,8 +811,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj) > data->d_size, name, idx); > if (err) { > char errmsg[STRERR_BUFSIZE]; > - char *cp = strerror_r(-err, errmsg, > - sizeof(errmsg)); > + char *cp = str_error(-err, errmsg, sizeof(errmsg)); > > pr_warning("failed to alloc program %s (%s): %s", > name, obj->path, cp); > @@ -1140,7 +1140,7 @@ bpf_object__create_maps(struct bpf_object *obj) > > *pfd = bpf_create_map_xattr(&create_attr); > if (*pfd < 0 && create_attr.btf_key_type_id) { > - cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + cp = str_error(errno, errmsg, sizeof(errmsg)); > pr_warning("Error in bpf_create_map_xattr(%s):%s(%d). Retrying without BTF.\n", > map->name, cp, errno); > create_attr.btf_fd = 0; > @@ -1155,7 +1155,7 @@ bpf_object__create_maps(struct bpf_object *obj) > size_t j; > > err = *pfd; > - cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + cp = str_error(errno, errmsg, sizeof(errmsg)); > pr_warning("failed to create map (name: '%s'): %s\n", > map->name, cp); > for (j = 0; j < i; j++) > @@ -1339,7 +1339,7 @@ load_program(enum bpf_prog_type type, enum bpf_attach_type expected_attach_type, > } > > ret = -LIBBPF_ERRNO__LOAD; > - cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + cp = str_error(errno, errmsg, sizeof(errmsg)); > pr_warning("load bpf program failed: %s\n", cp); > > if (log_buf && log_buf[0] != '\0') { > @@ -1654,7 +1654,7 @@ static int check_path(const char *path) > > dir = dirname(dname); > if (statfs(dir, &st_fs)) { > - cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + cp = str_error(errno, errmsg, sizeof(errmsg)); > pr_warning("failed to statfs %s: %s\n", dir, cp); > err = -errno; > } > @@ -1690,7 +1690,7 @@ int bpf_program__pin_instance(struct bpf_program *prog, const char *path, > } > > if (bpf_obj_pin(prog->instances.fds[instance], path)) { > - cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + cp = str_error(errno, errmsg, sizeof(errmsg)); > pr_warning("failed to pin program: %s\n", cp); > return -errno; > } > @@ -1708,7 +1708,7 @@ static int make_dir(const char *path) > err = -errno; > > if (err) { > - cp = strerror_r(-err, errmsg, sizeof(errmsg)); > + cp = str_error(-err, errmsg, sizeof(errmsg)); > pr_warning("failed to mkdir %s: %s\n", path, cp); > } > return err; > @@ -1770,7 +1770,7 @@ int bpf_map__pin(struct bpf_map *map, const char *path) > } > > if (bpf_obj_pin(map->fd, path)) { > - cp = strerror_r(errno, errmsg, sizeof(errmsg)); > + cp = str_error(errno, errmsg, sizeof(errmsg)); > pr_warning("failed to pin map: %s\n", cp); > return -errno; > } > diff --git a/tools/lib/bpf/str_error.c b/tools/lib/bpf/str_error.c > new file mode 100644 > index 000000000000..b8798114a357 > --- /dev/null > +++ b/tools/lib/bpf/str_error.c > @@ -0,0 +1,18 @@ > +// SPDX-License-Identifier: LGPL-2.1 > +#undef _GNU_SOURCE > +#include <string.h> > +#include <stdio.h> > +#include "str_error.h" > + > +/* > + * Wrapper to allow for building in non-GNU systems such as Alpine Linux's musl > + * libc, while checking strerror_r() return to avoid having to check this in > + * all places calling it. > + */ > +char *str_error(int err, char *dst, int len) > +{ > + int ret = strerror_r(err, dst, len); > + if (ret) > + snprintf(dst, len, "ERROR: strerror_r(%d)=%d", err, ret); > + return dst; > +} > diff --git a/tools/lib/bpf/str_error.h b/tools/lib/bpf/str_error.h > new file mode 100644 > index 000000000000..b9a22564ddc6 > --- /dev/null > +++ b/tools/lib/bpf/str_error.h > @@ -0,0 +1,6 @@ > +// SPDX-License-Identifier: GPL-2.1 LGPL-2.1 in the above? The rest looks good to me. Should we take it via bpf-next tree? If you feel there is an urgency to fix musl build, we can take it via bpf tree too. Jakub, thoughts? you've been messing with strerror last.. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-18 0:52 ` Alexei Starovoitov @ 2018-09-18 2:39 ` Jakub Kicinski 2018-09-18 4:18 ` Alexei Starovoitov 2018-09-18 13:15 ` Arnaldo Carvalho de Melo 1 sibling, 1 reply; 13+ messages in thread From: Jakub Kicinski @ 2018-09-18 2:39 UTC (permalink / raw) To: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, linux-kernel, netdev On Mon, 17 Sep 2018 17:52:59 -0700, Alexei Starovoitov wrote: > LGPL-2.1 in the above? Could we possibly make it dual licensed LGPL + BSD? > The rest looks good to me. > Should we take it via bpf-next tree? > If you feel there is an urgency to fix musl build, we can take it via > bpf tree too. > > Jakub, thoughts? you've been messing with strerror last.. Sorry for the mess, I didn't know libc compat is such a pain. I kind of knowingly ignored the existing str_error_r(), as it didn't seem excessively clean. Yet, two months later I have no better ideas.. We could as well switch back to the XSI version, which we used before I needed access to reallocarray() (I mean change the str_error() to be a plain XSI wrapper). Perhaps placing the new helper in libbpf_errno.c file would make sense? The only reason for this separate file to exist is in fact to make use of XSI-compliant strerror_r(). Also, I need to go relicense tools/include/tools/libc_compat.h ASAP too :S ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-18 2:39 ` Jakub Kicinski @ 2018-09-18 4:18 ` Alexei Starovoitov 0 siblings, 0 replies; 13+ messages in thread From: Alexei Starovoitov @ 2018-09-18 4:18 UTC (permalink / raw) To: Jakub Kicinski Cc: Arnaldo Carvalho de Melo, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, linux-kernel, netdev On Mon, Sep 17, 2018 at 07:39:52PM -0700, Jakub Kicinski wrote: > On Mon, 17 Sep 2018 17:52:59 -0700, Alexei Starovoitov wrote: > > LGPL-2.1 in the above? > > Could we possibly make it dual licensed LGPL + BSD? that's a separate discussion. let's not mix it up with this fix. > > The rest looks good to me. > > Should we take it via bpf-next tree? > > If you feel there is an urgency to fix musl build, we can take it via > > bpf tree too. > > > > Jakub, thoughts? you've been messing with strerror last.. > > Sorry for the mess, I didn't know libc compat is such a pain. > > I kind of knowingly ignored the existing str_error_r(), as it didn't > seem excessively clean. Yet, two months later I have no better > ideas.. We could as well switch back to the XSI version, which we used > before I needed access to reallocarray() (I mean change the str_error() > to be a plain XSI wrapper). > > Perhaps placing the new helper in libbpf_errno.c file would make > sense? The only reason for this separate file to exist is in fact to > make use of XSI-compliant strerror_r(). that's a good idea. libbpf_errno.c sounds more appropriate to me as well. > Also, I need to go relicense tools/include/tools/libc_compat.h ASAP > too :S argh. an oversight. pls send the patch. ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [RFC/fix] Re: libbpf build broken on musl libc (Alpine Linux) 2018-09-18 0:52 ` Alexei Starovoitov 2018-09-18 2:39 ` Jakub Kicinski @ 2018-09-18 13:15 ` Arnaldo Carvalho de Melo 1 sibling, 0 replies; 13+ messages in thread From: Arnaldo Carvalho de Melo @ 2018-09-18 13:15 UTC (permalink / raw) To: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo, Jakub Kicinski, Daniel Borkmann, Thomas Richter, Hendrik Brueckner, Jiri Olsa, Namhyung Kim, linux-kernel, netdev Em Mon, Sep 17, 2018 at 05:52:59PM -0700, Alexei Starovoitov escreveu: > > +++ b/tools/lib/bpf/str_error.h > > @@ -0,0 +1,6 @@ > > +// SPDX-License-Identifier: GPL-2.1 > > LGPL-2.1 in the above? Sure, will fix. > The rest looks good to me. Will that that as an Acked-by: you, ok? > Should we take it via bpf-next tree? No need, I have it already in perf/urgent, will push shortly to Ingo. Thanks, - Arnaldo > If you feel there is an urgency to fix musl build, we can take it via bpf tree too. > > Jakub, thoughts? you've been messing with strerror last.. ^ permalink raw reply [flat|nested] 13+ messages in thread
* [tip:perf/urgent] tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems 2018-09-17 15:16 ` Arnaldo Carvalho de Melo 2018-09-18 0:52 ` Alexei Starovoitov @ 2018-09-19 11:36 ` tip-bot for Arnaldo Carvalho de Melo 1 sibling, 0 replies; 13+ messages in thread From: tip-bot for Arnaldo Carvalho de Melo @ 2018-09-19 11:36 UTC (permalink / raw) To: linux-tip-commits Cc: dsahern, tmricht, acme, adrian.hunter, mingo, hpa, linux-kernel, yhs, wangnan0, kafai, daniel, jolsa, tglx, namhyung, quentin.monnet, ast, brueckner, jakub.kicinski Commit-ID: 6d41907c630d3196be89c9ed5a7f8258486b3eaf Gitweb: https://git.kernel.org/tip/6d41907c630d3196be89c9ed5a7f8258486b3eaf Author: Arnaldo Carvalho de Melo <acme@redhat.com> AuthorDate: Fri, 14 Sep 2018 16:47:14 -0300 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Tue, 18 Sep 2018 10:16:18 -0300 tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems Same problem that got fixed in a similar fashion in tools/perf/ in c8b5f2c96d1b ("tools: Introduce str_error_r()"), fix it in the same way, licensing needs to be sorted out to libbpf to use libapi, so, for this simple case, just get the same wrapper in tools/lib/bpf. This makes libbpf and its users (bpftool, selftests, perf) to build again in Alpine Linux 3.[45678] and edge. Acked-by: Alexei Starovoitov <ast@kernel.org> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: David Ahern <dsahern@gmail.com> Cc: Hendrik Brueckner <brueckner@linux.ibm.com> Cc: Jakub Kicinski <jakub.kicinski@netronome.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Martin KaFai Lau <kafai@fb.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Quentin Monnet <quentin.monnet@netronome.com> Cc: Thomas Richter <tmricht@linux.ibm.com> Cc: Wang Nan <wangnan0@huawei.com> Cc: Yonghong Song <yhs@fb.com> Fixes: 1ce6a9fc1549 ("bpf: fix build error in libbpf with EXTRA_CFLAGS="-Wp, -D_FORTIFY_SOURCE=2 -O2"") Link: https://lkml.kernel.org/r/20180917151636.GA21790@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/lib/bpf/Build | 2 +- tools/lib/bpf/libbpf.c | 20 ++++++++++---------- tools/lib/bpf/str_error.c | 18 ++++++++++++++++++ tools/lib/bpf/str_error.h | 6 ++++++ 4 files changed, 35 insertions(+), 11 deletions(-) diff --git a/tools/lib/bpf/Build b/tools/lib/bpf/Build index 13a861135127..6eb9bacd1948 100644 --- a/tools/lib/bpf/Build +++ b/tools/lib/bpf/Build @@ -1 +1 @@ -libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o +libbpf-y := libbpf.o bpf.o nlattr.o btf.o libbpf_errno.o str_error.o diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c index 2abd0f112627..bdb94939fd60 100644 --- a/tools/lib/bpf/libbpf.c +++ b/tools/lib/bpf/libbpf.c @@ -50,6 +50,7 @@ #include "libbpf.h" #include "bpf.h" #include "btf.h" +#include "str_error.h" #ifndef EM_BPF #define EM_BPF 247 @@ -469,7 +470,7 @@ static int bpf_object__elf_init(struct bpf_object *obj) obj->efile.fd = open(obj->path, O_RDONLY); if (obj->efile.fd < 0) { char errmsg[STRERR_BUFSIZE]; - char *cp = strerror_r(errno, errmsg, sizeof(errmsg)); + char *cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to open %s: %s\n", obj->path, cp); return -errno; @@ -810,8 +811,7 @@ static int bpf_object__elf_collect(struct bpf_object *obj) data->d_size, name, idx); if (err) { char errmsg[STRERR_BUFSIZE]; - char *cp = strerror_r(-err, errmsg, - sizeof(errmsg)); + char *cp = str_error(-err, errmsg, sizeof(errmsg)); pr_warning("failed to alloc program %s (%s): %s", name, obj->path, cp); @@ -1140,7 +1140,7 @@ bpf_object__create_maps(struct bpf_object *obj) *pfd = bpf_create_map_xattr(&create_attr); if (*pfd < 0 && create_attr.btf_key_type_id) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("Error in bpf_create_map_xattr(%s):%s(%d). Retrying without BTF.\n", map->name, cp, errno); create_attr.btf_fd = 0; @@ -1155,7 +1155,7 @@ bpf_object__create_maps(struct bpf_object *obj) size_t j; err = *pfd; - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to create map (name: '%s'): %s\n", map->name, cp); for (j = 0; j < i; j++) @@ -1339,7 +1339,7 @@ load_program(enum bpf_prog_type type, enum bpf_attach_type expected_attach_type, } ret = -LIBBPF_ERRNO__LOAD; - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("load bpf program failed: %s\n", cp); if (log_buf && log_buf[0] != '\0') { @@ -1654,7 +1654,7 @@ static int check_path(const char *path) dir = dirname(dname); if (statfs(dir, &st_fs)) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to statfs %s: %s\n", dir, cp); err = -errno; } @@ -1690,7 +1690,7 @@ int bpf_program__pin_instance(struct bpf_program *prog, const char *path, } if (bpf_obj_pin(prog->instances.fds[instance], path)) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to pin program: %s\n", cp); return -errno; } @@ -1708,7 +1708,7 @@ static int make_dir(const char *path) err = -errno; if (err) { - cp = strerror_r(-err, errmsg, sizeof(errmsg)); + cp = str_error(-err, errmsg, sizeof(errmsg)); pr_warning("failed to mkdir %s: %s\n", path, cp); } return err; @@ -1770,7 +1770,7 @@ int bpf_map__pin(struct bpf_map *map, const char *path) } if (bpf_obj_pin(map->fd, path)) { - cp = strerror_r(errno, errmsg, sizeof(errmsg)); + cp = str_error(errno, errmsg, sizeof(errmsg)); pr_warning("failed to pin map: %s\n", cp); return -errno; } diff --git a/tools/lib/bpf/str_error.c b/tools/lib/bpf/str_error.c new file mode 100644 index 000000000000..b8798114a357 --- /dev/null +++ b/tools/lib/bpf/str_error.c @@ -0,0 +1,18 @@ +// SPDX-License-Identifier: LGPL-2.1 +#undef _GNU_SOURCE +#include <string.h> +#include <stdio.h> +#include "str_error.h" + +/* + * Wrapper to allow for building in non-GNU systems such as Alpine Linux's musl + * libc, while checking strerror_r() return to avoid having to check this in + * all places calling it. + */ +char *str_error(int err, char *dst, int len) +{ + int ret = strerror_r(err, dst, len); + if (ret) + snprintf(dst, len, "ERROR: strerror_r(%d)=%d", err, ret); + return dst; +} diff --git a/tools/lib/bpf/str_error.h b/tools/lib/bpf/str_error.h new file mode 100644 index 000000000000..355b1db571d1 --- /dev/null +++ b/tools/lib/bpf/str_error.h @@ -0,0 +1,6 @@ +// SPDX-License-Identifier: LGPL-2.1 +#ifndef BPF_STR_ERROR +#define BPF_STR_ERROR + +char *str_error(int err, char *dst, int len); +#endif // BPF_STR_ERROR ^ permalink raw reply related [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-09-19 11:37 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-10 17:29 libbpf build broken on musl libc (Alpine Linux) Arnaldo Carvalho de Melo 2018-09-11 10:22 ` Jakub Kicinski 2018-09-11 12:15 ` Arnaldo Carvalho de Melo 2018-09-11 21:24 ` Alexei Starovoitov 2018-09-13 18:32 ` [RFC/fix] " Arnaldo Carvalho de Melo 2018-09-13 18:56 ` Alexei Starovoitov 2018-09-13 19:44 ` Arnaldo Carvalho de Melo 2018-09-17 15:16 ` Arnaldo Carvalho de Melo 2018-09-18 0:52 ` Alexei Starovoitov 2018-09-18 2:39 ` Jakub Kicinski 2018-09-18 4:18 ` Alexei Starovoitov 2018-09-18 13:15 ` Arnaldo Carvalho de Melo 2018-09-19 11:36 ` [tip:perf/urgent] tools lib bpf: Provide wrapper for strerror_r to build in !_GNU_SOURCE systems tip-bot for Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).