linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs/proc/vmcore.c: Convert to use vmf_error()
@ 2018-09-18 14:59 Souptick Joarder
  2018-09-18 21:38 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2018-09-18 14:59 UTC (permalink / raw)
  To: adobriyan, ganeshgr, rahul.lakkireddy, davem, akpm, arnd, willy
  Cc: linux-kernel, linux-fsdevel

This code can be replaced with vmf_error() inline function.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 fs/proc/vmcore.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index cbde728..89c6f94 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -401,7 +401,7 @@ static vm_fault_t mmap_vmcore_fault(struct vm_fault *vmf)
 		if (rc < 0) {
 			unlock_page(page);
 			put_page(page);
-			return (rc == -ENOMEM) ? VM_FAULT_OOM : VM_FAULT_SIGBUS;
+			return vmf_error(rc);
 		}
 		SetPageUptodate(page);
 	}
-- 
1.9.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] fs/proc/vmcore.c: Convert to use vmf_error()
  2018-09-18 14:59 [PATCH] fs/proc/vmcore.c: Convert to use vmf_error() Souptick Joarder
@ 2018-09-18 21:38 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2018-09-18 21:38 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: adobriyan, ganeshgr, rahul.lakkireddy, davem, akpm, arnd,
	linux-kernel, linux-fsdevel

On Tue, Sep 18, 2018 at 08:29:46PM +0530, Souptick Joarder wrote:
> This code can be replaced with vmf_error() inline function.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Reviewed-by: Matthew Wilcox <willy@infradead.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-18 21:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-18 14:59 [PATCH] fs/proc/vmcore.c: Convert to use vmf_error() Souptick Joarder
2018-09-18 21:38 ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).