From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
linux-input@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [RFC/PATCH 4/5] gpiolib: add support for fetching descriptors from static properties
Date: Wed, 19 Sep 2018 11:33:31 +0300 [thread overview]
Message-ID: <20180919083331.GP14465@lahna.fi.intel.com> (raw)
In-Reply-To: <20180918170418.GC177805@dtor-ws>
On Tue, Sep 18, 2018 at 10:04:18AM -0700, Dmitry Torokhov wrote:
> I am not sure how that would work, as there are multiple properties in
> that child array, so we can't simply take the first entry or assume that
> all entries describe GPIOs. Here is the fuller example:
>
> static const struct property_entry simone_key_enter_props[] __initconst = {
> PROPERTY_ENTRY_U32("linux,code", KEY_ENTER),
> PROPERTY_ENTRY_STRING("label", "enter"),
> PROPERTY_ENTRY_STRING("gpios", "enter-gpios"),
> { }
> };
>
> static const struct property_entry simone_key_up_props[] __initconst = {
> PROPERTY_ENTRY_U32("linux,code", KEY_UP),
> PROPERTY_ENTRY_STRING("label", "up"),
> PROPERTY_ENTRY_STRING("gpios", "up-gpios"),
> { }
> };
>
> static const struct property_entry simone_key_up_props[] __initconst = {
> PROPERTY_ENTRY_U32("linux,code", KEY_LEFT),
> PROPERTY_ENTRY_STRING("label", "left"),
> PROPERTY_ENTRY_STRING("gpios", "left-gpios"),
> { }
> };
>
> static const struct property_entry simone_key_props[] __initconst = {
> /* There are no properties at device level on this device */
> { }
> };
>
> static struct gpiod_lookup_table simone_keys_gpiod_table = {
> .dev_id = "gpio-keys",
> .table = {
> /* Use local offsets on gpiochip/port "B" */
> GPIO_LOOKUP_IDX("B", 0, "enter-gpios", 0, GPIO_ACTIVE_LOW),
> GPIO_LOOKUP_IDX("B", 1, "up-gpios", 1, GPIO_ACTIVE_LOW),
> GPIO_LOOKUP_IDX("B", 2, "left-gpios", 2, GPIO_ACTIVE_LOW),
> },
> };
>
> static struct platform_device simone_keys_device = {
> .name = "gpio-keys",
> .id = -1,
> };
>
> static void __init simone_init_machine(void)
> {
> ...
> gpiod_add_lookup_table(&simone_keys_gpiod_table);
> device_add_properties(&simone_keys_device.dev,
> simone_keys_device_props);
> device_add_child_properties(&simone_keys_device.dev,
> dev_fwnode(&simone_keys_device.dev),
> simone_key_enter_props);
> device_add_child_properties(&simone_keys_device.dev,
> dev_fwnode(&simone_keys_device.dev),
> simone_key_up_props);
> device_add_child_properties(&simone_keys_device.dev,
> dev_fwnode(&simone_keys_device.dev),
> simone_key_left_props);
> platform_device_register(&simone_keys_device);
> ...
> }
Thanks for clarifying. I missed this last part where you feed the
properties to the device.
So looks fine by me :)
next prev parent reply other threads:[~2018-09-19 8:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 18:15 [RFC/PATCH 0/5] Support children for legacy device properties Dmitry Torokhov
2018-09-17 18:15 ` [RFC/PATCH 1/5] device property: split generic properties and property sets Dmitry Torokhov
2018-09-17 18:16 ` [RFC/PATCH 2/5] device property: introduce notion of subnodes for legacy boards Dmitry Torokhov
2018-09-19 15:10 ` Heikki Krogerus
2018-09-19 17:13 ` Dmitry Torokhov
2018-09-20 10:16 ` Heikki Krogerus
2018-09-21 23:33 ` Dmitry Torokhov
2018-09-24 7:29 ` Heikki Krogerus
2018-09-20 13:53 ` Heikki Krogerus
2018-09-21 15:36 ` Linus Walleij
2018-09-24 10:20 ` Heikki Krogerus
2018-09-21 23:31 ` Dmitry Torokhov
2018-09-24 13:20 ` Heikki Krogerus
2018-09-24 18:45 ` Dmitry Torokhov
2018-09-25 12:19 ` Heikki Krogerus
2018-10-05 21:47 ` Dmitry Torokhov
2018-10-11 8:18 ` Heikki Krogerus
2018-09-17 18:16 ` [RFC/PATCH 3/5] device property: export property_set structure Dmitry Torokhov
2018-09-17 18:16 ` [RFC/PATCH 4/5] gpiolib: add support for fetching descriptors from static properties Dmitry Torokhov
2018-09-18 9:02 ` Mika Westerberg
2018-09-18 17:04 ` Dmitry Torokhov
2018-09-19 8:33 ` Mika Westerberg [this message]
2018-09-17 18:16 ` [RFC/PATCH 5/5] RFC: ARM: simone: Hacked in keys Dmitry Torokhov
2018-09-18 4:23 ` [RFC/PATCH 0/5] Support children for legacy device properties Andy Shevchenko
2018-09-18 20:05 ` Rafael J. Wysocki
2018-09-19 19:55 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919083331.GP14465@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).